From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753363AbbKAXqb (ORCPT ); Sun, 1 Nov 2015 18:46:31 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:61454 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753215AbbKAXq3 (ORCPT ); Sun, 1 Nov 2015 18:46:29 -0500 X-AuditID: cbfec7f4-f79c56d0000012ee-58-5636a452a981 Subject: Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC To: Alexandre Belloni , Alim Akhtar References: <1446186334-16510-1-git-send-email-alim.akhtar@samsung.com> <1446186334-16510-5-git-send-email-alim.akhtar@samsung.com> <20151101174048.GD22331@piout.net> Cc: lee.jones@linaro.org, broonie@kernel.org, linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <5636A44D.4090908@samsung.com> Date: Mon, 02 Nov 2015 08:46:21 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <20151101174048.GD22331@piout.net> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRmVeSWpSXmKPExsVy+t/xy7pBS8zCDOavkrHouLaYyeLBvG1s FlMfPmGzeP3C0OL+16OMFpd3zWGzmHF+H5PF/s4ORgcOjyebLjJ67Jl4ks1j06pONo871/aw efRtWcXo8XmTXABbFJdNSmpOZllqkb5dAlfG7AMrGQu2cFYce7+BuYFxLXsXIyeHhICJxOnj jVC2mMSFe+vZuhi5OIQEljJKtG7/wwqSEBL4wigxe7d2FyMHh7CAn0TT7RSQsIhAqsSW1hPs EPWrGCXW/jzPBOIwC/QySvRcnMAEUsUmYCyxefkSNhCbV0BLYvrcHhYQm0VAVWL2kRNgm0UF IiQmTmhghagRlPgx+R4LyDJOAX2J/bdsQUxmAT2J+xe1QCqYBeQlNq95yzyBUWAWkoZZCFWz kFQtYGRexSiaWppcUJyUnmuoV5yYW1yal66XnJ+7iRES8l92MC4+ZnWIUYCDUYmHN8PdLEyI NbGsuDL3EKMEB7OSCO/uQqAQb0piZVVqUX58UWlOavEhRmkOFiVx3rm73ocICaQnlqRmp6YW pBbBZJk4OKUaGNlnSsmdW99pqMHqaKax+pTLFWfetXJ5E34cCCv5FOTJMT1qwWVB56jfQttm hdufiXu+yjFVn/Owzowfszz/P7/R8GO+0KVDgpLpMauX/NLX1fwRNe3Iq0V+H5ZGhi9bzaRp WyjbbrJ7kfieBXWO36YxC17a4tC3pnqa+5uqXZfqZHQZW6exP1JiKc5INNRiLipOBAB7xivA dQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02.11.2015 02:40, Alexandre Belloni wrote: > On 30/10/2015 at 11:55:34 +0530, Alim Akhtar wrote : >> RTC found in s2mps15 is almost same as one found on s2mps13 >> with few differences in RTC_UPDATE register fields, like: >> 1> Bit[4] and Bit[1] are reversed >> - On s2mps13 >> WUDR -> bit[4], AUDR -> bit[1] >> - On s2mps15 >> WUDR -> bit[1], AUDR -> bit[4] >> 2> In case of s2mps13, for alarm register, need to set both >> WDUR and ADUR high, whereas for s2mps15 only set AUDR to high. >> 3> On s2mps15, WUDR, RUDR and AUDR functions should never be used >> at the same time. >> >> This patch add required changes to enable s2mps15 rtc timer. >> >> Cc: Alexandre Belloni >> Signed-off-by: Alim Akhtar >> --- >> drivers/rtc/rtc-s5m.c | 37 +++++++++++++++++++++++++++++++++---- >> include/linux/mfd/samsung/rtc.h | 2 ++ >> 2 files changed, 35 insertions(+), 4 deletions(-) >> > Applied after fixing the small alignment issue, thanks. > I think you cannot apply it directly because it depends on headers from patch 2/4. It won't build. Best regards, Krzysztof