Re: [PATCH v4 02/10] xen/blkfront: separate per ring information out of device info

From: Bob Liu <bob.liu@oracle.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, xen-devel@lists.xen.org,
	linux-kernel@vger.kernel.org, roger.pau@citrix.com,
	konrad.wilk@oracle.com, felipe.franciosi@citrix.com,
	axboe@fb.com, avanzini.arianna@gmail.com,
	rafal.mielniczuk@citrix.com, jonathan.davies@citrix.com,
	david.vrabel@citrix.com
Subject: Re: [PATCH v4 02/10] xen/blkfront: separate per ring information out of device info
Date: Mon, 02 Nov 2015 13:33:13 +0800	[thread overview]
Message-ID: <5636F599.8080109@oracle.com> (raw)
In-Reply-To: <201511021247.0rYk98np%fengguang.wu@intel.com>


On 11/02/2015 12:49 PM, kbuild test robot wrote:
> Hi Bob,
> 
> [auto build test ERROR on v4.3-rc7 -- if it's inappropriate base, please suggest rules for selecting the more suitable base]
> 
> url:    https://github.com/0day-ci/linux/commits/Bob-Liu/xen-block-multi-hardware-queues-rings-support/20151102-122806
> config: x86_64-allyesconfig (attached as .config)
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> Note: the linux-review/Bob-Liu/xen-block-multi-hardware-queues-rings-support/20151102-122806 HEAD b29fe44b095649f8faddc4474daba13199c1f5e0 builds fine.
>       It only hurts bisectibility.
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/block/xen-blkfront.c: In function 'blkif_queue_rq':
>>> drivers/block/xen-blkfront.c:639:17: error: 'info' undeclared (first use in this function)
>      spin_lock_irq(&info->io_lock);
>                     ^
>    drivers/block/xen-blkfront.c:639:17: note: each undeclared identifier is reported only once for each function it appears in
> 

Sorry, I didn't do the compile-test after each patch.

Here is the fix and will update in next version.
[root@x4-4 linux]# git diff

diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 2a557e4..7face5e 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -634,6 +634,7 @@ static int blkif_queue_rq(struct blk_mq_hw_ctx *hctx,
                           const struct blk_mq_queue_data *qd)
 {
        struct blkfront_ring_info *rinfo = (struct blkfront_ring_info *)hctx->driver_data;
+       struct blkfront_info *info = rinfo->dev_info;
 
        blk_mq_start_request(qd->rq);
        spin_lock_irq(&info->io_lock);
[root@x4-4 linux]# 

Thanks,
-Bob

> vim +/info +639 drivers/block/xen-blkfront.c
> 
> 907c3eb18 Bob Liu             2015-07-13  633  static int blkif_queue_rq(struct blk_mq_hw_ctx *hctx,
> 907c3eb18 Bob Liu             2015-07-13  634  			   const struct blk_mq_queue_data *qd)
> 9f27ee595 Jeremy Fitzhardinge 2007-07-17  635  {
> 2a8974fd4 Bob Liu             2015-11-02  636  	struct blkfront_ring_info *rinfo = (struct blkfront_ring_info *)hctx->driver_data;
> 9f27ee595 Jeremy Fitzhardinge 2007-07-17  637  
> 907c3eb18 Bob Liu             2015-07-13  638  	blk_mq_start_request(qd->rq);
> 907c3eb18 Bob Liu             2015-07-13 @639  	spin_lock_irq(&info->io_lock);
> 2a8974fd4 Bob Liu             2015-11-02  640  	if (RING_FULL(&rinfo->ring))
> 907c3eb18 Bob Liu             2015-07-13  641  		goto out_busy;
> 9f27ee595 Jeremy Fitzhardinge 2007-07-17  642  
> 
> :::::: The code at line 639 was first introduced by commit
> :::::: 907c3eb18e0bd86ca12a9de80befe8e3647bac3e xen-blkfront: convert to blk-mq APIs
> 
> :::::: TO: Bob Liu <bob.liu@oracle.com>
> :::::: CC: David Vrabel <david.vrabel@citrix.com>
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> 
