From: "Andrew F. Davis" <afd@ti.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Documentation: afe4404: Add DT bindings for the AFE4404 heart monitor
Date: Mon, 2 Nov 2015 10:08:30 -0600 [thread overview]
Message-ID: <56378A7E.20900@ti.com> (raw)
In-Reply-To: <CAL_JsqJJjtAXzi-3Aeb6pwwSUUv0i9g0g43Fq60CeSmNEiYoaQ@mail.gmail.com>
On 10/31/2015 01:44 PM, Rob Herring wrote:
> gmail thinks this is spam BTW.
>
Strange, the mailing lists do too.
> On Sat, Oct 31, 2015 at 11:31 AM, Andrew F. Davis <afd@ti.com> wrote:
>> Add the TI afe4404 heart monitor DT bindings documentation.
>> Create health directory created under iio.
>>
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>> ---
>> .../devicetree/bindings/iio/health/afe4404.txt | 27 ++++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/iio/health/afe4404.txt
>>
>> diff --git a/Documentation/devicetree/bindings/iio/health/afe4404.txt b/Documentation/devicetree/bindings/iio/health/afe4404.txt
>> new file mode 100644
>> index 0000000..d377033
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/health/afe4404.txt
>> @@ -0,0 +1,27 @@
>> +* Texas Instruments AFE4404 Heart rate and Pulse Oximeter
>> +
>> +Required properties:
>> + - compatible : Should be "ti,afe4404".
>> + - reg : I2C address of the device.
>> + - led-supply : Regulator supply to the device.
>
> Is led correct name or copy-n-paste? The datasheet has tx_sup and
> rx_sup for supplies.
>
Looking back at the data sheet it looks like it also has an io_sup.
rx_sup seems to be the supply that must be on to keep the device on.
io_sup and tx_sup can be disabled without losing register values and
reseting the device.
I'm not sure if it makes sense to list the needed supplies, so I may
just rename led-supply to tx_sup-supply and have the be the only one.
>> + - interrupt-parent : Phandle to he parent interrupt controller.
>> + - interrupts : The interrupt line the device ADC_RDY pin is connected to.
>> +
>> +Optional properties:
>> + - reset-gpios : GPIO used to reset the device.
>> +
>> +Example:
>> +
>> +&i2c2 {
>> + heart_mon@58 {
>> + compatible = "ti,afe4404";
>> + reg = <0x58>;
>> +
>> + led-supply = <&vbat>;
>> +
>> + interrupt-parent = <&gpio1>;
>> + interrupts = <28 IRQ_TYPE_EDGE_RISING>;
>> +
>> + reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
>> + };
>> +};
>> --
>> 1.9.1
>>
next prev parent reply other threads:[~2015-11-02 16:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1446309089-21094-1-git-send-email-afd@ti.com>
[not found] ` <1446309089-21094-2-git-send-email-afd@ti.com>
2015-10-31 18:44 ` [PATCH 1/2] Documentation: afe4404: Add DT bindings for the AFE4404 heart monitor Rob Herring
2015-11-02 16:08 ` Andrew F. Davis [this message]
2015-11-01 18:35 ` [PATCH 0/2] iio: Heart Rate Monitors Jonathan Cameron
2015-11-02 16:31 ` Andrew F. Davis
2015-11-04 18:57 ` Jonathan Cameron
[not found] ` <1446309089-21094-3-git-send-email-afd@ti.com>
2015-11-01 20:52 ` [PATCH 2/2] iio: health: Add driver for the TI AFE4404 heart monitor Jonathan Cameron
2015-11-02 20:37 ` Andrew F. Davis
2015-11-04 19:40 ` Jonathan Cameron
2015-11-04 21:17 ` Andrew F. Davis
2015-11-05 19:09 ` Jonathan Cameron
2015-11-10 19:19 ` Andrew F. Davis
2015-11-15 12:07 ` Jonathan Cameron
2015-11-17 17:07 ` Andrew F. Davis
2015-11-23 20:53 ` Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56378A7E.20900@ti.com \
--to=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).