From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754653AbbKCCGR (ORCPT ); Mon, 2 Nov 2015 21:06:17 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:52424 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753681AbbKCCGN (ORCPT ); Mon, 2 Nov 2015 21:06:13 -0500 X-AuditID: cbfec7f5-f794b6d000001495-f5-56381692b689 Subject: Re: [PATCH v3 0/7] samsung: pmu: split up SoC specific PMU data To: Pankaj Dubey , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1445864143-25695-1-git-send-email-pankaj.dubey@samsung.com> Cc: kgene.kim@samsung.com, thomas.ab@samsung.com, amitdanielk@gmail.com, Bartlomiej Zolnierkiewicz From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <5638168A.8060500@samsung.com> Date: Tue, 03 Nov 2015 11:06:02 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <1445864143-25695-1-git-send-email-pankaj.dubey@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGLMWRmVeSWpSXmKPExsVy+t/xy7qTxCzCDK7ckLX4uPolm8XGGetZ LV6/MLToXXCVzWLT42usFpd3zWGzmHF+H5PFoq1f2C06ljE6cHrsnHWX3WPzknqPvi2rGD0+ b5ILYInisklJzcksSy3St0vgyph+ci9LwWeFimvXvjI2MJ6X6GLk4JAQMJFo7WDuYuQEMsUk Ltxbz9bFyMUhJLCUUeLpo82sEM4XRonm52dZQKqEBTwkXqzbClYlIjCFUeJizzJGkElCQIkp DcIgJrNAvcTxY4kg5WwCxhKbly9hg1ggJ9HbPQlsDK+AlsTOhq9gNouAqkTrylXsILaoQITE xAkNrBA1ghI/Jt8Dq+EU8JTY9O4xC8R4PYn7F7VAwswC8hKb17xlnsAoOAtJxyyEqllIqhYw Mq9iFE0tTS4oTkrPNdIrTswtLs1L10vOz93ECAn9rzsYlx6zOsQowMGoxMO7YIl5mBBrYllx Ze4hRgkOZiUR3pdcFmFCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeWfueh8iJJCeWJKanZpakFoE k2Xi4JRqYJzW/P9Zuq9heeqTHSaCXW23TXJi5fg+iIdOmb+3/D7PdvnjFxdPbvgUGqAuGGL1 OvfOpayrISpxgfK2sn1bTsWILE9f0S/48uG/Len+u3rX9Z7r/cfxYW3JipZzH1KOuqgFzpt2 6dPt8DkrH6nFZ5p671I66Vp/v/77y5rU/bOazSe7HX6f0KLEUpyRaKjFXFScCAASsUhkeQIA AA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26.10.2015 21:55, Pankaj Dubey wrote: > This patch series is a part of continuation work from following series > [1] and [2]. > > 1: exynos: Move pmu driver to driver/soc folder and add exynos7 support > http://www.spinics.net/lists/linux-samsung-soc/msg39797.html from Amit Daniel Kacchap > 2: soc: samsung: pmu: split up SoC specific PMU data > https://lkml.org/lkml/2015/1/7/12 from me > +Cc Bartlomiej, There were some concerns for previous versions of this patchset. I cannot find all of them (e.g. Bartlomiej's are not present on lkml.org anymore) so I am not sure if they were addressed properly. I like the approach, it helps in reviewing the patch. I wonder - after adding this for ARM64 how much of duplicated code this approach reduce? Best regards, Krzysztof > Here is another attempt for the same, in this series I am splitting up SoC > specific PMU configuration data into mach-exynos folder itself, before moving > all of them under drivers/soc/samsung/. Also instead of making all changes in > single patch it has been broken into SoC specific patches to avoid large size > of patch. With this approach there will not be unwanted big churns just after > adding exynos-pmu under drivers/soc/samsung. > > All these patches are just refactoring to keep minimal changes while moving > exynos-pmu driver under drivers/soc/samsung/. Support for exynos7 PMU can be added > on top of it, in such a manner that for ARM64 build, ARM related SoC's PMU will not > get compiled and thus unnecessary increasing kernel image size. > > I have tested on Peach-Pi (Exynos5880) based chromebook for boot > and S2R functionality. > > These patches have been prepared on top of Kukjin Kim's for-next > > Changes since v2: > - Removed Amit's Samsung id as it's no more valid. > - Rebased on latest kgene tree. > - Removed redundant code from regs-pmu.h > > > Pankaj Dubey (7): > ARM: EXYNOS: removing redundant code from regs-pmu.h > ARM: EXYNOS: Move pmu specific headers under "linux/soc/samsung" > ARCH: EXYNOS: split up exynos3250 SoC specific PMU data > ARCH: EXYNOS: split up exynos4 SoC specific PMU data > ARCH: EXYNOS: split up exynos5250 SoC specific PMU data > ARCH: EXYNOS: split up exynos5420 SoC specific PMU data > drivers: soc: Add support for Exynos PMU driver > > arch/arm/mach-exynos/Kconfig | 1 + > arch/arm/mach-exynos/Makefile | 2 +- > arch/arm/mach-exynos/exynos.c | 2 +- > arch/arm/mach-exynos/mcpm-exynos.c | 2 +- > arch/arm/mach-exynos/platsmp.c | 2 +- > arch/arm/mach-exynos/pm.c | 4 +- > arch/arm/mach-exynos/pmu.c | 1004 -------------------- > arch/arm/mach-exynos/suspend.c | 4 +- > drivers/soc/samsung/Kconfig | 4 + > drivers/soc/samsung/Makefile | 4 + > drivers/soc/samsung/exynos-pmu.c | 168 ++++ > drivers/soc/samsung/exynos-pmu.h | 52 + > drivers/soc/samsung/exynos3250-pmu.c | 175 ++++ > drivers/soc/samsung/exynos4-pmu.c | 223 +++++ > drivers/soc/samsung/exynos5250-pmu.c | 196 ++++ > drivers/soc/samsung/exynos5420-pmu.c | 280 ++++++ > .../linux/soc/samsung}/exynos-pmu.h | 2 +- > .../linux/soc/samsung/exynos-regs-pmu.h | 17 +- > 18 files changed, 1116 insertions(+), 1026 deletions(-) > delete mode 100644 arch/arm/mach-exynos/pmu.c > create mode 100644 drivers/soc/samsung/exynos-pmu.c > create mode 100644 drivers/soc/samsung/exynos-pmu.h > create mode 100644 drivers/soc/samsung/exynos3250-pmu.c > create mode 100644 drivers/soc/samsung/exynos4-pmu.c > create mode 100644 drivers/soc/samsung/exynos5250-pmu.c > create mode 100644 drivers/soc/samsung/exynos5420-pmu.c > rename {arch/arm/mach-exynos => include/linux/soc/samsung}/exynos-pmu.h (90%) > rename arch/arm/mach-exynos/regs-pmu.h => include/linux/soc/samsung/exynos-regs-pmu.h (98%) >