From: Helen Koike <helen.koike@collabora.com>
To: dri-devel@lists.freedesktop.org, nicholas.kazlauskas@amd.com
Cc: andrey.grodzovsky@amd.com, daniel.vetter@ffwll.ch,
linux-kernel@vger.kernel.org, "Tomasz Figa" <tfiga@chromium.org>,
boris.brezillon@collabora.com, "David Airlie" <airlied@linux.ie>,
"Sean Paul" <seanpaul@google.com>,
kernel@collabora.com, harry.wentland@amd.com,
"Stéphane Marchesin" <marcheu@google.com>
Subject: Re: [PATCH 0/5] drm: Fix fb changes for async updates
Date: Tue, 5 Mar 2019 22:04:37 -0300 [thread overview]
Message-ID: <56381bc5-a55e-0474-d285-72677744d461@collabora.com> (raw)
In-Reply-To: <20190304144909.6267-1-helen.koike@collabora.com>
On 3/4/19 11:49 AM, Helen Koike wrote:
> Hello,
>
> This series is a first attempt to fix the slow down in performance introduced by
> "[PATCH v2] drm: Block fb changes for async plane updates" where async update
> falls back to a sync update, causing igt failures of type:
>
> "CRITICAL: completed 97 cursor updated in a period of 30 flips, we
> expect to complete approximately 15360 updates, with the threshold set
> at 7680"
>
> Please read the commit message of the first patch to understand how it works.
>
> I tested on the rockchip and on i915 (with a patch I am still working on for
> replacing cursors by async update), with igt plane_cursor_legacy and
> kms_cursor_legacy and I didn't see any regressions.
> I couldn't test on MSM and AMD because I don't have the hardware and my vc4
> raspberry pi is not recognizing my display for some reason, I would appreciate
> if anyone could help me testing those.
I managed to test on vc4, tests look good to me, please see
https://patchwork.kernel.org/patch/10837857/ for more details.
Thanks
Helen
> I also separated the patches per platform to be easier to get the tested-by tags,
> please let me know if it should be a single patch.
>
> Also, I added CC stable (as the "drm: Block fb changes for async plane updates"
> was also CCed to stable).
> I am not used to CC stable, please let me know if anything is off.
>
> Thanks!
> Helen
>
>
> Helen Koike (5):
> drm: don't block fb changes for async plane updates
> drm/rockchip: fix fb references in async update
> drm/amd: fix fb references in async update
> drm/msm: fix fb references in async update
> drm/vc4: fix fb references in async update
>
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-
> drivers/gpu/drm/drm_atomic_helper.c | 20 ++++-----
> drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 4 ++
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 42 +++++++++++--------
> drivers/gpu/drm/vc4/vc4_plane.c | 2 +-
> 5 files changed, 40 insertions(+), 31 deletions(-)
>
prev parent reply other threads:[~2019-03-06 1:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 14:49 [PATCH 0/5] drm: Fix fb changes for async updates Helen Koike
2019-03-04 14:49 ` [PATCH 1/5] drm: don't block fb changes for async plane updates Helen Koike
2019-03-04 15:46 ` Kazlauskas, Nicholas
2019-03-11 10:06 ` Boris Brezillon
2019-03-11 13:15 ` Kazlauskas, Nicholas
2019-03-11 14:20 ` Boris Brezillon
2019-03-11 19:51 ` Daniel Vetter
2019-03-11 19:58 ` Daniel Vetter
2019-03-12 9:32 ` Boris Brezillon
2019-03-12 9:44 ` Daniel Vetter
2019-03-11 19:53 ` Daniel Vetter
2019-03-11 9:39 ` Boris Brezillon
2019-03-04 14:49 ` [PATCH 2/5] drm/rockchip: fix fb references in async update Helen Koike
2019-03-04 14:49 ` [PATCH 3/5] drm/amd: " Helen Koike
2019-03-04 15:51 ` Kazlauskas, Nicholas
2019-03-04 14:49 ` [PATCH 4/5] drm/msm: " Helen Koike
2019-03-04 14:49 ` [PATCH 5/5] drm/vc4: " Helen Koike
2019-03-06 0:42 ` Helen Koike
2019-03-11 9:56 ` Boris Brezillon
2019-03-11 23:26 ` Helen Koike
2019-03-06 1:04 ` Helen Koike [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56381bc5-a55e-0474-d285-72677744d461@collabora.com \
--to=helen.koike@collabora.com \
--cc=airlied@linux.ie \
--cc=andrey.grodzovsky@amd.com \
--cc=boris.brezillon@collabora.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcheu@google.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=seanpaul@google.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).