Re: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Pavel Fedin <p.fedin@samsung.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: k.kozlowski.k@gmail.com, "'Mark Rutland'" <mark.rutland@arm.com>,
	"'Pawel Moll'" <pawel.moll@arm.com>,
	"'Ian Campbell'" <ijc+devicetree@hellion.org.uk>,
	"'Rob Herring'" <robh+dt@kernel.org>,
	"'Kukjin Kim'" <kgene@kernel.org>,
	"'Kumar Gala'" <galak@codeaurora.org>
Subject: Re: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration
Date: Tue, 03 Nov 2015 16:18:36 +0900	[thread overview]
Message-ID: <56385FCC.1090007@samsung.com> (raw)
In-Reply-To: <004d01d11604$fc7a2a80$f56e7f80$@samsung.com>

On 03.11.2015 15:58, Pavel Fedin wrote:
>  Hello!
> 
>>>>> --- cut exynos5410.dtsi ---
>>>>> 		sromc: sromc@12250000 {
>>>>> 			#address-cells = <2>;
>>>>> 			#size-cells = <1>;
>>>>> 			ranges = <0 0 0x04000000 0x20000
>>>>> 				  1 0 0x05000000 0x20000
>>>>> 				  2 0 0x06000000 0x20000
>>>>> 				  3 0 0x07000000 0x20000>;
>>>>
>>>> Do you have to use 2 cells for address? Cannot it be:
>>>>  			ranges = <0 0x04000000 0x20000
>>>>  				  1 0x05000000 0x20000
>>>>  				  2 0x06000000 0x20000
>>>>  				  3 0x07000000 0x20000>;
>>>
>>>  I tried this first, but it didn't work, and ranges translation
>>> gave me something really weird (like addr = 0x80 and
>>> size = 0x04000004).
>>
>> Did you change the address-cells to <1>?
> 
>  Of course i did.

I saw some other nodes use the ranges without the offset but maybe some
more steps are required for such configuration.

So anyway send the version with the child offset and I will try to
figure out why it is required.

Best regards,
Krzysztof