From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755266AbbKDIMq (ORCPT ); Wed, 4 Nov 2015 03:12:46 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:64253 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbbKDIMo (ORCPT ); Wed, 4 Nov 2015 03:12:44 -0500 X-AuditID: cbfec7f4-f79c56d0000012ee-a4-5639bdfa3e8f Subject: Re: [PATCH v5 2/4] ARM: dts: Add SROMc to Exynos 5410 To: Pavel Fedin , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <69aa5165bf2e696c0a684a9ba49cd4d5acb25046.1446542020.git.p.fedin@samsung.com> Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Kukjin Kim From: Krzysztof Kozlowski Message-id: <5639BDF8.1080107@samsung.com> Date: Wed, 04 Nov 2015 17:12:40 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <69aa5165bf2e696c0a684a9ba49cd4d5acb25046.1446542020.git.p.fedin@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHLMWRmVeSWpSXmKPExsVy+t/xy7q/9lqGGZxbxmQx/8g5Vov+NwtZ Lc69Wslo8fqFoUX/49fMFpseX2O1uLxrDpvFjPP7mCyWXr/IZPHq0io2iwnT17JYtO49wu7A 47Fm3hpGj8t9vUweK5d/YfPYtKqTzWPzknqPvi2rGD0+b5ILYI/isklJzcksSy3St0vgyji0 ai9TwVyeiuZjCxgbGC9ydjFyckgImEhsf7KcGcIWk7hwbz1bFyMXh5DAUkaJs7MXsUA4Xxgl OtpaGEGqhAXsJC4tv8gMkhARWMMosfzcQUaIqjZGiUtP5oK1MAs8YJS4f7kJrIVNwFhi8/Il bCA2r4CWxOPTa8BsFgFViatXd4MtFxWIkJg4oYEVokZQ4sfkeywgNqdAjMTF6XuZuhg5gIbq Sdy/qAUSZhaQl9i85i3zBEaBWUg6ZiFUzUJStYCReRWjaGppckFxUnquoV5xYm5xaV66XnJ+ 7iZGSKx82cG4+JjVIUYBDkYlHt4bjJZhQqyJZcWVuYcYJTiYlUR4m5YAhXhTEiurUovy44tK c1KLDzFKc7AoifPO3fU+REggPbEkNTs1tSC1CCbLxMEp1cDoty8hRj923qPIpxe/b9g8W/e9 1Rat+RUtHvbbjN7XyCt/6eQ2n7qgxqLQ53Jrnp0Ta9XCScvrGC+U6c2aU/C1SU1Vpk16vnIN i9sB1m4z/X1bjP2Knxq5rVzrf2nfptuB83YbJgldvKtutzY62UvB/tbL1Q4ndGcuzNPc+IFr gqTl5Ybw58xKLMUZiYZazEXFiQDf+bXhkQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03.11.2015 18:16, Pavel Fedin wrote: > This machine uses own SoC device tree file, add missing part. > We insert the complete description, with ranges, because we are going to > connect devices to it. Values in ranges are SoC-specific, so they go here > in order not to duplicate them for every machine. > > Signed-off-by: Pavel Fedin > --- > arch/arm/boot/dts/exynos5410.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi > index 4603356..9cfb814 100644 > --- a/arch/arm/boot/dts/exynos5410.dtsi > +++ b/arch/arm/boot/dts/exynos5410.dtsi > @@ -101,6 +101,17 @@ > reg = <0x10000000 0x100>; > }; > > + sromc: sromc@12250000 { > + compatible = "samsung,exynos-srom"; > + reg = <0x12250000 0x14>; > + #address-cells = <2>; > + #size-cells = <1>; > + ranges = <0 0 0x04000000 0x20000 > + 1 0 0x05000000 0x20000 > + 2 0 0x06000000 0x20000 > + 3 0 0x07000000 0x20000>; Following my comments for bindings documentation - I think it is better to add the address-cells, size-cells and ranges in 4th patch. Because actually in this patch you are adding just basic support for SROM controller: for saving and restoring registers. It could be merged even without the rest of patchset. Best regards, Krzysztof > + }; > + > pmu_system_controller: system-controller@10040000 { > compatible = "samsung,exynos5410-pmu", "syscon"; > reg = <0x10040000 0x5000>; >