From: Xishi Qiu <qiuxishi@huawei.com>
To: liuchangsheng <liuchangsheng@inspur.com>
Cc: <akpm@linux-foundation.org>, <isimatu.yasuaki@jp.fujitsu.com>,
<vbabka@suse.cz>, <yasu.isimatu@gmail.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <wunan@inspur.com>,
<yanxiaofeng@inspur.com>, <fandd@inspur.com>,
Wang Nan <wangnan0@huawei.com>,
Dave Hansen <dave.hansen@intel.com>,
Yinghai Lu <yinghai@kernel.org>,
Tang Chen <tangchen@cn.fujitsu.com>,
Toshi Kani <toshi.kani@hp.com>
Subject: Re: [PATCH V8] mm: memory hot-add: hot-added memory can not be added to movable zone by default
Date: Wed, 4 Nov 2015 18:20:14 +0800 [thread overview]
Message-ID: <5639DBDE.6000306@huawei.com> (raw)
In-Reply-To: <1446625415-11941-1-git-send-email-liuchangsheng@inspur.com>
On 2015/11/4 16:23, liuchangsheng wrote:
> After the user config CONFIG_MOVABLE_NODE,
> When the memory is hot added, should_add_memory_movable() return 0
> because all zones including ZONE_MOVABLE are empty,
> so the memory that was hot added will be assigned to ZONE_NORMAL,
> and we need using the udev rules to online the memory automatically:
> SUBSYSTEM=="memory", ACTION=="add", ATTR{state}=="offline",
> ATTR{state}="online_movable"
> The memory block onlined by udev must be adjacent to ZONE_MOVABLE.
> The events of memory section are notified to udev asynchronously,
Hi Yasuaki,
If udev onlines memory in descending order, like 3->2->1->0, it will
success, but we notifiy to udev in ascending order, like 0->1->2->3,
so the udev rules cannot online memory as movable, right?
> so it can not ensure that the memory block onlined by udev is
> adjacent to ZONE_MOVABLE.So it can't ensure memory online always success.
> But we want the whole node to be added to ZONE_MOVABLE by default.
>
> So we change should_add_memory_movable(): if the user config
> CONFIG_MOVABLE_NODE and movable_node kernel option
> and the ZONE_NORMAL is empty or the pfn of the hot-added memory
> is after the end of the ZONE_NORMAL it will always return 1
> and then the whole node will be added to ZONE_MOVABLE by default.
> If we want the node to be assigned to ZONE_NORMAL,
> we can do it as follows:
> "echo online_kernel > /sys/devices/system/memory/memoryXXX/state"
>
The order should like 0->1->2->3, right? 3->2->1->0 will be failed.
> Signed-off-by: liuchangsheng <liuchangsheng@inspur.com>
> Signed-off-by: Xiaofeng Yan <yanxiaofeng@inspur.com>
> Tested-by: Dongdong Fan <fandd@inspur.com>
> Reviewed-by: <yasu.isimatu@gmail.com>
> Cc: Wang Nan <wangnan0@huawei.com>
> Cc: Dave Hansen <dave.hansen@intel.com>
> Cc: Yinghai Lu <yinghai@kernel.org>
> Cc: Tang Chen <tangchen@cn.fujitsu.com>
> Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> Cc: Toshi Kani <toshi.kani@hp.com>
> Cc: Xishi Qiu <qiuxishi@huawei.com>
> ---
> mm/memory_hotplug.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index aa992e2..8617b9f 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1201,6 +1201,9 @@ static int check_hotplug_memory_range(u64 start, u64 size)
> /*
> * If movable zone has already been setup, newly added memory should be check.
> * If its address is higher than movable zone, it should be added as movable.
> + * And if system boots up with movable_node and config CONFIG_MOVABLE_NOD and
> + * added memory does not overlap the zone before MOVABLE_ZONE,
> + * the memory is added as movable.
> * Without this check, movable zone may overlap with other zone.
> */
> static int should_add_memory_movable(int nid, u64 start, u64 size)
> @@ -1208,6 +1211,10 @@ static int should_add_memory_movable(int nid, u64 start, u64 size)
> unsigned long start_pfn = start >> PAGE_SHIFT;
> pg_data_t *pgdat = NODE_DATA(nid);
> struct zone *movable_zone = pgdat->node_zones + ZONE_MOVABLE;
> + struct zone *pre_zone = pgdat->node_zones + (ZONE_MOVABLE - 1);
> +
> + if (movable_node_is_enabled() && (zone_end_pfn(pre_zone) <= start_pfn))
> + return 1;
>
Looks good to me.
How about add some comment in mm/Kconfig?
Thanks,
Xishi Qiu
> if (zone_is_empty(movable_zone))
> return 0;
next prev parent reply other threads:[~2015-11-04 10:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3bafc5b1154429e3cb6015dbc1c3fd88@s.corp-email.com>
2015-11-04 8:23 ` [PATCH V8] mm: memory hot-add: hot-added memory can not be added to movable zone by default liuchangsheng
2015-11-04 10:20 ` Xishi Qiu [this message]
2015-11-04 16:12 ` Yasuaki Ishimatsu
2015-11-04 16:18 ` Yasuaki Ishimatsu
2015-11-04 16:31 ` Dave Hansen
2015-11-05 3:10 ` Changsheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5639DBDE.6000306@huawei.com \
--to=qiuxishi@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=fandd@inspur.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuchangsheng@inspur.com \
--cc=tangchen@cn.fujitsu.com \
--cc=toshi.kani@hp.com \
--cc=vbabka@suse.cz \
--cc=wangnan0@huawei.com \
--cc=wunan@inspur.com \
--cc=yanxiaofeng@inspur.com \
--cc=yasu.isimatu@gmail.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).