From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965389AbbKDTtA (ORCPT ); Wed, 4 Nov 2015 14:49:00 -0500 Received: from mout.web.de ([212.227.15.3]:63132 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754990AbbKDTs4 (ORCPT ); Wed, 4 Nov 2015 14:48:56 -0500 Subject: [PATCH] sysfs: Delete an unnecessary check before the function call "kernfs_get" To: linux-kernel@vger.kernel.org, Greg Kroah-Hartman References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> Cc: kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <563A6123.8030506@users.sourceforge.net> Date: Wed, 4 Nov 2015 20:48:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:AnrFYbJE8OKyTBMrAXglTdXIt/BY2cl2c/bQKtcrMihpjdX5WmE 7ivU6hKODNC9hGMTXh66ROPaS+PRU8vFpQcpUYKUQ02DIRbYYz/HmccIptdZUd3L5ueB1Bi DzHglp/N7Y0uN2tnYhU2aDkXgoPSHW2gZT9fQL2se4c98zEkGod60qPWUkjEvj8stRCM9fe JRcKeFwwVXldsQibK2bTg== X-UI-Out-Filterresults: notjunk:1;V01:K0:p40TflMIOFE=:ylM5A6tV9Geh85mrvMPKis FwivezAuvbw5D0NtNFBxma4i9MbM0m+Vrlr1fHZZpTr/WVAbQPq5ER7SbDOzcDE49x7TtMrDP elAwMnS7X59uOCypoZZcXBgQtc03lTnjJygr3+N+3t+lo4nSICKLFHKqrHWTAEK/8PYq1rciM j4DMMS5PagOrWWaoH8FlDGw1FDdj2xoFV0qziElgKeDeNAMiMnP2BQNSwt3nOfEM5+ovxX/zJ IStu8rWK1T1P0uii8C5M6I1LXEIdb9NCUKhh0F16C2kbSjPLZ9LKpUuw9wGbEp2KqB8pBksG4 CerjL0UzIqFVgyj0HXRbMXXMXfi+ZumZdRGsrg9om2WyfAIqfetDq9YZzhR2iNm2xk2+9wDAF rwxDwMjyroVLX2VgisSZGTAqc87WPKo767ijj76LDVlKhQZEO9AA972cSY4UDKcaQgyPl3SaG If2WQR27ltCbif22gNJChuLad9dg1GxqMJkndyq3o1M1djdef+UxCWhTcdddP828Ch6+k+RmA /6HGPfpAaC9/YPa8dLOu1UPWW+sNEUgb5vPJmpLwesFLjZII6+FuB1kZe/LnE4Q4uW7/mZe5p 9aWzC4qo0T41wvUa+hCu+PVBqLmfLgAd9hSZxw7r6vcmwwrp3iNA0BkPLvIG4SRnBtIyWDlhX jDcJXHwCgcV+XRX/8rOHChY5sjqCSaQ7wd7E16pqqU9JoVChQxfpvPI+Fd1GEGebAP/ZOmPfv gH5MaVRx3gslIlUNC5sCNwkL+PQPSiOTIHh2Hh2MCi7THm9u8ZNzLAKCmIrAnBbVAd/juveAB Qjqp4Qr Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 4 Nov 2015 20:44:50 +0100 The kernfs_get() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/sysfs/group.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c index dc1358b..9b34c07 100644 --- a/fs/sysfs/group.c +++ b/fs/sysfs/group.c @@ -388,8 +388,7 @@ int __compat_only_sysfs_link_entry_to_kobj(struct kobject *kobj, */ spin_lock(&sysfs_symlink_target_lock); target = target_kobj->sd; - if (target) - kernfs_get(target); + kernfs_get(target); spin_unlock(&sysfs_symlink_target_lock); if (!target) return -ENOENT; -- 2.6.2