From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965679AbbKDU10 (ORCPT ); Wed, 4 Nov 2015 15:27:26 -0500 Received: from mout.web.de ([212.227.17.11]:57543 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755390AbbKDU1Y (ORCPT ); Wed, 4 Nov 2015 15:27:24 -0500 Subject: [PATCH] GFS2: Delete an unnecessary check before the function call "iput" To: Steven Whitehouse , cluster-devel@redhat.com, Bob Peterson References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546B20F0.9040202@users.sourceforge.net> <546B27FF.6080702@redhat.com> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <563A6A22.5000206@users.sourceforge.net> Date: Wed, 4 Nov 2015 21:27:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <546B27FF.6080702@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Z8WAMKeRAuB1QHsTrTmkjEDFKTxjwDH0/bOEnd3Ctb3V+aS87Em bIt4+T3q+7ubqaXVPseRUp2tRwQihvPYM+RpFEjVmda4Y7a2wE1ImpmES6w58sasByJUik5 Uicf/xvWCHR5Fbhbn3h3LAzBygv+l3ZhAEzVOiJB/YERjLO617tkQjvdzrRmyorcVKgz0Hr DhgtAmU0eJw33dgL28VDQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:EZLv1zHLu5c=:j8tMrgj57CmZTr1NHh+nJ8 gFecl3+x0tpTjeKfsfNUIMj0iILv3pR6PWmTZS/a9i7eiyjGmv6IA9lU163YUkIDr8avH6f+L sW9BJjMiJ6YvkpMZ/c+s4S7GZOGj3ra1az654Wc00zRKFsqbh5yv7liNRANSJ+uzbFdAUjd4+ bhjGl8iA4LYg14K1jMxdzeIMhrEBrSeCW7xQYTQD0NZgQYTwZ/DpByCZTp1NI9V7vtrG6KRBs YJKggj1iGCnuI295CNC9f5kLn7dAqVgpKhXR72tOIfkw2UQ3YRdR81/o1HmUjqGmJB7SjdNvS zY8hb0WLJKbZKcJ5JXTrBfhoxVjSvpDe06SwUlrq8FeLKJc3eZo1J6SV7pCuYkuUANl5aOfkV UHTFTGqqgQ8wXIaI71HIiwnTzAotEk6FsyHQ/cc8dXVszKrJBQU+XBSI6fd8NxoIJedv1O3I8 TbYPRQztXAD7wi5PErl6Wbb7zzjLhWS1wHvn5+/WlxMX3xiwFDaZXj0IPZ7wRlvttvWwfs/ws LFPu635WULOcL9zslORG4fFkXUTeqFIeu7ROWpReyLXxDu/jVdywVx9p+SM3dKEg2ZwxQG8I1 s3XSGB1WryGT/aAIaVRDR17zBq1SGtAJj7ndrlbJ3Rqvc/VRTUi2SB/nNCTfWJToxmjkMfRvt aueHU2gw+Tewuef68P1MgBqiI8IatN5meQFqdyEJUOADDGLiriDkKZiGQVzrOHIgUttpblvST lb8qiCo8b+1/vExnITihnl+K2owayPieaay4EUkJEPsFlBWBVMmplKHEHOjBDpv4iAbNBIABF 9+ZL+Kn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 4 Nov 2015 21:23:43 +0100 The iput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/gfs2/ops_fstype.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index baab99b..1f9de17 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c @@ -910,8 +910,7 @@ fail_qc_i: fail_ut_i: iput(sdp->sd_sc_inode); fail: - if (pn) - iput(pn); + iput(pn); return error; } -- 2.6.2