From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756143AbbKEFPD (ORCPT ); Thu, 5 Nov 2015 00:15:03 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:43990 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752045AbbKEFPB (ORCPT ); Thu, 5 Nov 2015 00:15:01 -0500 Subject: Re: [PATCH] PCI: pciehp: Always protect pciehp_disable_slot() with hotplug mutex To: rajatxjain@gmail.com References: <1446415120-14867-1-git-send-email-linux@roeck-us.net> Cc: Bjorn Helgaas , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Guenter Roeck Message-ID: <563AE5D3.3060001@roeck-us.net> Date: Wed, 4 Nov 2015 21:14:59 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/04/2015 06:59 PM, Rajat Jain wrote: > Geez... I wonder how did I miss it. Thanks for fixing this. > Looks good to me. > Hi Rajat, easy to miss. I only found it accidentally. Thanks a lot for the review! Guenter > Reviewed-by: Rajat Jain > > > On Sun, Nov 1, 2015 at 1:58 PM, Guenter Roeck > wrote: > > When called from pciehp_sysfs_disable_slot(), the call to > pciehp_disable_slot() was not protected by the hotplug mutex. > > Cc: Rajat Jain > > Signed-off-by: Guenter Roeck > > --- > drivers/pci/hotplug/pciehp_ctrl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c > index 4c8f4cde6854..880978b6d534 100644 > --- a/drivers/pci/hotplug/pciehp_ctrl.c > +++ b/drivers/pci/hotplug/pciehp_ctrl.c > @@ -511,7 +511,9 @@ int pciehp_sysfs_disable_slot(struct slot *p_slot) > case STATIC_STATE: > p_slot->state = POWEROFF_STATE; > mutex_unlock(&p_slot->lock); > + mutex_lock(&p_slot->hotplug_lock); > retval = pciehp_disable_slot(p_slot); > + mutex_unlock(&p_slot->hotplug_lock); > mutex_lock(&p_slot->lock); > p_slot->state = STATIC_STATE; > break; > -- > 2.1.4 > >