From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756020AbbKEF11 (ORCPT ); Thu, 5 Nov 2015 00:27:27 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:57054 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751222AbbKEF1Y (ORCPT ); Thu, 5 Nov 2015 00:27:24 -0500 X-AuditID: cbfee68d-f79ae6d00000149a-84-563ae8b4be48 Message-id: <563AE8C3.9000001@samsung.com> Date: Thu, 05 Nov 2015 10:57:31 +0530 From: Pankaj Dubey User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: kgene.kim@samsung.com, thomas.ab@samsung.com, amitdanielk@gmail.com, Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v3 0/7] samsung: pmu: split up SoC specific PMU data References: <1445864143-25695-1-git-send-email-pankaj.dubey@samsung.com> <5638168A.8060500@samsung.com> In-reply-to: <5638168A.8060500@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprPIsWRmVeSWpSXmKPExsWyRsSkSnfrC6swg0tn2Sw+rn7JZrFxxnpW i9cvDC16F1xls9j0+BqrxeVdc9gsZpzfx2TRsYzRgcNj56y77B6bl9R79G1ZxejxeZNcAEsU l01Kak5mWWqRvl0CV8a2KTtYCrp1KhpPRDYw7lHsYuTkkBAwkdh55zkThC0mceHeerYuRi4O IYEVjBLnHuxjgSn6fHoyE0RiKaPE77knoaq+M0qcXXoXrJ1XQEvi887p7F2MHBwsAqoSc566 gITZBHQlnryfywxiiwpESLy9fBKqXFDix+R7LCBzRATmMEp0TV/ABNLLLFAvcfxYIkiNsICH xIt1W9lAbCGBTInVH76AHcQpoC3R+n0KI4jNLGArseD9OhYIW15i85q3zCAzJQTOsUvMnvYS bDGLgIDEt8mHWEDmSwjISmw6wAzxmKTEwRU3WCYwis1CctIsJGNnIRm7gJF5FaNoakFyQXFS epGhXnFibnFpXrpecn7uJkZgvJ3+96x3B+PtA9aHGAU4GJV4eA2qrcKEWBPLiitzDzGaAl0x kVlKNDkfGNV5JfGGxmZGFqYmpsZG5pZmSuK8ilI/g4UE0hNLUrNTUwtSi+KLSnNSiw8xMnFw SjUwdrcvPHCmuiin+cP0vpmvmM15jl4/K6Rfxfr7jySXfV7MlrueO9fZP27hvaHatbDkt+jX pQsu9J5hNpY07Tbiku7Nv3Zw5if+lCWXbpm8/7nd4fPhB+Eaq8XtNU5Fc5iaTM2ckKu5g/3a 5PcFjyf/uMbzTLF8zp27wQpT2BrsvRUk0v4eiKjyVmIpzkg01GIuKk4EALLA/ZCyAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDIsWRmVeSWpSXmKPExsVy+t9jAd0tL6zCDPbstLD4uPolm8XGGetZ LV6/MLToXXCVzWLT42usFpd3zWGzmHF+H5NFxzJGBw6PnbPusntsXlLv0bdlFaPH501yASxR DYw2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUBHKCmU JeaUAoUCEouLlfTtME0IDXHTtYBpjND1DQmC6zEyQAMJaxgztk3ZwVLQrVPReCKygXGPYhcj J4eEgInE59OTmSBsMYkL99azdTFycQgJLGWU+D33JJTznVHi7NK7YFW8AloSn3dOZ+9i5OBg EVCVmPPUBSTMJqAr8eT9XGYQW1QgQuLt5ZNQ5YISPybfYwGZIyIwh1Gia/oCJpBeZoF6iePH EkFqhAU8JF6s28oGYgsJZEqs/vCFBcTmFNCWaP0+hRHEZhawlVjwfh0LhC0vsXnNW+YJjAKz kKyYhaRsFpKyBYzMqxglUguSC4qT0nMN81LL9YoTc4tL89L1kvNzNzGCY/qZ1A7Gg7vcDzEK cDAq8fAaVFuFCbEmlhVX5h5ilOBgVhLhLZgJFOJNSaysSi3Kjy8qzUktPsRoCgyDicxSosn5 wHSTVxJvaGxibmpsamliYWJmqSTOq+9pFCYkkJ5YkpqdmlqQWgTTx8TBKdXAeC4sjuf7011v pp55q/Xuybxf96WiCrrcJ3w5s2jqcm/xrmdz/I/YuE929JwYEJc/WyhoKffJC1HHmh7Wqnzy rlK4vHajXavBRCntNSUVDGuvt6/nWsC93NCQV7n4tOjJ2HkLylwm7nvDWGyYxp9XJrFS8EFP R3fsuqqiB5zpBsv8j9R8mOn+XImlOCPRUIu5qDgRAJY4G27/AgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Tuesday 03 November 2015 07:36 AM, Krzysztof Kozlowski wrote: > On 26.10.2015 21:55, Pankaj Dubey wrote: >> This patch series is a part of continuation work from following series >> [1] and [2]. >> >> 1: exynos: Move pmu driver to driver/soc folder and add exynos7 support >> http://www.spinics.net/lists/linux-samsung-soc/msg39797.html from Amit Daniel Kacchap >> 2: soc: samsung: pmu: split up SoC specific PMU data >> https://lkml.org/lkml/2015/1/7/12 from me >> > > +Cc Bartlomiej, > > There were some concerns for previous versions of this patchset. I > cannot find all of them (e.g. Bartlomiej's are not present on lkml.org > anymore) so I am not sure if they were addressed properly. > Yes. If I recall correctly he has following main concerns: 1: To convert exynos-pmu to a proper platform driver before moving out of arch/arm/mach-exynos. This is already addressed. 2: Do we really need common driver for both ARM and ARM64? I feel yes, as at least I can see that driver's basic structure will be reused. As in case of PMU driver most of lines of code is data part (register offset and its values in different mode), that part will be kept in separate file e.g. exynos7-pmu.c or exynosXXXX-pmu.c. There has been already one attempt of submission for exynos7 PMU driver at: http://lists.infradead.org/pipermail/linux-arm-kernel/2014-November/305418.html 3: He had a concern that in case of ARM64 build most of ARM related code will be present in binary which will be dead code, that can be addressed by excluding ARM based SoC exynosXXXX-pmu.c file in Makefile. It has been taken care in v3 7/7 patch in drivers/soc/samsung/Makefile. > I like the approach, it helps in reviewing the patch. Thanks. This was a review comment from Kukjin, to separate data part of all SoC and move them to respective files, same as we do for clock files of each SoC. > > I wonder - after adding this for ARM64 how much of duplicated code this > approach reduce? > It will reduce in duplication driver structure, which will be same. > Best regards, > Krzysztof > >> Here is another attempt for the same, in this series I am splitting up SoC >> specific PMU configuration data into mach-exynos folder itself, before moving >> all of them under drivers/soc/samsung/. Also instead of making all changes in >> single patch it has been broken into SoC specific patches to avoid large size >> of patch. With this approach there will not be unwanted big churns just after >> adding exynos-pmu under drivers/soc/samsung. >> >> All these patches are just refactoring to keep minimal changes while moving >> exynos-pmu driver under drivers/soc/samsung/. Support for exynos7 PMU can be added >> on top of it, in such a manner that for ARM64 build, ARM related SoC's PMU will not >> get compiled and thus unnecessary increasing kernel image size. >> >> I have tested on Peach-Pi (Exynos5880) based chromebook for boot >> and S2R functionality. >> >> These patches have been prepared on top of Kukjin Kim's for-next >> >> Changes since v2: >> - Removed Amit's Samsung id as it's no more valid. >> - Rebased on latest kgene tree. >> - Removed redundant code from regs-pmu.h >> >> >> Pankaj Dubey (7): >> ARM: EXYNOS: removing redundant code from regs-pmu.h >> ARM: EXYNOS: Move pmu specific headers under "linux/soc/samsung" >> ARCH: EXYNOS: split up exynos3250 SoC specific PMU data >> ARCH: EXYNOS: split up exynos4 SoC specific PMU data >> ARCH: EXYNOS: split up exynos5250 SoC specific PMU data >> ARCH: EXYNOS: split up exynos5420 SoC specific PMU data >> drivers: soc: Add support for Exynos PMU driver >> >> arch/arm/mach-exynos/Kconfig | 1 + >> arch/arm/mach-exynos/Makefile | 2 +- >> arch/arm/mach-exynos/exynos.c | 2 +- >> arch/arm/mach-exynos/mcpm-exynos.c | 2 +- >> arch/arm/mach-exynos/platsmp.c | 2 +- >> arch/arm/mach-exynos/pm.c | 4 +- >> arch/arm/mach-exynos/pmu.c | 1004 -------------------- >> arch/arm/mach-exynos/suspend.c | 4 +- >> drivers/soc/samsung/Kconfig | 4 + >> drivers/soc/samsung/Makefile | 4 + >> drivers/soc/samsung/exynos-pmu.c | 168 ++++ >> drivers/soc/samsung/exynos-pmu.h | 52 + >> drivers/soc/samsung/exynos3250-pmu.c | 175 ++++ >> drivers/soc/samsung/exynos4-pmu.c | 223 +++++ >> drivers/soc/samsung/exynos5250-pmu.c | 196 ++++ >> drivers/soc/samsung/exynos5420-pmu.c | 280 ++++++ >> .../linux/soc/samsung}/exynos-pmu.h | 2 +- >> .../linux/soc/samsung/exynos-regs-pmu.h | 17 +- >> 18 files changed, 1116 insertions(+), 1026 deletions(-) >> delete mode 100644 arch/arm/mach-exynos/pmu.c >> create mode 100644 drivers/soc/samsung/exynos-pmu.c >> create mode 100644 drivers/soc/samsung/exynos-pmu.h >> create mode 100644 drivers/soc/samsung/exynos3250-pmu.c >> create mode 100644 drivers/soc/samsung/exynos4-pmu.c >> create mode 100644 drivers/soc/samsung/exynos5250-pmu.c >> create mode 100644 drivers/soc/samsung/exynos5420-pmu.c >> rename {arch/arm/mach-exynos => include/linux/soc/samsung}/exynos-pmu.h (90%) >> rename arch/arm/mach-exynos/regs-pmu.h => include/linux/soc/samsung/exynos-regs-pmu.h (98%) >> > >