From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756506AbbKEFbQ (ORCPT ); Thu, 5 Nov 2015 00:31:16 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:60560 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752173AbbKEFbO (ORCPT ); Thu, 5 Nov 2015 00:31:14 -0500 X-AuditID: cbfee691-f79d66d000001509-df-563ae9a02e38 Message-id: <563AE9B5.2020808@samsung.com> Date: Thu, 05 Nov 2015 11:01:33 +0530 From: Pankaj Dubey User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: kgene.kim@samsung.com, thomas.ab@samsung.com, amitdanielk@gmail.com Subject: Re: [PATCH v3 3/7] ARCH: EXYNOS: split up exynos3250 SoC specific PMU data References: <1445864143-25695-1-git-send-email-pankaj.dubey@samsung.com> <1445864143-25695-4-git-send-email-pankaj.dubey@samsung.com> <563813F8.6000201@samsung.com> In-reply-to: <563813F8.6000201@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDIsWRmVeSWpSXmKPExsWyRsSkRnfBS6swg2mn9Cw+rn7JZvH6haFF 74KrbBabHl9jtbi8aw6bxYzz+5gsOpYxOrB77Jx1l91j85J6j74tqxg9Pm+SC2CJ4rJJSc3J LEst0rdL4Mq4Ou0Lc8F1iYpp/z8xNTAuEuli5OSQEDCRWNl7iBHCFpO4cG89WxcjF4eQwApG ifuHX7N2MXKAFbV1hEHEZzFK7Oq5xgzhfGeUaN0ziRGkiFdAS+LA10iQQSwCqhLXbh9iB7HZ BHQlnryfywxiiwpESLy9fJIJxOYVEJT4MfkeC8gcEYE5jBJd0xeAJZgF3CVWdv8Bu0hYIFTi 6PczrHAXHZ/zDWwSp4C2xOMpnYwQDbYSC96vY4Gw5SU2r3kLdp2EwCl2iZu7/7JAnCQg8W3y IRaId2QlNh1ghnhZUuLgihssExjFZiE5ahaSsbOQjF3AyLyKUTS1ILmgOCm9yFSvODG3uDQv XS85P3cTIzDSTv97NnEH4/0D1ocYBTgYlXh4DaqtwoRYE8uKK3MPMZoCXTGRWUo0OR8Yz3kl 8YbGZkYWpiamxkbmlmZK4rw60j+DhQTSE0tSs1NTC1KL4otKc1KLDzEycXBKNTAKnndt0PdZ GO3679GpyzYZdyoff5x8PUD00ZtzQnxZ9fGTpSfrO3Ymzt1t2GSmu0m/U2bittbsm0lF1pMO vnTWLP5yoliis3auN+PpV1du9u7U9Tqpe1+IZeKka4+Of9jiGHT+msHVG3PjJJJjZ/HkrFZ5 bGfUXPfqr+a8BN19lb8NvLwDzokqsRRnJBpqMRcVJwIAB2yJh68CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJIsWRmVeSWpSXmKPExsVy+t9jQd0FL63CDDZdULb4uPolm8XrF4YW vQuusllsenyN1eLyrjlsFjPO72Oy6FjG6MDusXPWXXaPzUvqPfq2rGL0+LxJLoAlqoHRJiM1 MSW1SCE1Lzk/JTMv3VbJOzjeOd7UzMBQ19DSwlxJIS8xN9VWycUnQNctMwdov5JCWWJOKVAo ILG4WEnfDtOE0BA3XQuYxghd35AguB4jAzSQsIYx4+q0L8wF1yUqpv3/xNTAuEiki5GDQ0LA RKKtI6yLkRPIFJO4cG89WxcjF4eQwCxGiV0915ghnO+MEq17JjGCNPAKaEkc+BoJ0sAioCpx 7fYhdhCbTUBX4sn7ucwgtqhAhMTbyyeZQGxeAUGJH5PvsYDMERGYwyjRNX0BWIJZwF1iZfcf RhBbWCBU4uj3M6wQy1YwShyf8w1sEqeAtsTjKZ2MEA22Egver2OBsOUlNq95yzyBEehOhCWz kJTNQlK2gJF5FaNEakFyQXFSeq5hXmq5XnFibnFpXrpecn7uJkZwND+T2sF4cJf7IUYBDkYl Hl6DaqswIdbEsuLK3EOMEhzMSiK8BTOBQrwpiZVVqUX58UWlOanFhxhNgcEwkVlKNDkfmGjy SuINjU3MTY1NLU0sTMwslcR59T2NwoQE0hNLUrNTUwtSi2D6mDg4pRoYnYTmN9m8fZW0qj20 Z9LCzEu7fitIdhT3Hfzp0qJyfl/k7cR5rye/5dZrOL+TXb3/4ZSexWsauBzfbIq4evXr80Pf js8vnPifSSGkuPaXpei87ivRP2O9ZhV973xabOMm0XOk5tYhlfSpN63iz3Q/fR+6MexhEvcl d7W7e14dmKoq8faZP3vtcSWW4oxEQy3mouJEAG1o0dT8AgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Tuesday 03 November 2015 07:25 AM, Krzysztof Kozlowski wrote: > On 26.10.2015 21:55, Pankaj Dubey wrote: >> This patch splits up mach-exynos/pmu.c file, and moves exynos3250 PMU >> configuration data and functions handing those data into exynos3250 >> SoC specific PMU file mach-exynos/exynos3250-pmu.c. >> >> Signed-off-by: Pankaj Dubey >> --- >> arch/arm/mach-exynos/Makefile | 2 +- >> arch/arm/mach-exynos/exynos-pmu.h | 47 +++++++++ >> arch/arm/mach-exynos/exynos3250-pmu.c | 175 +++++++++++++++++++++++++++++++ >> arch/arm/mach-exynos/pmu.c | 189 +--------------------------------- >> 4 files changed, 224 insertions(+), 189 deletions(-) >> create mode 100644 arch/arm/mach-exynos/exynos-pmu.h >> create mode 100644 arch/arm/mach-exynos/exynos3250-pmu.c >> >> diff --git a/arch/arm/mach-exynos/Makefile b/arch/arm/mach-exynos/Makefile >> index 2f30676..e869f86 100644 >> --- a/arch/arm/mach-exynos/Makefile >> +++ b/arch/arm/mach-exynos/Makefile >> @@ -9,7 +9,7 @@ ccflags-$(CONFIG_ARCH_MULTIPLATFORM) += -I$(srctree)/$(src)/include -I$(srctree) >> >> # Core >> >> -obj-$(CONFIG_ARCH_EXYNOS) += exynos.o pmu.o exynos-smc.o firmware.o >> +obj-$(CONFIG_ARCH_EXYNOS) += exynos.o pmu.o exynos-smc.o firmware.o exynos3250-pmu.o >> >> obj-$(CONFIG_EXYNOS_CPU_SUSPEND) += pm.o sleep.o >> obj-$(CONFIG_PM_SLEEP) += suspend.o >> diff --git a/arch/arm/mach-exynos/exynos-pmu.h b/arch/arm/mach-exynos/exynos-pmu.h >> new file mode 100644 >> index 0000000..2da4964 >> --- /dev/null >> +++ b/arch/arm/mach-exynos/exynos-pmu.h >> @@ -0,0 +1,47 @@ >> +/* >> + * Copyright (c) 2015 Samsung Electronics Co., Ltd. >> + * http://www.samsung.com >> + * >> + * Header for EXYNOS PMU Driver support >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> +#ifndef __EXYNOSPMU_H >> +#define __EXYNOSPMU_H > > __EXYNOS_PMU_H > (and rename it in last patch) > OK. >> + >> +#include >> + >> +#define PMU_TABLE_END (-1U) >> + >> +extern void __iomem *pmu_base_addr; >> + >> +struct exynos_pmu_conf { >> + unsigned int offset; >> + u8 val[NUM_SYS_POWERDOWN]; >> +}; >> + >> +struct exynos_pmu_data { >> + const struct exynos_pmu_conf *pmu_config; >> + const struct exynos_pmu_conf *pmu_config_extra; >> + >> + void (*pmu_init)(void); >> + void (*powerdown_conf)(enum sys_powerdown); >> + void (*powerdown_conf_extra)(enum sys_powerdown); >> +}; >> + >> +static inline void pmu_raw_writel(u32 val, u32 offset) >> +{ >> + writel_relaxed(val, pmu_base_addr + offset); >> +} >> + >> +static inline u32 pmu_raw_readl(u32 offset) >> +{ >> + return readl_relaxed(pmu_base_addr + offset); >> +} > > These shouldn't be static inlines in header because you will duplicate > it in each compiled object. Leave optimizations to compiler. > OK. Thanks for review. Thanks, Pankaj Dubey > Rest looks good, > Krzysztof > >