From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756577AbbKEFbe (ORCPT ); Thu, 5 Nov 2015 00:31:34 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:51083 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756511AbbKEFb3 (ORCPT ); Thu, 5 Nov 2015 00:31:29 -0500 X-AuditID: cbfee691-f79d66d000001509-da-563ae9b0c978 Message-id: <563AE9C7.4030701@samsung.com> Date: Thu, 05 Nov 2015 11:01:51 +0530 From: Pankaj Dubey User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: kgene.kim@samsung.com, thomas.ab@samsung.com, amitdanielk@gmail.com Subject: Re: [PATCH v3 7/7] drivers: soc: Add support for Exynos PMU driver References: <1445864143-25695-1-git-send-email-pankaj.dubey@samsung.com> <1445864143-25695-8-git-send-email-pankaj.dubey@samsung.com> <56381A66.1010406@samsung.com> In-reply-to: <56381A66.1010406@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHIsWRmVeSWpSXmKPExsWyRsSkRnfDS6swg0lzBCw+rn7JZvH6haFF 74KrbBabHl9jtbi8aw6bxYzz+5gsOpYxOrB77Jx1l91j85J6j74tqxg9Pm+SC2CJ4rJJSc3J LEst0rdL4MpoP/eXpaBPuqLp0TrmBsbbol2MnBwSAiYSHxfcY4ewxSQu3FvP1sXIxSEksIJR 4mf/bWaYopV7drFCJGYxSkxq+McC4XxnlGifc4oFpIpXQEui59NXNhCbRUBV4uO53awgNpuA rsST93PBJokKREi8vXySCaJeUOLH5Htgg0QE5jBKdE1fAJZgFnCXWNn9hxHEFhbwlvg5bRbC Tf8avoFt4xTQluj8t4cFosFWYsH7dVC2vMTmNW+ZQRokBA6xS3xasJEd4iQBiW+TDwEVcQAl ZCU2HYD6TVLi4IobLBMYxWYhOWoWkrGzkIxdwMi8ilE0tSC5oDgpvchUrzgxt7g0L10vOT93 EyMw2k7/ezZxB+P9A9aHGAU4GJV4eA2qrcKEWBPLiitzDzGaAl0xkVlKNDkfGNN5JfGGxmZG FqYmpsZG5pZmSuK8OtI/g4UE0hNLUrNTUwtSi+KLSnNSiw8xMnFwSjUwMt80M4/eteu5w22m mL9yGhqXHQSrOmY/2Gfqec97N3fVnlj+N0u+r96Yr+Iydd7RO0lyh32Dd+R4CfCWb2tdZLf1 0Y9T1QevejPWWjq+z9loJf+S03//3GeXQgwuXXac0bd3tvKhbI8vC9osfdQ40nwvPpo1n73r 91nLWgmh65WXS1beOjf/qRJLcUaioRZzUXEiAK7LFN+xAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsVy+t9jQd0NL63CDN6vZ7P4uPolm8XrF4YW vQuusllsenyN1eLyrjlsFjPO72Oy6FjG6MDusXPWXXaPzUvqPfq2rGL0+LxJLoAlqoHRJiM1 MSW1SCE1Lzk/JTMv3VbJOzjeOd7UzMBQ19DSwlxJIS8xN9VWycUnQNctMwdov5JCWWJOKVAo ILG4WEnfDtOE0BA3XQuYxghd35AguB4jAzSQsIYxo/3cX5aCPumKpkfrmBsYb4t2MXJySAiY SKzcs4sVwhaTuHBvPVsXIxeHkMAsRolJDf9YIJzvjBLtc06xgFTxCmhJ9Hz6ygZiswioSnw8 txusm01AV+LJ+7nMILaoQITE28snmSDqBSV+TL4HNkhEYA6jRNf0BWAJZgF3iZXdfxhBbGEB b4mf02ZBrV7BKPGv4RvYNk4BbYnOf3tYIBpsJRa8Xwdly0tsXvOWeQIj0KEIS2YhKZuFpGwB I/MqRonUguSC4qT0XMO81HK94sTc4tK8dL3k/NxNjOCIfia1g/HgLvdDjAIcjEo8vAbVVmFC rIllxZW5hxglOJiVRHgLZgKFeFMSK6tSi/Lji0pzUosPMZoCg2Eis5Rocj4w2eSVxBsam5ib GptamliYmFkqifPqexqFCQmkJ5akZqemFqQWwfQxcXBKARNGhMuykiIjjvJrXL8+Xam+28Fv Ncn1dXz0Tia9ooVGwgHRD99zlq3bO7dRdVa08lqDb5bi76ZP13e4G735mGWF6kyfxaWFV6Ku zSyfemPx88eH6pOyQ26wHlh6/W98sqYGc+C32awL5VbxnbXPkNilKvuOX+9/S5HogRVTLQxV W7hV5uz2NFRiKc5INNRiLipOBADrQ4n7/gIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Tuesday 03 November 2015 07:52 AM, Krzysztof Kozlowski wrote: > On 26.10.2015 21:55, Pankaj Dubey wrote: >> This patch moves Exynos PMU driver implementation from "arm/mach-exynos" >> to "drivers/soc/samsung". This driver is mainly used for setting misc >> bits of register from PMU IP of Exynos SoC which will be required to >> configure before Suspend/Resume. Currently all these settings are done >> in "arch/arm/mach-exynos/pmu.c" but moving ahead for ARM64 based SoC >> support, there is a need of this PMU driver in driver/* folder. >> >> This driver uses existing DT binding information and there should >> be no functionality change in the supported platforms. >> >> Signed-off-by: Amit Daniel Kachhap >> Signed-off-by: Pankaj Dubey >> --- >> arch/arm/mach-exynos/Kconfig | 1 + >> arch/arm/mach-exynos/Makefile | 4 +--- >> drivers/soc/samsung/Kconfig | 4 ++++ >> drivers/soc/samsung/Makefile | 4 ++++ >> arch/arm/mach-exynos/pmu.c => drivers/soc/samsung/exynos-pmu.c | 0 >> {arch/arm/mach-exynos => drivers/soc/samsung}/exynos-pmu.h | 0 >> {arch/arm/mach-exynos => drivers/soc/samsung}/exynos3250-pmu.c | 0 >> {arch/arm/mach-exynos => drivers/soc/samsung}/exynos4-pmu.c | 0 >> {arch/arm/mach-exynos => drivers/soc/samsung}/exynos5250-pmu.c | 0 >> {arch/arm/mach-exynos => drivers/soc/samsung}/exynos5420-pmu.c | 0 >> 10 files changed, 10 insertions(+), 3 deletions(-) >> rename arch/arm/mach-exynos/pmu.c => drivers/soc/samsung/exynos-pmu.c (100%) >> rename {arch/arm/mach-exynos => drivers/soc/samsung}/exynos-pmu.h (100%) >> rename {arch/arm/mach-exynos => drivers/soc/samsung}/exynos3250-pmu.c (100%) >> rename {arch/arm/mach-exynos => drivers/soc/samsung}/exynos4-pmu.c (100%) >> rename {arch/arm/mach-exynos => drivers/soc/samsung}/exynos5250-pmu.c (100%) >> rename {arch/arm/mach-exynos => drivers/soc/samsung}/exynos5420-pmu.c (100%) >> > > 1. Please reorder the exynos_sys_powerdown_conf() to be after the > statics. I am thinking also about adding EXPORT_SYMBOL... but maybe this > would be over-thinking. > I could not understand your point of reordering, will you please explain this. > 2. I think the proper location of everything is drivers/power/reset/. > Although I don't have strong opinion. > There has been discussion about the proper location for this driver, initial attempt was done in "drivers/mfd" folder but then we realized that this driver is not exactly fitting in MFD category. There was suggestion from Catalin Marinas [1], [2] to move it to "drivers/power" or a more suitable place other than mfd. As I received comments from Bartlomiej [3] and other members also (sorry I could not produce all links as it was quite more than a year back), I feel driver is very much SoC specific and hence decided to move it here. 1: https://lkml.org/lkml/2014/4/28/879 2: http://lists.infradead.org/pipermail/linux-arm-kernel/2014-April/252018.html 3: http://lists.infradead.org/pipermail/linux-arm-kernel/2014-April/244690.html > 3. Please cc linux-pm and arm-soc guys (Arnd, Olof, Kevin) on next > iteration. > Ok will keep them in CC in next revision. Thanks, Pankaj Dubey > Best regards, > Krzysztof >