From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755639AbbKEUPj (ORCPT ); Thu, 5 Nov 2015 15:15:39 -0500 Received: from mout.web.de ([212.227.17.12]:55092 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750749AbbKEUPh (ORCPT ); Thu, 5 Nov 2015 15:15:37 -0500 Subject: [PATCH] CPPC-CPUFreq: Delete an unnecessary check before the function call "kfree" To: Viresh Kumar , linux-pm@vger.kernel.org References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <563BB8DF.7020908@users.sourceforge.net> Date: Thu, 5 Nov 2015 21:15:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:xD8okbkNQ2JQ5tqfH/i4EtaE/jlrKN+yFL+jf4UlkoOSlZURsDy Le+fzB9hLwRDOinC2/s4VruzrT916kdXI9H/IRcAN+DrbbIvAsPG/vhFBxBPmiiJyu6Z2Tn RPf1Y/y5LCvq3PD54aov7pRDlMDg7epghbq3JZScxw8e09YGj6txuEks9mhRQavEwVhiKjb bUK7vMM4aba2KKuPH4PUQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:CFUEaqbo900=:uPusl8KllawMfkCsAOJiAa a+431/qR1VIUKJ0GZUc5wLtGFJizsWytMCfFl73woqG33OMufbIlCccoczPI0qqPN31e7rd9k sHdu/kRyqkvhvOWysQZqONYeMVd3j5f3taWapb1tiQGqSxwYnjvahKu4jXveqNWHKAx6t7X8j MVzO/YZvb6pyH9oZ6+WFnTiM2zcz4tNCRnuMwNd3ur8eOAxdsaWkBiV9inZfcz18EKs+4TMxS 1TDVMdcU+ncJwRKZ2ygN+z3rhzySPl6a6ruZ6trzuax8S41OniGDHPAXV1nL3R8sZ9ZyHMPnu vXOWauapus9yMRVhENL79QPWfyf5qqVN+opHyqc3bbjGAmhwcmIsiBUfylC4LSPsflWm38mzv iUANdoanWSlA50aiPW2LY068xn4rmM2LRDNvP1biOM6aNu4NKBTL1dPrVY77XoVxKdrlMhFqi cDKZPKMMGI10P6I4BbxbP0Qs/JHAq2N1mNzz665XHCnQHjc6/+kgfF4ztx5a9+/WgVQDSrDXN /EKD7KC9i9iQhUzDwaizXbyaxqRYYsyGHXywG9Q5Q9/HA+ESe0yp+tMQNmWg/vlr08TKqYH2V Fwz/vHPYfKqoH5Eac7oSDE1ThaosvTcwplBSiwDTO7iT5Et2mF9UjXUJDQkUcxW2aMxUbLHKQ WRnffTG7dht7iVHyEVXKfY1dKueVLSK8t9onYXFD8L6+GgVqm5svyX6XQxE77dJNbTUWQ39Lo EEEuG3xr+TQXaY0Ft8N4opB7oMZtnRxqc0nkfja2pcosaGNRsnTy8FQrazl/DZ1JNUiujDUzB 5IjOW2V Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 5 Nov 2015 21:10:29 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/cpufreq/cppc_cpufreq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c index 93c219f..e8cb334 100644 --- a/drivers/cpufreq/cppc_cpufreq.c +++ b/drivers/cpufreq/cppc_cpufreq.c @@ -166,8 +166,7 @@ static int __init cppc_cpufreq_init(void) out: for_each_possible_cpu(i) - if (all_cpu_data[i]) - kfree(all_cpu_data[i]); + kfree(all_cpu_data[i]); kfree(all_cpu_data); return -ENODEV; -- 2.6.2