From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755905AbbKEUQb (ORCPT ); Thu, 5 Nov 2015 15:16:31 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:40049 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755619AbbKEUQa (ORCPT ); Thu, 5 Nov 2015 15:16:30 -0500 Subject: Re: [PATCH 3/4] scsi: fix compiler warning for sg To: Andy Shevchenko References: <1446698789-19308-1-git-send-email-okaya@codeaurora.org> <1446698789-19308-3-git-send-email-okaya@codeaurora.org> <563B7180.2000405@codeaurora.org> <563BA0B3.6080506@codeaurora.org> Cc: linux-scsi , timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, Doug Gilbert , "James E.J. Bottomley" , "linux-kernel@vger.kernel.org" From: Sinan Kaya Message-ID: <563BB91A.6060502@codeaurora.org> Date: Thu, 5 Nov 2015 15:16:26 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/5/2015 2:56 PM, Andy Shevchenko wrote: > One more look to the users of MULDIV. > > They all seems 32 bit for x. > It means you don't need two do_div()s at all. > > Just do something like: > > u64 d = x * numer; > do_div(d, denom); > return d; OK. I assume you want a change only in this file. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project