From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756189AbbKEUym (ORCPT ); Thu, 5 Nov 2015 15:54:42 -0500 Received: from mout.web.de ([212.227.17.12]:60643 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755981AbbKEUyk (ORCPT ); Thu, 5 Nov 2015 15:54:40 -0500 Subject: [PATCH] hpet: Delete an unnecessary check before unregister_sysctl_table() References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> To: Arnd Bergmann , Clemens Ladisch , Greg Kroah-Hartman , LKML From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Cc: kernel-janitors@vger.kernel.org, Julia Lawall Message-ID: <563BC20A.5000803@users.sourceforge.net> Date: Thu, 5 Nov 2015 21:54:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:I13goGtHPpNSeId1bFpVVadBsAqr4iCEW2l//Wri+ZvJQmGg7C8 9aN2ZLFfagwqPexKqkuTXc19FhKjwXmzG0X2hjt6gITfFAnlqIfpDwuRKTbQvoFOyId11xi Lk42f+ImsQygjCJqDadRcpbuDf8h3IaMPGzTRr1B9EAA/Ts3LppeK49x2B2il6rcTggASJ3 v36PDhegSnxUa5t6eKaSQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:p01xII7koD0=:r4MBbN9esniCtnaVUjo0IU BK7qOlCXT9BexY0JbdtHY8/CFoiEiQqXiM9SMJxez9tLX9axHZbYwV1VmyasMcazfhbX0moQD 5Fha4FuZSX9zjYn9ytupWek2j8kWzyXobXAqpHaiFJR82WoeX2gnoIYSRoSTYwwsA/bUj8ld+ UykTO1yGZYWfDQqlBpVaOlH0l3R/NY3NLKYbiLVW4gSwYHkIwul0mqsMGKXS9rNZDWw57FdWZ 3suZIB71Wk+1T40zEmDKnhSVeTl6wLR4RfHRHGN0ZEvaXaxC9AnGp+GqIDG/vKsW+WV5xyYem lIFicVfNSVKhWy3JqzQpecrCXslx8ag2mk7yzwGqvcM3VcNtm/Scv3hWUXbqTBZvDoM08SGBu bnVVi4evZMpM2BWfRM9Ns2SPtsJgrKtphJ7xSBJ0zdsmEkWx7E5yRO4nU91Waq8kwZUQc1M1B LA48xqoAAgXL5pnSjvyZkscZrTL0uFE+wTN9xfHrckax2wM6VbQcdQE5H/DFbJ2UQREq30i1q LbpjtG+hIph2Mo5ftQcADiJBD5inK/oEryCB7B+JhcVJoSyzFgfh73XaSLpHscSwh0lwbAjLY aS9kTxAa7A3tDYnQGxw73GvHVV5VB4Tz6AQcsEB428HiPb0E9w+V8lqqAy4166oGR2EwqlD4Y 1xBwaV2Odid7tNT/elveTdhL9EFhdV1AHxT3X9fsF5rV4BA/qQIT3ldQEhlH60C5As4EUlHXj A18XcO7ekO08O6k9MmFmrk2EiepFOoxpUGqm766jwZvXEPMgAPIXta4svE2F+RqJ32XJO/TI2 BYtJP6X Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 5 Nov 2015 21:32:42 +0100 The unregister_sysctl_table() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/char/hpet.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c index 240b6cf..fe511e9 100644 --- a/drivers/char/hpet.c +++ b/drivers/char/hpet.c @@ -1069,8 +1069,7 @@ static int __init hpet_init(void) result = acpi_bus_register_driver(&hpet_acpi_driver); if (result < 0) { - if (sysctl_header) - unregister_sysctl_table(sysctl_header); + unregister_sysctl_table(sysctl_header); misc_deregister(&hpet_misc); return result; } -- 2.6.2