From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032332AbbKFHPr (ORCPT ); Fri, 6 Nov 2015 02:15:47 -0500 Received: from mout.web.de ([212.227.17.12]:59344 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032121AbbKFHPp (ORCPT ); Fri, 6 Nov 2015 02:15:45 -0500 Subject: [PATCH] DWC Ethernet QoS: Delete an unnecessary check before the function call "of_node_put" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> To: Lars Persson , netdev@vger.kernel.org Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <563C5392.6030309@users.sourceforge.net> Date: Fri, 6 Nov 2015 08:15:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:6LjCf/XjXF5W1FPcb+oEftTnwPZ0myslaoQJOz9raJfSlsUrlaM ZTtpEcEO0B88QxVzBiPscmSg9nflEe2vOB7s8Hym0gkRfWUaUzml6T757ShapegKCpCZ/37 aAKhQqUsEW129FXE2rbsQMW8hXagTmT1RrJ0f7R6x+ERJaByrV9JIaTnL09IFeIakKpzv7J eYErt9uhMk6WLXKhVoW+w== X-UI-Out-Filterresults: notjunk:1;V01:K0:vugMAxpla7U=:KOHw4NkuGO6uDYg+mcXzHB 4sIfeNUFN9UrS8RqBp3wnPuK8zCM/3VXm028vjudVf0xhWH0JYIRC9rR1s1w4ttcHHIZ8Hl6z EKkQ2hH4f545CWE1i8udWMT+CV5PGl/gW7Yly6yivEFyFWgRbqiHJ0iBSRV0V0tYXFzAwmUC+ AhJR7w+v8Q+lO2q/zLYKcMIDWelujp/k8mCZGsm0Dqz2ZZjQ91HUteZRGrwxQfb/hPhqyTqGr qD/oML38YkScjO4fTOH/1cAK6913Z42zcoITtp93alOFxMeykXds5a1NapsKwfkbWOcBnnjWM 6UAi51VJACDXFIPYOt7refcYDMWscbFCn/7Nj7ac2mdvS5T7DS+wWf9nKb1Un2+7/hvNvuiAT acOsHpztD2sfBxGWVeB6Ua7iXz/X2UXJ6jduyflbCo8918BvDsCrJXCU3FC8nxhzjvkmUPDcN DgnSMqV1yOEpd/Fyualvfbhby49bX60V2PQ5KDjW5fcKbjmMQhIX8M8MtmOmx2+9dwefxHi+q e62DJLtMhkBiz4U/+ZXj/fl4QEDg7ePnmCJuS2K3AqxTbKfExZ7oq8M90uSzbLTRlYTCW53ze YcTYPFoFzxcj9tSfhZkphwv3vnm7aBZnmo7L+g3uvBppl+ZWoxIQOEAu7TXWbpkS1TUbWUR8i kCLxwBZOX2hqStWThzqUvDLUinaBtSqq//U+tQORodCK+ib4cQOoZM3Hs1Bjqzsl4LMUqhqM7 LCqrEOX1DppuVsa7VYqOY7rifHcHxhstLK9B7IRhiz+TxVtdjokgJncc+gi/9VvogycVu2B9T g07FBsU Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 6 Nov 2015 08:00:22 +0100 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/synopsys/dwc_eth_qos.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/synopsys/dwc_eth_qos.c b/drivers/net/ethernet/synopsys/dwc_eth_qos.c index 85b3326..9066d7a 100644 --- a/drivers/net/ethernet/synopsys/dwc_eth_qos.c +++ b/drivers/net/ethernet/synopsys/dwc_eth_qos.c @@ -2970,8 +2970,7 @@ err_out_unregister_netdev: err_out_clk_dis_aper: clk_disable_unprepare(lp->apb_pclk); err_out_free_netdev: - if (lp->phy_node) - of_node_put(lp->phy_node); + of_node_put(lp->phy_node); free_netdev(ndev); platform_set_drvdata(pdev, NULL); return ret; -- 2.6.2