From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033012AbbKFIjm (ORCPT ); Fri, 6 Nov 2015 03:39:42 -0500 Received: from mout.web.de ([212.227.15.3]:52111 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032020AbbKFIje (ORCPT ); Fri, 6 Nov 2015 03:39:34 -0500 Subject: [PATCH] fjes: Delete an unnecessary check before the function call "vfree" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> To: Taku Izumi , netdev@vger.kernel.org Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <563C673B.1020605@users.sourceforge.net> Date: Fri, 6 Nov 2015 09:39:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:ArBQ2lxNK0oTRvDW/Dm8UDxakwpNxEvzLVO04NgHnfkaBxPOzGi nMs85Q5Pe6lGOS9LLZZ/b82xElYOV/UNnPaAFapEbUKroaOC8ZYNcftvz384Z/fP7aE44wy yXoH2YrnjB5YxjGaPNyOjJ7vwV7cd15+uHu4EVb7NtDxAnRtHSRRtGq7/jhmzp6XWIFXYbe AiXlo3WG2KBiy4R0Pnn2w== X-UI-Out-Filterresults: notjunk:1;V01:K0:sf3qWTqvHWc=:vMWnh0t0//4zTacM/OsO4J SjyTY+FleZL6VsbR3q0O8wJSOiphuofUU13LpyVm/FriVZ4yhihGtfwRYcjSILA71PY17MWt/ LlHDS8Ro5aW25QveQ/ohzn72TTI6MZNeE3QPZi65QudStLmGji0vRF84q1iD/87ZVV3EYnml7 TEuSI2Kpp37IQRE0LEBVlAu2qOpGTT6ZA0nXOM6BB9TgsStitHOfN6nMSSN1dC50KMDlPWPEg /0n7vOOp24EsRfZAoUogMz/MZd+WX025VnStarN8aMyMSBIVMRYNgTUz5Y6lqbEMThY1kDecT Tg9UOvWkCWnU7F6EsIp22gv4w1wEu1rziORFpoo0PdSJQVlxPfoy9Z90HiH1TeHWN5FURfPSj 5US3bag+shXaRrFLhLbVIu5VXFPl3yBM9Nlm0WL0tXbdKfhk3EbSB/EyeOErYW1VaiDPmlGE/ +e5ldWZxtptRYTMCqyEKRmv4WoLs1fRrwU/VqQW0tl8BXjAxet5D47YY/K/AGRiKVS+bajlRi Gwk1Y7pvZ7hTkqWnDNjZkj+5QcwXS6wpJUW3pDPZFH+v2Ga9l0Y8K2kjzPcBYMpk1FiCitOxm jLZpAxemRGFgLXus8ERLo1nDD4UPuAsgXWCDqgIlm1Mzs/etcCiWhVJ7OpJjztaEvP/NMZzIw /+1iUt0/Rn8o8MD0LWUlE6rGj0lI8bFupvRsF659VchI1zJ8QIM9fZn9mJ4hIZsSIbZFkH/9N 4c77IZ049lK8K+f9cs15URAtPajIvssvlBA56O6D4J4Kh89Krb7hJ9/7YYmOh4B3cUx4DuJwR EbtUcM4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 6 Nov 2015 09:30:29 +0100 The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/fjes/fjes_hw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/fjes/fjes_hw.c b/drivers/net/fjes/fjes_hw.c index 2d3848c..bb8b530 100644 --- a/drivers/net/fjes/fjes_hw.c +++ b/drivers/net/fjes/fjes_hw.c @@ -143,9 +143,7 @@ static int fjes_hw_alloc_epbuf(struct epbuf_handler *epbh) static void fjes_hw_free_epbuf(struct epbuf_handler *epbh) { - if (epbh->buffer) - vfree(epbh->buffer); - + vfree(epbh->buffer); epbh->buffer = NULL; epbh->size = 0; -- 2.6.2