From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161088AbbKFJny (ORCPT ); Fri, 6 Nov 2015 04:43:54 -0500 Received: from mout.web.de ([212.227.15.3]:55455 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033097AbbKFJnv (ORCPT ); Fri, 6 Nov 2015 04:43:51 -0500 Subject: [PATCH] SRAM: Delete an unnecessary check before the function call "of_node_put" To: linux-kernel@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> Cc: kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <563C7652.6080609@users.sourceforge.net> Date: Fri, 6 Nov 2015 10:43:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:/0pLtL6NLN5VEhkZuj4A54hDFcrr7YLni8tBsIvipj4GWBBc9yY fru3vKt1279QtZ3fVxl1UcIAbwRcF3PUtb0IUB4lW4Zk2qF4yanqIGzibGZYHHreJrCIpGI ZiuqMo4sJhC+C4ZK4x8TMgT7JkURPDW8pZ8I0uv+LAtQjnBnWkZiwVbxX4oaTQUEyeP+ypL xh9qT6AOl7BOmelVptUHg== X-UI-Out-Filterresults: notjunk:1;V01:K0:KjAJK4p2JgY=:SfcDlxhf2AMj5cHBNmmd3w IHyo0nLFOq1J5oPBGH77sgG5KyGyFOFXuseJTTIDxhYAIP/Wnilp+OAt3+9APnZSIPRWE9AGP o84BKt0zmkzLpEB9J0FiT/xIaxlFmLtseL6dawcXd1XXiY1wZlV51ad3Y448A49NM7MJAHry0 HjcHp/5Uju3cFOQGmkTFmKiKAvgnrfRR9ioZ3heLiX8KurUzjnrQn04N5Wimg0BLJRZD26y0i DOzjs7y9tnmzsRpwlCSgTdSEHRNljZRifjPQJsnlaEt0AKQMqKDpFYBEZ0wmkdOWmF0HYUJsY NskQn0FYWrY745U0MyibEEoQO/wceY+V8wdmuX/F9O5TAQj4xyb0HiAo69utQ3xDnV7sQ5asU mV8Yyxy6WZqkQcy3+2wOCpnKc2paz8pNcmVjgX1cpKhMzsiGIDnQ5SY3qHr61qmIeyKZX9kyd a533RvA5RAnKo8MHIKiQa447y2YrSS/dC3km6FQq06v0Kz08bXUQT42Cu4LbHWWmMTDfiobQN 6kPOXRFaJoiZlRHOXWaj/XjVb4bU1/bmVxXOroQa6vgezFe+M1a6GC3S/mLL7u71WeMDoUTp2 RerT/s/x4PWcDOy3GmuMmKahiirhHLPBIHb1x7+Uoo7+UbrVgB+6bVZgUBivUioRvGGZUO2/S fUbEvtXyAC6r6HFIBMX6Xqs+W+qvO3nHVlk1LxEaYfcZ98LpwkHVzOO6W0kHGUdytLqknHdWz /bjH8LsThMCUkkj7tPPzvk55aK5XtM7gD6BpOFPPhr9PQa2sXGbkUmuB0GZQVV/2DnTVkGyZm +TZ3RoC Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 6 Nov 2015 10:36:49 +0100 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/misc/sram.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/misc/sram.c b/drivers/misc/sram.c index 736dae7..34287f7 100644 --- a/drivers/misc/sram.c +++ b/drivers/misc/sram.c @@ -326,9 +326,7 @@ static int sram_reserve_regions(struct sram_dev *sram, struct resource *res) } err_chunks: - if (child) - of_node_put(child); - + of_node_put(child); kfree(rblocks); return ret; -- 2.6.2