From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161306AbbKFKGI (ORCPT ); Fri, 6 Nov 2015 05:06:08 -0500 Received: from mout.web.de ([212.227.17.12]:63185 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161034AbbKFKGC (ORCPT ); Fri, 6 Nov 2015 05:06:02 -0500 Subject: [PATCH] cxl: Delete an unnecessary check before the function call "kfree" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> To: Ian Munsie , Michael Neuling , linuxppc-dev@lists.ozlabs.org Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <563C7B7A.2080403@users.sourceforge.net> Date: Fri, 6 Nov 2015 11:05:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:a0ZNZlN6+o0F2eCiral0tgqGbeW6zB96EW1KluSM4AzrlgoEF6f pUEcmpbbk3R4m2kpeP+jxsjeHDR6F+xLVkq0rV5zPuVU4fUx+hMGksox7f/TRul8RCq60fa 4jAE7v6tlj9x52l2vJQvTXMubDkplwxuFToY+znjErlJZ+neqEUpIEbF4HqsGpjKi5B7pWv wZ1/SjV+t8dZNBws2lmew== X-UI-Out-Filterresults: notjunk:1;V01:K0:PhFsbR2MD+U=:AvcWeSHqiZ8yMK4qyc8e+u Yvz6KsxXqQo2KkT6k2hN48YIc1exD7RAxETADmRHuRnJbP1FwP0MoNWxz4YEYY9Lf5LOHtMie 3W2tPwJz3eclZEsQbC7DdrWkVdO0E/DiYTxLPUjPO8jd23adXkqFPkqlx7FAcZyE4ofLte5I/ yLvL0hzX7z7WFim+/5RvSjTRX0z6i5zsPJFsrll4OoHCkLx0R4OLxRUZBjDspJ8m6M1/PfoK4 88MBpL/kvG2dKAjIOa+yeiJWHmtMpbziD4LSuHw1rmcFUWO7fi79Lrzb7TRYckFjRz5pJTpt0 BMpwQN/o3iV2RLoxam8rfMyj3HBkFfoJhkx7CIX1QqzkuqPWRN/N3W5QQXgtOWC+knNorE2n+ d9LH6pCS/7braHl3CWshLHGgMQBZxnSFSfcWtvR17fCyXa+ZVJ4jdJl0XZky7qRsnDybep304 0VXDdV1kth9PBzHHngQLZ1mM76DaqlLt1TksH9bDDq7gz7SSB503vF0EGPzVdllwcoLrBTJs5 DQqFFghTKwt3Y6jylgPjJCtw6Zc9uileGKe10K8E7qEcOfkpIrzI/KIMBQ8TQGg3MmjH3sV/b 9KxshOFM0E8bQEf/zW4w/X2+wAu+75ITQ1ZlCLv6tPSkzutdBZEyY6sMN+b9FhP7kmUl4alv7 AnUEyHoCI2ol+dLDqmFomM8ztRp+tsr3yuofxwgvVFVkUWn+nAZmX1N42gAK7UAnEn7XGSgy+ nFJnVeGIprNZUQm817u8/zfRoJ/6KwTqAhoyinvjR4yvoKzkbLHdwFWERHTuNUCQx5yXni+cQ 8f4SmDY Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 6 Nov 2015 11:00:23 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/misc/cxl/context.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/misc/cxl/context.c b/drivers/misc/cxl/context.c index 2faa127..52e39b6 100644 --- a/drivers/misc/cxl/context.c +++ b/drivers/misc/cxl/context.c @@ -275,9 +275,7 @@ static void reclaim_ctx(struct rcu_head *rcu) if (ctx->kernelapi) kfree(ctx->mapping); - if (ctx->irq_bitmap) - kfree(ctx->irq_bitmap); - + kfree(ctx->irq_bitmap); kfree(ctx); } -- 2.6.2