From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161345AbbKFMn6 (ORCPT ); Fri, 6 Nov 2015 07:43:58 -0500 Received: from mout.web.de ([212.227.15.4]:60132 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031759AbbKFMn5 (ORCPT ); Fri, 6 Nov 2015 07:43:57 -0500 Subject: [PATCH] GPU-DRM-i915: Delete an unnecessary check before the function call "pwm_put" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> To: Daniel Vetter , David Airlie , Jani Nikula , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <563CA07D.30805@users.sourceforge.net> Date: Fri, 6 Nov 2015 13:43:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:JOmyZJayZClPT4jN6TOrCxZalTGioNg48MbpKKJMJEq4PUKn3Cw HhJjZhyOwWrW9ms2yRlsKhZMGCfopGVVCXYGj8mtMHQ90NDCXj50kfsr6q8t3tzGV8LwQJF bpY17eR31O2xfelklBLEyZhdWrNeRcjXglFigRFrhM14C91lZh3CWZPIj2FGRMnPhi7h8PS qxWiQcez2CmIJMEAP1CRg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Z6h8cPuEGGY=:H0VVkrhn+hiqMEar3DUftK 65/VKpoPb2pM6kKDzqApeBhxQsKu6sxllj9LrfnmnY2G4TAv1+6wR4ItEIP7se9fRGnB2nsNO 4cfm2ZWh0c7QCsYHNwRR1lpY66AMk2eroYmvWlQ2yVKC4RcI/WbCzlUH1kufoXzIp2y85PS5U mfcpfqBnb7xW+lVSx9EnBgedpWWEcb/k8hvDIelhkHssGKDgekd+scRwDOANHSL3TGwI+ApBo lwGFj7+5HGiJLb0Oy/CfYUh/VIe274Gsir8YIYOCxkm0Zj2p/2iQnQxXZcZDEB2XYechtgT19 MdvJyxRAUdyMYRymHtgLMeBUoPh0nDJWi52Ty6jtY4D5MPj3Ci5CLzJTD1MWX4Le9G2cSVpqv dXccVD6Ki1RDR6nyZl7K0AmcmYFfC4c4CKbGDt+qQzvwgJcjEBu2m4vYO7h+DMkeRpCtA74IO s/+q4RfpQqZKzuosyVsyBCCOpX1BLHb4f9mY9rqhMq0Xs55s0okUq83aKTIoppcrLV25dfPDR E89C6f2+RC7DIqME2cDrXmujLREZsWmXl5YTShAbLxS9zYupUyiLg3r/kAQFpsTtHBthfqp/t B+HgiQ3c9tIp3TFXHtIC5OPH84Wi0WVT7N8kCT6fGlItMEr22l4Lr7fkmH/kROdjQ0OPhefw6 pMD2liYLmbG1EIl/7CnanXKpfA+PlsFpN+B1IAukU5i/YGUgnPOrPb9Ex5TV7WsX/WngTsEHD +m3iCOkSojD8dOeTu0JgObMFGlUM3975NPObW2YNTtgMro09t+x1BhkmxpybF6MI60evolHGq WG4VNto Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 6 Nov 2015 13:38:22 +0100 The pwm_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/i915/intel_panel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c index a24df35..3d8d913 100644 --- a/drivers/gpu/drm/i915/intel_panel.c +++ b/drivers/gpu/drm/i915/intel_panel.c @@ -1729,8 +1729,7 @@ void intel_panel_destroy_backlight(struct drm_connector *connector) struct intel_panel *panel = &intel_connector->panel; /* dispose of the pwm */ - if (panel->backlight.pwm) - pwm_put(panel->backlight.pwm); + pwm_put(panel->backlight.pwm); panel->backlight.present = false; } -- 2.6.2