From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161482AbbKFNqD (ORCPT ); Fri, 6 Nov 2015 08:46:03 -0500 Received: from mout.web.de ([212.227.15.14]:49330 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033190AbbKFNqA (ORCPT ); Fri, 6 Nov 2015 08:46:00 -0500 Subject: [PATCH] GPU-DRM-ps8622: Delete an unnecessary check before backlight_device_unregister() References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> To: David Airlie , dri-devel@lists.freedesktop.org Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <563CAF0F.60105@users.sourceforge.net> Date: Fri, 6 Nov 2015 14:45:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Fo49enDooTxSHjLb/zry7GAz6mGSYGmsMX3czFB5YD668zT1btj bv3j9oKenfmjJineKMHQnHnQRt5t7tFf4w2dPPmNZCg/aE/4SxXZoPTWIP0BM0mmc6BXO9N mOauHgKICZyClKnJbKoeR2eNR1oevd3scKvivCz26HfFeur4lhuC2Bx6uOBcdGF0Ns8SFJy t4MOuSAbp2wrmaIh721PA== X-UI-Out-Filterresults: notjunk:1;V01:K0:BLkl48qV+dc=:dob4pgXU2eEmGI8qlIHedA BfHAkmDf2Etm/a4h67UQLU63trBI6NRpATIapXXVsSDkk/4H3+J/k3Kdp0BEIbkY1EsyGAjgi DBT9WpZ5CsFTG4pJ6y5H/KoTFp7b9gnhSMXR9WPAbe8yEhIWS+AUQmC4JCNhlAoWwnI1IK9gI iJUFjqkmL+doSmOLZDDPqys/6K51c3ZNPNIyT3J6QIf6q2LnqcdkUd7Q3JmS1kHulPFlU7Brf YFxwn4dvGNCbinMkAj/xh7nLlZ+9K5M7+nMC30JI+3unD/hcsxa69BMmvqetxssl+4hCEOBQ+ NWKgn9leMcLy9YSd8B0vpIY5lWelUpyGYPl5CH2ot45TgcdlUx5W1yOO2Q5IDMf1JoxiukJX1 Rg82cYJoGgSzVkdajMBPe35Cgto+s8Sxd7S59waQSSmfM1/5g/Q7+47d2WRCLSw3eVHwvRUi4 xGiE6fQopXN3GMr7+SqigyzUUa+PKDRLYQBHQ+qXOKl0BDsgVSSvWhnkrrWvGAShKfzLGtzZG jwYgZB0574w82/s6D6ZtIVtvtzi8JsVCffCi4I1TlQML4iH+heT5JTOtfiDHqjann7PaYH/I9 QOmJv/LPT1rfvcGFTLWLL13ywOf9YpdLqeZfgJMqfrbxQDdDGnT5JoWqLZCM0M9tGzOBLxJKg CXqBHiA4Gq1IEcvwPf/5hTsxIaqZpa3wyBZfxBDk1H7TXh5HIgtroRAa6VGmGckTa3r4zhq3L R9i9A5rhNrEuSI5KHzqqiL9cRDsPbvsNFYMvjVD9/mBFJPpmz6mb7H3amJXRU7yFwSlaxzTh9 5ree9B5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 6 Nov 2015 14:38:34 +0100 The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/bridge/parade-ps8622.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c index be881e9..046fba0 100644 --- a/drivers/gpu/drm/bridge/parade-ps8622.c +++ b/drivers/gpu/drm/bridge/parade-ps8622.c @@ -646,9 +646,7 @@ static int ps8622_remove(struct i2c_client *client) { struct ps8622_bridge *ps8622 = i2c_get_clientdata(client); - if (ps8622->bl) - backlight_device_unregister(ps8622->bl); - + backlight_device_unregister(ps8622->bl); drm_bridge_remove(&ps8622->bridge); return 0; -- 2.6.2