From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933002AbbKFOFz (ORCPT ); Fri, 6 Nov 2015 09:05:55 -0500 Received: from mout.web.de ([212.227.15.14]:62393 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932963AbbKFOFx (ORCPT ); Fri, 6 Nov 2015 09:05:53 -0500 Subject: [PATCH] HDMI-HDCP: Delete an unnecessary check before the function call "kfree" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> To: David Airlie , dri-devel@lists.freedesktop.org Cc: Linux Kernel Mailing List , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <563CB3B7.7010403@users.sourceforge.net> Date: Fri, 6 Nov 2015 15:05:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:aDrqv5MQUXSYuC+5ZCDKNvmiPxT08dfiLEPnNxBOgNDbSy3E9sk vRXPzL6H6BumX5blLpmV9H+2U7VHmwgMypiGhrDMvHSwBCI4/5MgSp5g/inZWFXJVkohinD GM34ihpra0Zs8C6xX+JmwyvhPAZHd+hgW4WCFqB9MQhb9FvhWlyR6aSUSBZ3yao++jra/Xx /po0/t5VT4MPf6uqT7EqA== X-UI-Out-Filterresults: notjunk:1;V01:K0:gd9gqFpWD0Q=:NrN7FdcB4Pp6j07CJJTPQa WKZWvCTtvSzxlu/yyqppCu7iCdUipCzAK1EDLW1yc2MKF1RFwN+gjFkij0Mg8oBJNjwTSdfAx z3wQkzwzXf+gYcJY/nV9eMna7104eajhqO6GpC5/eAavkzlm+3+NkrXa31l1paS7qY6GWywDU uWRDCqmIGK3Jy+2t5l2YqH9dhVoNgi4g4UYbFXfsnc/7Csa6wOKiBJo3YVMpJzve1YUI0dYrd 9NTgFN1/q3BcdJxJwd2VsdGGqVoEftJsZOTfk9wEsnWKfUr5JQdfXFCltEfd41Fe0UiWFQuA1 UOIlGWloZIXYeyx06gxAMip+xhpQrKTTvLHF5l72bp/rKq8ha1eLNWNCqM3Fc9feMfZ0A+/h8 INGG4nKv+QDIYijtEO1xDLBMi6jZj7SbVVEwBRW+UZjKKuXc/UzUZLiXdr7DDguiofvw9PPxd PFs3IdG7d+nGtviIwnyXzNB369bV86cv9ojf2u9DxjaLeikPpzwyzXo5hl0Jm4Np5N3EdZPBW ZAjETUL3ZSLi+LW5cO1k7d9r6gjgg9+XTVeDY7lCvA+VD9FPkwO27bueqhRB5K0lHC/GTNRaM UbE6xAHjwy+iJjMplxtRi6+HO4FSCAQx4FsUwE9bDLHWed+XWLW4nU204Fx4ysZ9Mkb5yBjI1 hIUDgtBU+C1HKz2gTrWEJNWWKr5KhYAMCP5TH/+5BKNbCLj1ZzeP05LI/NA2mQYSFCcPS89Ze fF7kDyJ9D/Pqj52qSS0xJ/JJucrpPfNEbyYu8Pqgn1lcdCN3G3TcBzMbjg1rvp/0KKp7zZPVU ECmv4XS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 6 Nov 2015 15:00:22 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/msm/hdmi/hdmi_hdcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_hdcp.c b/drivers/gpu/drm/msm/hdmi/hdmi_hdcp.c index 1dc9c34..205e931 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_hdcp.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_hdcp.c @@ -1430,7 +1430,7 @@ struct hdmi_hdcp_ctrl *hdmi_hdcp_init(struct hdmi *hdmi) void hdmi_hdcp_destroy(struct hdmi *hdmi) { - if (hdmi && hdmi->hdcp_ctrl) { + if (hdmi) { kfree(hdmi->hdcp_ctrl); hdmi->hdcp_ctrl = NULL; } -- 2.6.2