From: Peter Hurley <peter@hurleysoftware.com>
To: "Matwey V. Kornilov" <matwey@sai.msu.ru>
Cc: gregkh@linuxfoundation.org, jslaby@suse.com,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
matwey.kornilov@gmail.com
Subject: Re: [PATCH v2 2/3] tty: Implement default fallback serial8250_rs485_config
Date: Sat, 7 Nov 2015 07:29:03 -0500 [thread overview]
Message-ID: <563DEE8F.4050401@hurleysoftware.com> (raw)
In-Reply-To: <1446890976-1817-2-git-send-email-matwey@sai.msu.ru>
Hi Matwey,
On 11/07/2015 05:09 AM, Matwey V. Kornilov wrote:
> When 8250 driver doesn't have its own hardware RS485 support and doesn't
> want to override rs485_config callback, then default
> serial8250_rs485_config is used. It just stores supplied by user-space
> config.
>
> Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
> ---
> drivers/tty/serial/8250/8250_core.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index 3912646..8f292da 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -395,6 +395,12 @@ static void serial8250_release_rsa_resource(struct uart_8250_port *up)
> }
> }
> #endif
> +static int serial8250_rs485_config(struct uart_port *port,
> + struct serial_rs485 *rs485)
> +{
> + port->rs485 = *rs485;
> + return 0;
> +}
>
> static const struct uart_ops *base_ops;
> static struct uart_ops univ8250_port_ops;
> @@ -990,6 +996,10 @@ int serial8250_register_8250_port(struct uart_8250_port *up)
> uart->port.rs485 = up->port.rs485;
> uart->dma = up->dma;
>
> + /* Use software RS485 support when hardware one is not available */
> + if (!(uart->capabilities & UART_CAP_HW485) && !uart->port.rs485_config)
> + uart->port.rs485_config = serial8250_rs485_config;
To setup a default 8250 port function,
1. define the default 8250 port function in 8250/8250_port.c
2. add the port function to the dispatch table (serial8250_pops)
3. add a test for 8250 sub-driver override in serial8250_register_8250_port()
Eg.,
if (up->port.rs485_config)
uart->port.rs485_config = up->port.rs485_config;
Regards,
Peter Hurley
> /* Take tx_loadsz from fifosize if it wasn't set separately */
> if (uart->port.fifosize && !uart->tx_loadsz)
> uart->tx_loadsz = uart->port.fifosize;
>
next prev parent reply other threads:[~2015-11-07 12:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 10:09 [PATCH v2 1/3] tty: Introduce UART_CAP_HW485 Matwey V. Kornilov
2015-11-07 10:09 ` [PATCH v2 2/3] tty: Implement default fallback serial8250_rs485_config Matwey V. Kornilov
2015-11-07 12:29 ` Peter Hurley [this message]
2015-11-07 13:51 ` Matwey V. Kornilov
2015-11-07 14:20 ` Peter Hurley
2015-11-07 10:09 ` [PATCH v2 3/3] tty: Add software emulated RS485 support for 8250 Matwey V. Kornilov
2015-11-07 16:03 ` Peter Hurley
2015-11-08 10:52 ` Matwey V. Kornilov
2015-11-09 14:40 ` Peter Hurley
2015-11-09 15:45 ` Matwey V. Kornilov
2015-11-09 21:30 ` Peter Hurley
2015-11-09 21:43 ` Matwey V. Kornilov
2015-11-09 22:05 ` Peter Hurley
2015-11-10 11:35 ` Matwey V. Kornilov
2015-11-10 16:12 ` Peter Hurley
2015-11-10 16:25 ` Matwey V. Kornilov
2015-11-10 16:52 ` Peter Hurley
2015-11-12 12:34 ` Matwey V. Kornilov
2015-11-12 13:35 ` Peter Hurley
2015-11-13 8:35 ` Matwey V. Kornilov
2015-11-07 12:22 ` [PATCH v2 1/3] tty: Introduce UART_CAP_HW485 Peter Hurley
2015-11-07 12:39 ` Matwey V. Kornilov
2015-11-07 15:32 ` Peter Hurley
2015-11-07 21:10 ` Matwey V. Kornilov
2015-11-07 22:04 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563DEE8F.4050401@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=matwey.kornilov@gmail.com \
--cc=matwey@sai.msu.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).