From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753526AbbKGOPx (ORCPT ); Sat, 7 Nov 2015 09:15:53 -0500 Received: from mout.web.de ([212.227.15.14]:62447 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753214AbbKGOPv (ORCPT ); Sat, 7 Nov 2015 09:15:51 -0500 Subject: [PATCH] ethernet-synopsys: Delete an unnecessary check before of_node_put() To: David Miller , Lars Persson , netdev@vger.kernel.org References: <5317A59D.4@users.sourceforge.net> <563C5392.6030309@users.sourceforge.net> <20151106.233311.2260896695923603885.davem@davemloft.net> Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, julia.lawall@lip6.fr From: SF Markus Elfring Message-ID: <563E077C.3090201@users.sourceforge.net> Date: Sat, 7 Nov 2015 15:15:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151106.233311.2260896695923603885.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:+4yERPka3m1uSPqUuxsF1Ys42aOz/JTZwy/Ibb7DCJ1ybJmQi1a LJtIxqQjaI/pCS4TyP0uEC9PU7CF1/IEvevnRYxq5nyz3K8rERjrgM8Z0cEeomYJHF/DGLo 8Qg0dvnmOUoyIeKftTldNy/NgH2W8A1jR/T2uTW3Ph4ysBG70AN1Satc9dEQRp/zdQ8FPXB Lz7t1XgOTXNN0WR3ndFnQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:2tS1fdPHPWM=:lBZ80FFVGBdeVwYDgqs69x uOfNxmq+nFFYqxRFmvOdqB03mE/40eC2Z4SrqL6eCSU/hISrbu2XNAdw18yyAUwnUnjn7yvoy UAkjPH/ABAkyPfSu6lgm9H7aqO3NOWFQ+aljrTH2tWGA3ROJvCX7k+lCWxq7+GgqPJqiF2W+I w+kURRBclkMaak9iBEMGw2Bhk05K9OQUIGetJQa6/IUC45a09TJB4AKK8sYOZQURxav72sfcy vHlBTcgwg9l2kA6eTnnj8Kkdq0kUq8Opua0ByNMpzXbgvJ/Q0gxGYpVyjZaF3YpDAqzn/gD6j e/6Bo8EIY9HotaheUrILhAPgtPOr3svqrVZT+/ogDW02QBfz2Kryoc2prJoJCZT6gI8yxemSj w9hJQ581EOxAck0SCmhD4vPg75o8BctoeuGyQbtdA1ddVZtzgBU6IpuTlfmePnIwvPqS6MkKU F9NTvOC8ck1OYH8QHBnR7mtvLpPErEnUF5/CXIbeQqJzY+r9wTljAbKZY9BA2Tn6iDOrdpTwf X4BLOm/9UmmDYGyU5BQGtRaS4BkdMrtMo+VBajv1fhB5u8o13tnYpuDtQiQljHnZp4iOsrOxq SVfgx80RnTSuWzC8UV+H+3lDNt1NvVXwgbr+92oQc4179qQRktOisYQn4HP9l8ZEWgmsMQDlt m0MqyUMb6hWXWgNuxxxUEscXMFcH5Iv4dkjFtDk/fBRJy6m/qLoATugJZRoZYFj5e2ijoYycp MtwEXBV896rVP4Si6m8TMy84/V4P356Fhh/W4HK+BoHDi83LsQX691k8svxyJ9FWsfaFaYoNx eBPJdGp Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 7 Nov 2015 15:10:29 +0100 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/synopsys/dwc_eth_qos.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/synopsys/dwc_eth_qos.c b/drivers/net/ethernet/synopsys/dwc_eth_qos.c index 85b3326..9066d7a 100644 --- a/drivers/net/ethernet/synopsys/dwc_eth_qos.c +++ b/drivers/net/ethernet/synopsys/dwc_eth_qos.c @@ -2970,8 +2970,7 @@ err_out_unregister_netdev: err_out_clk_dis_aper: clk_disable_unprepare(lp->apb_pclk); err_out_free_netdev: - if (lp->phy_node) - of_node_put(lp->phy_node); + of_node_put(lp->phy_node); free_netdev(ndev); platform_set_drvdata(pdev, NULL); return ret; -- 2.6.2