From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753830AbbKGPfG (ORCPT ); Sat, 7 Nov 2015 10:35:06 -0500 Received: from mout.web.de ([212.227.15.14]:63425 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753455AbbKGPfA (ORCPT ); Sat, 7 Nov 2015 10:35:00 -0500 Subject: [PATCH] dwc_eth_qos: Delete an unnecessary check before the function call "of_node_put" To: David Miller , Lars Persson , netdev@vger.kernel.org References: <5317A59D.4@users.sourceforge.net> <563C5392.6030309@users.sourceforge.net> <20151106.233311.2260896695923603885.davem@davemloft.net> Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <563E1A18.101@users.sourceforge.net> Date: Sat, 7 Nov 2015 16:34:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151106.233311.2260896695923603885.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:maEeO77LnnVGMDvpoPC7ttPAmp0ck9i9TMszWHg9NZ6XGafBT3a GjZO8K5wDNRsqY1/UOsK95uG7Nrax0GOdiCtaOwqMM7Abr6g/Jc3kZo+0b2t0lyVvfNxMVO RNyNP38yuVmMOgf4ScBwvALRQgh5/55ah5evgr7kXGi2X89Flrooov1J5ex4SlFtpr6acdH I8tweALolh7WokPzSfpIQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:K7PQW8DT+Mg=:FY5OKO8RH9JZMktUBBnwkm H0v0RoZ+EbIp7xmpwmOnXtv+MMhkkMh872uWT21acdqqZ1v2TQZAJ+f3VSe3fAOMLfxgaYTh/ X4Q2QwfshzDyPinTzoOxcgrz+kFF6MMXc7U9N1GcF771K32+7lhK1ZXypT2plDvdsC26JhhX/ DWMO+Jl5dGx64Qai/0BYaz5PwsXLe5y1NVPP4mhEY1d1mAt+fWaZgJzDQHt3czWpVPFng02Yr fqIMZJV0ZGccQU0CwjJdEU2pMIAQTX09VxbAsj0FJWPzxO80QstcUPbu1SeCZGSYemWx3EE2w 8TiMEzG+Xdb4fbWmXcZR3o5oL4T8gmgWOGJAjavXSWqGmALLiZi3iTyzKR9zLa/v/7P77b8fa k8QxbYlBjqQc//7WQqbUK8h886FUEhhDG2DRDWlQEXftrCkTzCXGDRWOrfGWdfVBUTzfwWU8y rV6Y7MUvtaXj9MPG/cBB0TtT8UDFTGs3qyguu+fe3/zgwkpAxrfo+x80qcMZiq+axxGlTXTeQ 7UIRX3H21BRMFdnLa8o8QHGHUHuAp2Om9f9M69SCoKln+DaJJH+/Ta7s4jwtxxkUlE3IogjlP vl0N3AYxlONhxAx0stKaZvoXtinLXsVfgFzxe5JaBciPbCVsupUd2es8dp++9G3SwcAZp8apJ vF3QPrTC2jgVEAzqwkp33om3ZA/fJd7quGUryPTZYjKeEVhnaED2Z15irRYcQgPl5ZiXvVz3d JuNgcaS9TjXUTEVotzdq920Q1SCWN+gVzhduI6CxT5RE0cAMmTEF5+tnzMQfFkqOfIF5i0PjQ rvLmeZ5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 7 Nov 2015 16:30:34 +0100 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/synopsys/dwc_eth_qos.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/synopsys/dwc_eth_qos.c b/drivers/net/ethernet/synopsys/dwc_eth_qos.c index 85b3326..9066d7a 100644 --- a/drivers/net/ethernet/synopsys/dwc_eth_qos.c +++ b/drivers/net/ethernet/synopsys/dwc_eth_qos.c @@ -2970,8 +2970,7 @@ err_out_unregister_netdev: err_out_clk_dis_aper: clk_disable_unprepare(lp->apb_pclk); err_out_free_netdev: - if (lp->phy_node) - of_node_put(lp->phy_node); + of_node_put(lp->phy_node); free_netdev(ndev); platform_set_drvdata(pdev, NULL); return ret; -- 2.6.2