From: Daniel Wagner <daniel.wagner@bmw-carit.de>
To: <paulmck@linux.vnet.ibm.com>
Cc: <linux-kernel@vger.kernel.org>, <xen-devel@lists.xenproject.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] smpboot: Add smpboot state variables instead of reusing CPU hotplug states
Date: Thu, 12 Nov 2015 15:34:00 +0100 [thread overview]
Message-ID: <5644A358.6090806@bmw-carit.de> (raw)
In-Reply-To: <20151107071723.GH3879@linux.vnet.ibm.com>
Hi Paul,
On 11/07/2015 08:17 AM, Paul E. McKenney wrote:
> On Thu, Oct 15, 2015 at 01:32:44PM +0200, Daniel Wagner wrote:
>> The cpu hotplug state machine in smpboot.c is reusing the states from
>> cpu.h. That is confusing when it comes to the CPU_DEAD_FROZEN usage.
>> Paul explained to me that he was in need of an additional state
>> for destinguishing between a CPU error states. For this he just
>> picked CPU_DEAD_FROZEN.
>>
>> 8038dad7e888581266c76df15d70ca457a3c5910 smpboot: Add common code for notification from dying CPU
>> 2a442c9c6453d3d043dfd89f2e03a1deff8a6f06 x86: Use common outgoing-CPU-notification code
>>
>> Instead of reusing the states, let's add new definition inside
>> the smpboot.c file with explenation what those states
>> mean. Thanks Paul for providing them.
>>
>> Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
>
> Apologies for the delay, I didn't realize that you were waiting on me.
No apology needed. I didn't express my wish explicitly. I'll post it
again after the merge window is closed.
> Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Thanks,
Daniel
prev parent reply other threads:[~2015-11-12 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 11:32 [PATCH] smpboot: Add smpboot state variables instead of reusing CPU hotplug states Daniel Wagner
2015-11-05 8:09 ` Daniel Wagner
2015-11-07 7:17 ` Paul E. McKenney
2015-11-12 14:34 ` Daniel Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5644A358.6090806@bmw-carit.de \
--to=daniel.wagner@bmw-carit.de \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).