From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753125AbbKQQLs (ORCPT <rfc822;w@1wt.eu>);
	Tue, 17 Nov 2015 11:11:48 -0500
Received: from devils.ext.ti.com ([198.47.26.153]:56728 "EHLO
	devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751452AbbKQQLq (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 17 Nov 2015 11:11:46 -0500
Subject: Re: [PATCH v3 6/6] gpio: tps65086: Add GPIO driver for the TPS65086
 PMIC
To: Linus Walleij <linus.walleij@linaro.org>
References: <1446657135-7820-1-git-send-email-afd@ti.com>
 <1446657135-7820-7-git-send-email-afd@ti.com>
 <CACRpkdb1V7JxLSbwqf4CX+nDLeQzP=bOA9YMXzE4CFTQfzRL9w@mail.gmail.com>
CC: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Alexandre Courbot <gnurou@gmail.com>,
        Samuel Ortiz <sameo@linux.intel.com>, Lee Jones <lee.jones@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
From: "Andrew F. Davis" <afd@ti.com>
Message-ID: <564B51B3.2000102@ti.com>
Date: Tue, 17 Nov 2015 10:11:31 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <CACRpkdb1V7JxLSbwqf4CX+nDLeQzP=bOA9YMXzE4CFTQfzRL9w@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/17/2015 03:17 AM, Linus Walleij wrote:
> On Wed, Nov 4, 2015 at 6:12 PM, Andrew F. Davis <afd@ti.com> wrote:
>
>> Add support for the TPS65086 PMIC GPOs.
>>
>> TPS65086 has four configurable GPOs that can be used for several
>> purposes.
>>
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>
> OK...
>
>> +static int tps65086_gpio_get(struct gpio_chip *gc, unsigned offset)
>> +static void tps65086_gpio_set(struct gpio_chip *gc, unsigned offset,
>
> Just get/set and no get_direction/direction_input/direction_output?
> Are you sure?
>

Yeah, these are output only, I could probably add get_direction and just
always return output, but setters wouldn't make sense here.

Andrew

> Yours,
> Linus Walleij
>