From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753728AbbK0BVB (ORCPT ); Thu, 26 Nov 2015 20:21:01 -0500 Received: from lucky1.263xmail.com ([211.157.147.131]:47215 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753635AbbK0BU6 (ORCPT ); Thu, 26 Nov 2015 20:20:58 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <3c8dc8bd00e700df78f3dad63931c2c9> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v8 02/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory To: =?UTF-8?Q?Heiko_St=c3=bcbner?= References: <1446020143-32645-1-git-send-email-ykk@rock-chips.com> <1446020519-625-1-git-send-email-ykk@rock-chips.com> <1812354.kkj0DGG9mi@diego> Cc: Inki Dae , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Jingoo Han , Thierry Reding , Krzysztof Kozlowski , Rob Herring , Mark Yao , Russell King , djkurtz@chromium.org, dianders@chromium.org, Sean Paul , Kukjin Kim , Kumar Gala , emil.l.velikov@gmail.com, Ian Campbell , Gustavo Padovan , Kishon Vijay Abraham I , Pawel Moll , ajaynumb@gmail.com, robherring2@gmail.com, javier@osg.samsung.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kern, el.org@NULL.NULL, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Yakir Yang Message-ID: <5657AFEC.60004@rock-chips.com> Date: Fri, 27 Nov 2015 09:20:44 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1812354.kkj0DGG9mi@diego> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, Thanks you for feedback, I do see some conflicts in Exynos Make/Kconfig file [02/17] and dtsi file [07/17] when I try to apply this series on 4.4-rc1 branch. Hmm... Due to I have update some patches to version 10 already, this series may be become harder to reviewed, should I just send the whole series out that update the version to v10. Thanks - Yakir On 11/27/2015 01:30 AM, Heiko Stübner wrote: > Hi Yakir, > > Am Mittwoch, 28. Oktober 2015, 16:21:59 schrieb Yakir Yang: >> Split the dp core driver from exynos directory to bridge directory, >> and rename the core driver to analogix_dp_*, rename the platform >> code to exynos_dp. >> >> Beside the new analogix_dp driver would export four hooks. >> "analogix_dp_bind()" and "analogix_dp_unbind()" >> "analogix_dp_detect()" and "analogix_dp_get_modes()" >> >> The bind/unbind symbols is used for analogix platform driver to connect >> with analogix_dp core driver. And the detect/get_modes is used for analogix >> platform driver to init the connector. >> >> They reason why connector need register in helper driver is rockchip drm >> haven't implement the atomic API, but Exynos drm have implement it, so >> there would need two different connector helper functions, that's why we >> leave the connector register in helper driver. >> >> Tested-by: Javier Martinez Canillas >> Signed-off-by: Yakir Yang > [...] > >> diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig >> index bd1a415..5f74f80 100644 >> --- a/drivers/gpu/drm/exynos/Kconfig >> +++ b/drivers/gpu/drm/exynos/Kconfig >> @@ -55,8 +55,9 @@ config DRM_EXYNOS_DSI >> This enables support for Exynos MIPI-DSI device. >> >> config DRM_EXYNOS_DP >> - bool "EXYNOS DRM DP driver support" >> + bool "EXYNOS specific extensions for Analogix DP driver" >> depends on DRM_EXYNOS && (DRM_EXYNOS_FIMD || DRM_EXYNOS7_DECON) >> + select DRM_ANALOGIX_DP >> default DRM_EXYNOS >> select DRM_PANEL >> help > This doesn't apply anymore to 4.4-rc due to other changes in there. The > exynos/Makefile is affected as well. > > > >