From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756701AbbLBKrL (ORCPT ); Wed, 2 Dec 2015 05:47:11 -0500 Received: from lucky1.263xmail.com ([211.157.147.131]:55688 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755154AbbLBKrI (ORCPT ); Wed, 2 Dec 2015 05:47:08 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v8 14/17] drm: bridge: analogix/dp: add max link rate and lane count limit for RK3288 To: =?UTF-8?Q?Heiko_St=c3=bcbner?= References: <1446020143-32645-1-git-send-email-ykk@rock-chips.com> <1446022561-16870-1-git-send-email-ykk@rock-chips.com> <2807882.UeSPH80il3@diego> Cc: Inki Dae , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Jingoo Han , Thierry Reding , Krzysztof Kozlowski , Rob Herring , Mark Yao , Russell King , djkurtz@chromium.org, dianders@chromium.org, Sean Paul , Kukjin Kim , Kumar Gala , emil.l.velikov@gmail.com, Ian Campbell , Gustavo Padovan , Kishon Vijay Abraham I , Pawel Moll , ajaynumb@gmail.com, robherring2@gmail.com, javier@osg.samsung.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kern, el.org@NULL.NULL, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Yakir Yang Message-ID: <565ECC21.3060306@rock-chips.com> Date: Wed, 2 Dec 2015 18:46:57 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <2807882.UeSPH80il3@diego> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, On 11/27/2015 09:32 PM, Heiko Stübner wrote: > Am Mittwoch, 28. Oktober 2015, 16:56:01 schrieb Yakir Yang: >> There are some IP limit on rk3288 that only support 4 physical lanes >> of 2.7/1.6 Gbps/lane, so seprate them out by device_type flag. >> >> Tested-by: Javier Martinez Canillas >> Signed-off-by: Yakir Yang >> --- > [...] > >> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >> b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index >> 6307060..563ffb1d 100644 >> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >> @@ -890,8 +890,8 @@ static void analogix_dp_commit(struct analogix_dp_device >> *dp) return; >> } >> >> - ret = analogix_dp_set_link_train(dp, dp->video_info.lane_count, >> - dp->video_info.link_rate); >> + ret = analogix_dp_set_link_train(dp, dp->video_info.max_lane_count, >> + dp->video_info.max_link_rate); >> if (ret) { >> dev_err(dp->dev, "unable to do link train\n"); >> return; >> @@ -1156,16 +1156,25 @@ static int analogix_dp_dt_parse_pdata(struct >> analogix_dp_device *dp) struct device_node *dp_node = dp->dev->of_node; >> struct video_info *video_info = &dp->video_info; >> >> - if (of_property_read_u32(dp_node, "samsung,link-rate", >> - &video_info->link_rate)) { >> - dev_err(dp->dev, "failed to get link-rate\n"); >> - return -EINVAL; >> - } >> - >> - if (of_property_read_u32(dp_node, "samsung,lane-count", >> - &video_info->lane_count)) { >> - dev_err(dp->dev, "failed to get lane-count\n"); >> - return -EINVAL; >> + switch (dp->plat_data && dp->plat_data->dev_type) { > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c: In function ‘analogix_dp_dt_parse_pdata’: > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1191:10: warning: switch condition has boolean value [-Wswitch-bool] > switch (dp->plat_data && dp->plat_data->dev_type) { > ^ > > As I think we always will need to distinguish between implementations, > I guess it should be safe to exit with an error, it that implementation-data > is not available, like just doing before the switch a: > > if (!dp->plat_data) > return -EINVAL; Done, thanks - Yakir > > Heiko > > >