From: Sagi Grimberg <sagi@grimberg.me>
To: Lei Lei2 Yin <yinlei2@lenovo.com>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"axboe@fb.com" <axboe@fb.com>, "hch@lst.de" <hch@lst.de>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"cybeyond@foxmail.com" <cybeyond@foxmail.com>
Subject: Re: [External] Re: [PATCH] nvme: fix heap-use-after-free and oops in bio_endio for nvme multipath
Date: Tue, 21 Mar 2023 14:26:13 +0200 [thread overview]
Message-ID: <56620baf-6195-b987-6067-ae81d23e39c5@grimberg.me> (raw)
In-Reply-To: <PS1PR03MB49395AC5BC73DDDA6A79E87488819@PS1PR03MB4939.apcprd03.prod.outlook.com>
> Thank you for your reply
>
> This problem occurs in nvme over rdma and nvme over tcp with nvme generate multipath. Delete the ns gendisk is caused by nvmf target subsystem is faulty, then host detect all path keep alive overtime and io timeout. After ctrl-loss-tmo seconds, host will remove fail ctrl and ns gendisk.
That is fine, but it is a problem if it does not correctly drain
inflight I/O, weather it was split or not. And this looks like the wrong
place to address this.
> We have reappear this proble in Linux-5.10.136, Linux-5.10.167 and the latest commit in linux-5.10.y, and this patch is only applicable to Linux-5.10.y
So my understanding that this does not reproduce upstream?
>
> Yes , this is absolutely the wrong place to do this . Can i move this modification after nvme_trace_bio_complete?
>
> Do I need to resubmit a patch, if modifications are needed?
Yes, but a backport fix needs to be sent to stable mailing list
(stable@vger.kernel.org) and cc'd to linux-nvme mailing list.
But I don't think that this fix is the correct one. What is needed is
to identify where this was fixed upstream and backport that fix instead.
If that is too involving because of code dependencies, it may be
possible to send an alternative surgical fix, but it needs to be
justified.
next prev parent reply other threads:[~2023-03-21 12:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 10:50 [PATCH] nvme: fix heap-use-after-free and oops in bio_endio for nvme multipath Lei Lei2 Yin
2023-03-21 11:09 ` Sagi Grimberg
2023-03-21 11:54 ` [External] " Lei Lei2 Yin
2023-03-21 12:26 ` Sagi Grimberg [this message]
2023-03-21 13:30 ` 回复: " Lei Lei2 Yin
2023-03-21 15:00 ` hch
2023-03-22 7:12 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56620baf-6195-b987-6067-ae81d23e39c5@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@fb.com \
--cc=cybeyond@foxmail.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=yinlei2@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).