From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965242AbbLHQEH (ORCPT <rfc822;w@1wt.eu>);
	Tue, 8 Dec 2015 11:04:07 -0500
Received: from mailapp01.imgtec.com ([195.59.15.196]:64883 "EHLO
	mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S965169AbbLHQEE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 8 Dec 2015 11:04:04 -0500
Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio
 internal DAC
To: Mark Brown <broonie@kernel.org>
References: <1448299499-18435-1-git-send-email-Damien.Horsley@imgtec.com>
 <1448299499-18435-3-git-send-email-Damien.Horsley@imgtec.com>
 <20151125124728.GT1929@sirena.org.uk>
CC: <alsa-devel@alsa-project.org>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From: Damien Horsley <Damien.Horsley@imgtec.com>
Message-ID: <5666FF72.7010206@imgtec.com>
Date: Tue, 8 Dec 2015 16:04:02 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151125124728.GT1929@sirena.org.uk>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [192.168.167.68]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 25/11/15 12:47, Mark Brown wrote:
> On Mon, Nov 23, 2015 at 05:24:59PM +0000, Damien Horsley wrote:
> 
>> +	/* The mute state as set by alsa using the digital_mute callback */
>> +	bool alsa_mute_state;
>> +	/* The mute state as set by the userspace mute control */
>> +	bool control_mute_state;
>> +	/* The actual mute state is equal to an OR of the above */
> 
> Does the device *need* the digital mute to avoid noise?  If there's no
> strong need for it then just don't bother which simplifies the code a
> lot.
> 
> Otherwise this looks good.
> 

It does not seem to make a difference. I will remove and repost.