From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751731AbbLHW2x (ORCPT ); Tue, 8 Dec 2015 17:28:53 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:26343 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751201AbbLHW2w (ORCPT ); Tue, 8 Dec 2015 17:28:52 -0500 Subject: Re: [PATCH] soc: TI knav_qmss: fix dma_addr_t printing To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org References: <2560281.KhcNzi0XgD@wuerfel> <56670B21.5060209@oracle.com> <18371096.H4qt47cWYH@wuerfel> Cc: Murali Karicheri , "Kwok, WingMan" , linux-kernel@vger.kernel.org, Santosh Shilimkar From: santosh shilimkar Organization: Oracle Corporation Message-ID: <56675981.5060206@oracle.com> Date: Tue, 8 Dec 2015 14:28:17 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <18371096.H4qt47cWYH@wuerfel> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/8/2015 1:34 PM, Arnd Bergmann wrote: > On Tuesday 08 December 2015 08:53:53 santosh shilimkar wrote: >> On 12/8/2015 7:30 AM, Arnd Bergmann wrote: >>> The knav_qmss driver is currently broken when CONFIG_LPAE is >>> set, which is a bit surprising because I'd expect that any serious >>> users of this platforms would have more than 2GB of RAM and require >>> LPAE. >>> >> Well it has been working with LPAE enable always. The production >> systems do but IIRC, some of the Eval board were still build with >> just 2 GB memory. > > Maybe that just means that the debug code is never used and we can remove > all the dev_dbg instead? That might actually be nicer as it would reduce > the amount of code in your driver (slightly). > It was added in intention so that it is useful. I agree if it is not used or useful, we should remove it. Regards, Santosh