From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751184AbbLIBDr (ORCPT ); Tue, 8 Dec 2015 20:03:47 -0500 Received: from lucky1.263xmail.com ([211.157.147.132]:59175 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752552AbbLIBDL (ORCPT ); Tue, 8 Dec 2015 20:03:11 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v10 05/17] dt-bindings: add document for analogix display port driver To: Rob Herring References: <1449470239-30667-1-git-send-email-ykk@rock-chips.com> <1449470347-31062-1-git-send-email-ykk@rock-chips.com> <20151208150131.GA8646@rob-hp-laptop> Cc: Inki Dae , Mark Yao , Jingoo Han , Heiko Stuebner , Thierry Reding , Krzysztof Kozlowski , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Russell King , emil.l.velikov@gmail.com, Gustavo Padovan , Kishon Vijay Abraham I , ajaynumb@gmail.com, javier@osg.samsung.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Yakir Yang Message-ID: <56677DC0.3080903@rock-chips.com> Date: Wed, 9 Dec 2015 09:02:56 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151208150131.GA8646@rob-hp-laptop> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Thanks - Yakir On 12/08/2015 11:01 PM, Rob Herring wrote: > On Mon, Dec 07, 2015 at 02:39:07PM +0800, Yakir Yang wrote: >> Analogix dp driver is split from exynos dp driver, so we just >> make an copy of exynos_dp.txt, and then simplify exynos_dp.txt >> >> Beside update some exynos dtsi file with the latest change >> according to the devicetree binding documents. >> >> Signed-off-by: Yakir Yang >> Tested-by: Javier Martinez Canillas > Acked-by: Rob Herring > >> --- >> Changes in v10: None >> Changes in v9: None >> Changes in v8: >> - Correct the right document path of display-timing.txt (Heiko) >> - Correct the misspell of 'from' to 'frm'. (Heiko) >> >> Changes in v7: None >> Changes in v6: None >> Changes in v5: None >> Changes in v4: >> - Split all DTS changes, and provide backward compatibility. Mark old >> properties as deprecated but still support them. (Krzysztof) >> - Update "analogix,hpd-gpio" to "hpd-gpios" prop name. (Rob) >> - Deprecated some properties which could parsed from Edid/Mode/DPCD. (Thierry) >> "analogix,color-space" & "analogix,color-depth" & >> "analogix,link-rate" & "analogix,lane-count" & >> "analogix,ycbcr-coeff" & "analogix,dynamic-range" & >> "vsync-active-high" & "hsync-active-high" & "interlaces" >> >> Changes in v3: >> - Add devicetree binding documents. (Heiko) >> - Remove sync pol & colorimetry properies from the new analogix dp driver >> devicetree binding. (Thierry) >> - Update the exist exynos dtsi file with the latest DP DT properies. >> >> Changes in v2: None >> >> .../bindings/display/bridge/analogix_dp.txt | 50 +++++++++++++++++ >> .../bindings/display/exynos/exynos_dp.txt | 65 ++++++++-------------- >> 2 files changed, 72 insertions(+), 43 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/display/bridge/analogix_dp.txt >> >> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt >> new file mode 100644 >> index 0000000..7659a7a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt >> @@ -0,0 +1,50 @@ >> +Analogix Display Port bridge bindings >> + >> +Required properties for dp-controller: >> + -compatible: >> + platform specific such as: >> + * "samsung,exynos5-dp" >> + * "rockchip,rk3288-dp" >> + -reg: >> + physical base address of the controller and length >> + of memory mapped region. >> + -interrupts: >> + interrupt combiner values. >> + -clocks: >> + from common clock binding: handle to dp clock. >> + -clock-names: >> + from common clock binding: Shall be "dp". >> + -interrupt-parent: >> + phandle to Interrupt combiner node. >> + -phys: >> + from general PHY binding: the phandle for the PHY device. >> + -phy-names: >> + from general PHY binding: Should be "dp". >> + >> +Optional properties for dp-controller: >> + -hpd-gpios: >> + Hotplug detect GPIO. >> + Indicates which GPIO should be used for hotplug detection >> + -port@[X]: SoC specific port nodes with endpoint definitions as defined >> + in Documentation/devicetree/bindings/media/video-interfaces.txt, >> + please refer to the SoC specific binding document: >> + * Documentation/devicetree/bindings/display/exynos/exynos_dp.txt >> + * Documentation/devicetree/bindings/video/analogix_dp-rockchip.txt >> + >> + >> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt >> +------------------------------------------------------------------------------- >> + >> +Example: >> + >> + dp-controller { >> + compatible = "samsung,exynos5-dp"; >> + reg = <0x145b0000 0x10000>; >> + interrupts = <10 3>; >> + interrupt-parent = <&combiner>; >> + clocks = <&clock 342>; >> + clock-names = "dp"; >> + >> + phys = <&dp_phy>; >> + phy-names = "dp"; >> + }; >> diff --git a/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt b/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt >> index 64693f2..9905081 100644 >> --- a/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt >> +++ b/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt >> @@ -31,45 +31,31 @@ Required properties for dp-controller: >> from general PHY binding: the phandle for the PHY device. >> -phy-names: >> from general PHY binding: Should be "dp". >> - -samsung,color-space: >> - input video data format. >> - COLOR_RGB = 0, COLOR_YCBCR422 = 1, COLOR_YCBCR444 = 2 >> - -samsung,dynamic-range: >> - dynamic range for input video data. >> - VESA = 0, CEA = 1 >> - -samsung,ycbcr-coeff: >> - YCbCr co-efficients for input video. >> - COLOR_YCBCR601 = 0, COLOR_YCBCR709 = 1 >> - -samsung,color-depth: >> - number of bits per colour component. >> - COLOR_6 = 0, COLOR_8 = 1, COLOR_10 = 2, COLOR_12 = 3 >> - -samsung,link-rate: >> - link rate supported by the panel. >> - LINK_RATE_1_62GBPS = 0x6, LINK_RATE_2_70GBPS = 0x0A >> - -samsung,lane-count: >> - number of lanes supported by the panel. >> - LANE_COUNT1 = 1, LANE_COUNT2 = 2, LANE_COUNT4 = 4 >> - - display-timings: timings for the connected panel as described by >> - Documentation/devicetree/bindings/display/display-timing.txt >> >> Optional properties for dp-controller: >> - -interlaced: >> - interlace scan mode. >> - Progressive if defined, Interlaced if not defined >> - -vsync-active-high: >> - VSYNC polarity configuration. >> - High if defined, Low if not defined >> - -hsync-active-high: >> - HSYNC polarity configuration. >> - High if defined, Low if not defined >> - -samsung,hpd-gpio: >> - Hotplug detect GPIO. >> - Indicates which GPIO should be used for hotplug >> - detection >> - -video interfaces: Device node can contain video interface port >> - nodes according to [1]. >> + - display-timings: timings for the connected panel as described by >> + Documentation/devicetree/bindings/display/panel/display-timing.txt >> + >> +For the below properties, please refer to Analogix DP binding document: >> + * Documentation/devicetree/bindings/display/bridge/analogix_dp.txt >> + -phys (required) >> + -phy-names (required) >> + -hpd-gpios (optional) >> + -video interfaces (optional) >> >> -[1]: Documentation/devicetree/bindings/media/video-interfaces.txt >> +Deprecated properties for DisplayPort: >> +-interlaced: deprecated prop that can parsed from drm_display_mode. >> +-vsync-active-high: deprecated prop that can parsed from drm_display_mode. >> +-hsync-active-high: deprecated prop that can parsed from drm_display_mode. >> +-samsung,ycbcr-coeff: deprecated prop that can parsed from drm_display_mode. >> +-samsung,dynamic-range: deprecated prop that can parsed from drm_display_mode. >> +-samsung,color-space: deprecated prop that can parsed from drm_display_info. >> +-samsung,color-depth: deprecated prop that can parsed from drm_display_info. >> +-samsung,link-rate: deprecated prop that can reading from monitor by dpcd method. >> +-samsung,lane-count: deprecated prop that can reading from monitor by dpcd method. >> +-samsung,hpd-gpio: deprecated name for hpd-gpios. >> + >> +------------------------------------------------------------------------------- >> >> Example: >> >> @@ -88,13 +74,6 @@ SOC specific portion: >> >> Board Specific portion: >> dp-controller { >> - samsung,color-space = <0>; >> - samsung,dynamic-range = <0>; >> - samsung,ycbcr-coeff = <0>; >> - samsung,color-depth = <1>; >> - samsung,link-rate = <0x0a>; >> - samsung,lane-count = <4>; >> - >> display-timings { >> native-mode = <&lcd_timing>; >> lcd_timing: 1366x768 { >> -- >> 1.9.1 >> >> > >