From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752505AbbLIBGD (ORCPT ); Tue, 8 Dec 2015 20:06:03 -0500 Received: from lucky1.263xmail.com ([211.157.147.132]:60211 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751934AbbLIBF7 (ORCPT ); Tue, 8 Dec 2015 20:05:59 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <36dd4b553325b10da7c51deecbcd74f3> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v10 08/17] dt-bindings: add document for rockchip variant of analogix_dp To: Rob Herring References: <1449470239-30667-1-git-send-email-ykk@rock-chips.com> <1449470374-31191-1-git-send-email-ykk@rock-chips.com> <20151208150356.GA14750@rob-hp-laptop> Cc: Inki Dae , Mark Yao , Jingoo Han , Heiko Stuebner , Thierry Reding , Krzysztof Kozlowski , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Russell King , emil.l.velikov@gmail.com, Gustavo Padovan , Kishon Vijay Abraham I , ajaynumb@gmail.com, javier@osg.samsung.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Yakir Yang Message-ID: <56677E6A.5020705@rock-chips.com> Date: Wed, 9 Dec 2015 09:05:46 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151208150356.GA14750@rob-hp-laptop> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On 12/08/2015 11:03 PM, Rob Herring wrote: > On Mon, Dec 07, 2015 at 02:39:34PM +0800, Yakir Yang wrote: >> Rockchip DP driver is a helper driver of analogix_dp coder driver, >> so most of the DT property should be descriped in analogix_dp document. >> >> Signed-off-by: Yakir Yang >> Reviewed-by: Heiko Stuebner > I already acked the previous v10 you sent. > > Acked-by: Rob Herring Ah, I remember it, sorry about the mistaken :-D Thanks - Yakir > >> --- >> Changes in v10: None >> Changes in v9: >> - Document more details for 'ports' property. >> >> Changes in v8: >> - Modify the commit subject name. (Heiko) >> >> Changes in v7: None >> Changes in v6: None >> Changes in v5: >> - Split binding doc's from driver changes. (Rob) >> - Add eDP hotplug pinctrl property. (Heiko) >> >> Changes in v4: None >> Changes in v3: None >> Changes in v2: None >> >> .../display/rockchip/analogix_dp-rockchip.txt | 91 ++++++++++++++++++++++ >> 1 file changed, 91 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt >> >> diff --git a/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt >> new file mode 100644 >> index 0000000..dae86c4 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt >> @@ -0,0 +1,91 @@ >> +Rockchip RK3288 specific extensions to the Analogix Display Port >> +================================ >> + >> +Required properties: >> +- compatible: "rockchip,rk3288-edp"; >> + >> +- reg: physical base address of the controller and length >> + >> +- clocks: from common clock binding: handle to dp clock. >> + of memory mapped region. >> + >> +- clock-names: from common clock binding: >> + Required elements: "dp" "pclk" >> + >> +- resets: Must contain an entry for each entry in reset-names. >> + See ../reset/reset.txt for details. >> + >> +- pinctrl-names: Names corresponding to the chip hotplug pinctrl states. >> +- pinctrl-0: pin-control mode. should be <&edp_hpd> >> + >> +- reset-names: Must include the name "dp" >> + >> +- rockchip,grf: this soc should set GRF regs, so need get grf here. >> + >> +- ports: there are 2 port nodes with endpoint definitions as defined in >> + Documentation/devicetree/bindings/media/video-interfaces.txt. >> + Port 0: contained 2 endpoints, connecting to the ouput of vop. >> + Port 1: contained 1 endpoint, connecting to the input of panel. >> + >> +For the below properties, please refer to Analogix DP binding document: >> + * Documentation/devicetree/bindings/drm/bridge/analogix_dp.txt >> +- phys (required) >> +- phy-names (required) >> +- hpd-gpios (optional) >> +------------------------------------------------------------------------------- >> + >> +Example: >> + dp-controller: dp@ff970000 { >> + compatible = "rockchip,rk3288-dp"; >> + reg = <0xff970000 0x4000>; >> + interrupts = ; >> + clocks = <&cru SCLK_EDP>, <&cru PCLK_EDP_CTRL>; >> + clock-names = "dp", "pclk"; >> + phys = <&dp_phy>; >> + phy-names = "dp"; >> + >> + rockchip,grf = <&grf>; >> + resets = <&cru 111>; >> + reset-names = "dp"; >> + >> + pinctrl-names = "default"; >> + pinctrl-0 = <&edp_hpd>; >> + >> + status = "disabled"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + edp_in: port@0 { >> + reg = <0>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + edp_in_vopb: endpoint@0 { >> + reg = <0>; >> + remote-endpoint = <&vopb_out_edp>; >> + }; >> + edp_in_vopl: endpoint@1 { >> + reg = <1>; >> + remote-endpoint = <&vopl_out_edp>; >> + }; >> + }; >> + >> + edp_out: port@1 { >> + reg = <1>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + edp_out_panel: endpoint { >> + reg = <0>; >> + remote-endpoint = <&panel_in_edp> >> + }; >> + }; >> + }; >> + }; >> + >> + pinctrl { >> + edp { >> + edp_hpd: edp-hpd { >> + rockchip,pins = <7 11 RK_FUNC_2 &pcfg_pull_none>; >> + }; >> + }; >> + }; >> -- >> 1.9.1 >> >> > >