Re: [PATCH v2 1/3] mm, printk: introduce new format string for flags

From: Vlastimil Babka <vbabka@suse.cz>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Minchan Kim <minchan@kernel.org>,
	Sasha Levin <sasha.levin@oracle.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@suse.cz>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH v2 1/3] mm, printk: introduce new format string for flags
Date: Wed, 9 Dec 2015 21:48:41 +0100	[thread overview]
Message-ID: <566893A9.7050704@suse.cz> (raw)
In-Reply-To: <9558837.lN284KClUg@wuerfel>

On 12/09/2015 12:29 PM, Arnd Bergmann wrote:
> On Friday 04 December 2015 16:16:33 Vlastimil Babka wrote:
>> --- a/include/linux/mmdebug.h
>> +++ b/include/linux/mmdebug.h
>> @@ -2,15 +2,20 @@
>>  #define LINUX_MM_DEBUG_H 1
>>  
>>  #include <linux/stringify.h>
>> +#include <linux/types.h>
>> +#include <linux/tracepoint.h>
> 
> 8<-----
> Subject: mm: fix generated/bounds.h
> 
> The inclusion of linux/tracepoint.h is causing build errors for me in ARM
> randconfig:
> 
> In file included from /git/arm-soc/include/linux/ktime.h:25:0,
>                  from /git/arm-soc/include/linux/rcupdate.h:47,
>                  from /git/arm-soc/include/linux/tracepoint.h:19,
>                  from /git/arm-soc/include/linux/mmdebug.h:6,
>                  from /git/arm-soc/include/linux/page-flags.h:10,
>                  from /git/arm-soc/kernel/bounds.c:9:
> /git/arm-soc/include/linux/jiffies.h:10:33: fatal error: generated/timeconst.h: No such file or directory
> compilation terminated.
> 
> To work around this, we can stop including linux/mmdebug.h from linux/page_flags.h
> while generating bounds.h, as we do for mm_types.h already.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks and sorry. Andrew can you please include it in mmotm as -fix for now?
I plan to respin the whole of this later with some patch splitting and
reordering to reduce churn and follow Rasmus' advice.

Also I've just learned that there's a new lightweight tracepoint-defs.h in -tip
thanks to Andi, which would be a better place for struct trace_print_flags than
tracepoint.h is, so I'll look into using it for the respin, which should make
this temporary -fix redundant.

> Fixes: 8c0d593d0f8f ("mm, printk: introduce new format string for flags")

Note that the linux-next commit id is volatile here (regenerated from quilt series).

> 
> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> index 19724e6ebd26..4efad0578a28 100644
> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -7,8 +7,8 @@
>  
>  #include <linux/types.h>
>  #include <linux/bug.h>
> -#include <linux/mmdebug.h>
>  #ifndef __GENERATING_BOUNDS_H
> +#include <linux/mmdebug.h>
>  #include <linux/mm_types.h>
>  #include <generated/bounds.h>
>  #endif /* !__GENERATING_BOUNDS_H */
> 