From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752275AbbLJNhn (ORCPT ); Thu, 10 Dec 2015 08:37:43 -0500 Received: from mail1.bemta12.messagelabs.com ([216.82.251.6]:11041 "EHLO mail1.bemta12.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751969AbbLJNhm (ORCPT ); Thu, 10 Dec 2015 08:37:42 -0500 X-Env-Sender: Sebastian_Frias@sigmadesigns.com X-Msg-Ref: server-8.tower-163.messagelabs.com!1449754659!12725130!1 X-Originating-IP: [195.215.56.170] X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Message-ID: <56698022.1070305@sigmadesigns.com> Date: Thu, 10 Dec 2015 14:37:38 +0100 From: Sebastian Frias User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Michal Hocko CC: Marc Gonzalez , linux-mm , LKML Subject: Re: m(un)map kmalloc buffers to userspace References: <5667128B.3080704@sigmadesigns.com> <20151209135544.GE30907@dhcp22.suse.cz> <566835B6.9010605@sigmadesigns.com> <20151209143207.GF30907@dhcp22.suse.cz> <56684062.9090505@sigmadesigns.com> <20151209151254.GH30907@dhcp22.suse.cz> <56684A59.7030605@sigmadesigns.com> <20151210114005.GF19496@dhcp22.suse.cz> In-Reply-To: <20151210114005.GF19496@dhcp22.suse.cz> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [172.27.0.214] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/10/2015 12:40 PM, Michal Hocko wrote: > On Wed 09-12-15 16:35:53, Sebastian Frias wrote: > [...] >> We've seen that drivers/media/pci/zoran/zoran_driver.c for example seems to >> be doing as us kmalloc+remap_pfn_range, > > This driver is broken - I will post a patch. Ok, we'll be glad to see a good example, please keep us posted. > >> is there any guarantee (or at least an advised heuristic) to determine >> if a driver is "current" (ie: uses the latest APIs and works)? > > OK, it seems I was overly optimistic when directing you to existing > drivers. Sorry about that I wasn't aware you could find such a terrible > code there. Please refer to Linux Device Drivers book which should give > you a much better lead (e.g. http://www.makelinux.net/ldd3/chp-15-sect-2) > Thank you for the link. The current code of our driver was has portions written following LDD3, however, we it seems that LDD3 advice is not relevant anymore. Indeed, it talks about VM_RESERVED, it talks about using "nopage" and it says that remap_pfn_range cannot be used for pages from get_user_page (or kmalloc). It seems such assertions are valid on older kernels, because the code stops working on 3.4+ if we use remap_pfn_range the same way than drivers/media/pci/zoran/zoran_driver.c However, kmalloc+remap_pfn_range does work on 4.1.13+