From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932216AbbLNKDo (ORCPT ); Mon, 14 Dec 2015 05:03:44 -0500 Received: from mout.web.de ([212.227.17.12]:63712 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932099AbbLNKDm (ORCPT ); Mon, 14 Dec 2015 05:03:42 -0500 Subject: Re: staging: lustre: Rename a jump label for ptlrpc_req_finished() calls To: Dan Carpenter References: <566ABCD9.1060404@users.sourceforge.net> <566D7733.1030102@users.sourceforge.net> <566D7884.5050407@users.sourceforge.net> <20151214065325.GS5284@mwanda> <566E86F3.9010209@users.sourceforge.net> <20151214093121.GU5284@mwanda> Cc: devel@driverdev.osuosl.org, Andreas Dilger , Greg Kroah-Hartman , kernel-janitors@vger.kernel.org, LKML , Oleg Drokin , Julia Lawall , lustre-devel@lists.lustre.org From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <566E93EB.3000309@users.sourceforge.net> Date: Mon, 14 Dec 2015 11:03:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151214093121.GU5284@mwanda> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:AFI3E5UcW5TyYAqrXwdJuCN2dw2Dpyjrlr//grFPVBv37iNDUSG b615peZt03EnPy2dWZHolaK+fsjks/AaWgpG9ofgcqP5Xd1+AqzTSLT5u3K5g7E4EGTVNze /rvqqIZh+DOmvJlp/Qxy5u86dOHDF27Uynprpj7W1qZuAGmzpFZcR2yGKY2tF2Fm3FUglTb wVhC1u+NJ7kLje1CbJcDg== X-UI-Out-Filterresults: notjunk:1;V01:K0:tlKuw0aVZh0=:6SdjgB1Qffuyycvm8nErkf ZGmXznbQglTj9mIyt4ysXL7tR78WRaQKpNdJDGSuLVsOHNUT6dfWn1iDDvXKZ+arkoIYt4CGT P6lmOFpG+0P4SsnUdbXUCSsVMqv3A4NK19zkwOtCmNJGM8UIsTEUe1l+8dP9fbZNlXCXEGvjl JA8R6s+xB8XJ7KfZGi1kNEn/z9PG6KWlHCd2x4bXfajSMkB0O3B9+IP1882vcmTh2JYZnUigK hCUqH5eBVMx8jf+qhRWOBBlfiecB7s3RqqNzBM2/XbeADO6DDoPScrD+Nx5RTIgmcMRN++x4b 4Udrpc4mv94RPetkKBeclyxrbACfl0IPjM7aOiutvPKSjycxclX8mm64dVVONH6LMyz22iGuo xY4KCRpAMW+wDK3CyQ0BEsfvwKroAA1phFksuCa4PlG1CzgkSFAqzIforWdphUuELrvmHCHFa 6M/WGDDqbfPAz2Qnz5XQCJdgsG5WsvptVItFdcDQVu49GYD9g/FyfvbHG7gTpIyKErjbn9yo/ 4a+wolEM3S3b4qUnpYC0veQcz1esQZPDPA3oMrSZ9We5khGPpszM8ffFje/UUrEYJuNuSK0uU DVm0CaSXQy0MlyL7kJobTDdI3WH5R7UPSru9Xsf1JTZzlg5hmMzKse/mcdakr6/2wBauQlr9E L7fPtN2uQAN721rOkqg6FZYhK+jZaCnJd04Bs4UEN+0fNcvlP6kFgyogw3NJMaef4TS1xvh2j bBLkXEmhEHKL3ipmwJgCbcoxrmNxxRQ89uYKpPDoUw5XCM1wmeqMaVAcS6PiDFQIx4L7zNsoF rvMo3KX Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> Markus, please stop sending these things to rename out labels unless >>> there is a bug. CodingStyle allows out labels. >> >> How does this feedback fit to information like the following? >> >> "… >> Chapter 7: … >> … >> Choose label names which say what the goto does or why the goto exists. > > A lot of people think "out" says what the goto does and why it exists. I have got the impression that this short identifier is only partly appropriate. > I personally don't agree with them I guess that my opinion goes into a similar direction here. > but if you look at when I complain about it, it's almost always > when it causes a bug. I agree that the combination with bug fixing is more appealing than an attempt to improve coding style applications. >> … Avoid using GW-BASIC names … > > Those when people just use numbers for their label names instead of > words like out1, out2, out4, out5. It's a different thing. The difference is not so clear for me as it appears to you. How many software developers can still remember habits around the selection of such identifiers from GW-BASIC times? Regards, Markus