From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932199AbbLNK2N (ORCPT ); Mon, 14 Dec 2015 05:28:13 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:12609 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932148AbbLNK2L (ORCPT ); Mon, 14 Dec 2015 05:28:11 -0500 X-AuditID: cbfec7f5-f79b16d000005389-36-566e99b8f273 Subject: Re: [PATCH 12/38] HSI: omap_ssi_port: fix handling of_get_named_gpio result To: linux-kernel@vger.kernel.org, Sebastian Reichel References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> <1442842450-29769-13-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski From: Andrzej Hajda Message-id: <566E9974.1050700@samsung.com> Date: Mon, 14 Dec 2015 11:27:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-version: 1.0 In-reply-to: <1442842450-29769-13-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHLMWRmVeSWpSXmKPExsVy+t/xq7o7ZuaFGfQ1WVlsnLGe1eLyrjls FmuP3GW3OL27xIHFY9OqTjaPvi2rGD0+b5ILYI7isklJzcksSy3St0vgymjbuJGxYCVXxczn /awNjDs5uhg5OSQETCQuTu9ghbDFJC7cW88GYgsJLGWU2L8npYuRC8h+zigxd+8SFpCEsECY RNvce8wgtoiAi8TMNWfZIRrqJN70d4A1MwukS7w9eIQRxGYT0JT4u/kmWJxXQEvicM90sDks AqoSt/4uA7I5OEQFIiQW7ciEKBGU+DH5HlgJp4CrROve2UwgJcwCehL3L2pBTJeX2LzmLfME RoFZSDpmIVTNQlK1gJF5FaNoamlyQXFSeq6RXnFibnFpXrpecn7uJkZIqH7dwbj0mNUhRgEO RiUe3oxluWFCrIllxZW5hxglOJiVRHgTrPLChHhTEiurUovy44tKc1KLDzFKc7AoifPO3PU+ REggPbEkNTs1tSC1CCbLxMEp1cB4cV7iy+hb55Xl/5/We3WrtDqA6WrVfaNpCq1a1tfvqwWW SjupipTf+y3N9ZrLP/3n0bf6yz5wPnnPtuLdiSXmvdKT6+Irrqgxli++LeLc5t6U93/9I1E1 43PXK84VnrUzWDNf3rWZu+nltSONs1dPu9+n6HNV04txw0Ol2mVbVx2MuKJ05e49JZbijERD Leai4kQA+F3qslECAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Ping - almost three months passed. Regards Andrzej On 09/21/2015 03:33 PM, Andrzej Hajda wrote: > The function can return negative value. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 > > Signed-off-by: Andrzej Hajda > --- > drivers/hsi/controllers/omap_ssi_port.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/hsi/controllers/omap_ssi_port.c b/drivers/hsi/controllers/omap_ssi_port.c > index 1f8652b..d93dd09 100644 > --- a/drivers/hsi/controllers/omap_ssi_port.c > +++ b/drivers/hsi/controllers/omap_ssi_port.c > @@ -1147,13 +1147,13 @@ static int __init ssi_port_probe(struct platform_device *pd) > goto error; > } > > - cawake_gpio = of_get_named_gpio(np, "ti,ssi-cawake-gpio", 0); > - if (cawake_gpio < 0) { > + err = of_get_named_gpio(np, "ti,ssi-cawake-gpio", 0); > + if (err < 0) { > dev_err(&pd->dev, "DT data is missing cawake gpio (err=%d)\n", > - cawake_gpio); > - err = -ENODEV; > + err); > goto error; > } > + cawake_gpio = err; > > err = devm_gpio_request_one(&port->device, cawake_gpio, GPIOF_DIR_IN, > "cawake");