From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754115AbbLOSDO (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Dec 2015 13:03:14 -0500
Received: from mout.web.de ([212.227.17.12]:61015 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753528AbbLOSDM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Dec 2015 13:03:12 -0500
Subject: Re: staging: lustre: Delete unnecessary goto statements in six
 functions
To: Joe Perches <joe@perches.com>, Dan Carpenter <dan.carpenter@oracle.com>
References: <566ABCD9.1060404@users.sourceforge.net>
 <566D7733.1030102@users.sourceforge.net>
 <566D7830.9060000@users.sourceforge.net>
 <1450189676.3551.1.camel@perches.com> <20151215144133.GC5284@mwanda>
 <1450191751.3551.14.camel@perches.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Oleg Drokin <oleg.drokin@intel.com>, lustre-devel@lists.lustre.org,
        devel@driverdev.osuosl.org, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <567055C4.8000806@users.sourceforge.net>
Date: Tue, 15 Dec 2015 19:02:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <1450191751.3551.14.camel@perches.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:GNetrbUxJKwFANWv06z4sJ/rqOfKIAT0h7cSkosPTBxld9wKZ9b
 bu2xAbxd6U+xzfVcn+VyWkTlEafOq7vkNTAeuZRWSJQGPlmVboG7lfsAE1y347FN6tSdkQ0
 5BXt0lnHzGF+aLZbw68djOC/6U5gG0oXdSSYMWKlktc/4NqDk+Ys/ivsqlTCXNA8BKJStUF
 XQOvyn9WsAwzOEQlFRHiA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:HXBhkS+6WD8=:wEefIwv4fEFzxRczASlVcz
 2K6vFkI41VgAnA7zIIgMSiOj0YQ9tuKtpQpu+/DrU397ee5nywRpUCfl1rZeVQjDAvUfXYS60
 9O+k/D4Y+aSytXXcYGDK/+xCQcLZPJh+Yd0VmQBPMbrSGZe6FU6a2lm54jOAEP56SnLlrUEze
 kM5NklVR4lxDBbv6ZiQa+4PnwNRD04FZ2oochp6+VhjMHZqsVKJymT+DUcCkBSwMZ7VbSchIe
 l2b+vhphMl9BpqDGRXXFYWEErM27HBEWvSh58p2Hh77nS/irWId7SqD90y98gjlHgmIJRkS+3
 7jFBcHAH4hBSsIig4DKgDULoHfZyCJu1UGTHZa8ebEflrp3dxG1TawoGtqrejibI+ENujWD0L
 sT9NGnYEQzNnuMz9etSJYYM0Qv9GPHwvabxIL1sWkmhKyFyj9CkgqebzuNNBzisOYyhOMDHGg
 MhrcDKfyAsSB9PszLlxxwVoAfd3caeIU7ej0T0ugfvDWVvGDRLHlVdtXrVhPiDvEkpzwfDZwz
 D7WoV51vH831O1mmvzuTlbjcZRBtJSyjFZgi5eOiOpgh59AweGhqyFfjSIdhTiPy0gXI1CTij
 Eq+7azxSdpr67o/C0vj1PWBfWIbIR/SfiFMQsn9CdEr2tYzff1WQlsyKhzkcL1Mw2aJ5jqPsd
 b75p3kbB8dj2j291W8Qf60iCaXOnLpcYcKmkCzy5cTu92abWI3tHj6teVa4Vdxm3ky5afn+T6
 32qsiPCKq9N2oVbZdypU+CFLmFOo+juBUxBIkcevnCcD7/r+gFVtfgHHY5f/hxU+1AVlQaXZ6
 lWhp9kZ
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> This is the original code:
Really …?
> 	result = baz();
> 	if (result)
> 		goto label;
>
> label:
> 	go on...

I do not see such a source code structure
at the six places I propose to clean-up.


> I don't find the test->goto label; label: use offensive,
> but if he does, I think keeping a blank line in place of
> the test->goto might be better.

I find this an interesting view on source code layout.
Are there any more opinions around such implementation details?

Regards,
Markus