From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965283AbbLOS1X (ORCPT ); Tue, 15 Dec 2015 13:27:23 -0500 Received: from mout.web.de ([212.227.15.14]:63894 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964953AbbLOS1W (ORCPT ); Tue, 15 Dec 2015 13:27:22 -0500 Subject: Re: staging: lustre: Delete unnecessary goto statements in six functions To: Joe Perches References: <566ABCD9.1060404@users.sourceforge.net> <566D7733.1030102@users.sourceforge.net> <566D7830.9060000@users.sourceforge.net> <1450189676.3551.1.camel@perches.com> <20151215144133.GC5284@mwanda> <1450191751.3551.14.camel@perches.com> <20151215174844.GE5284@mwanda> <1450203011.4142.4.camel@perches.com> Cc: Dan Carpenter , Andreas Dilger , Greg Kroah-Hartman , Oleg Drokin , lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <56705B71.6090307@users.sourceforge.net> Date: Tue, 15 Dec 2015 19:26:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1450203011.4142.4.camel@perches.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:q5cJEN6s2pRcW45ohhyC7tBFCf6LCtrLAwxxzBe+bdCwKu60Fo3 2HYZ/ICCEq9mhwP4iJqaDO7vOsijktZ4hZ+aLIt1RM8bPvUua44N/B5AFnh8j0RrAXLSoU9 zZVAgp4bGuXWFzIneacDXMLCEgy/cM/udsUdiyVUI1oKUSk7Ud2hBG4zOW2DmU1sFzcO3em 98ZcQQH8sN4eNtEEbpT9A== X-UI-Out-Filterresults: notjunk:1;V01:K0:PiN/ukKvr4c=:Dddnbbvi5t8LJRF22jvWmc JCNyZ9UtWgQWY6i9GnJzMhihtZDuKl9TpgUIjpFGBUW8TT+UhOKvgt3B5hsv8B6jBV+5bal4u UoTl1OuIoy4wW831Htgkqj7C2tmqIIbyWiP5gHmXQQ/FYSUvZ0IocTLVYqZ6rD+qYyo0Eyyof 9CXqNDFtohkloZs4t4yAqrrol3fIsPcyjTooWCS3aww2VGJC8bT7IuhphUojG0Cwzw45gBGUd Qy5DZLdEOFGQjbyvQpwh9R1ArbXwWjJaSrSII49xNmHo4+uEaDGJRabLX9PPCWwoKQLaMlwJL k0xvoXOHKS/+e9fl45UgVOVSsEH8NC4fzFMcxAtchYH0WI3QbsCqgJfVWuHkjX0ZHYhTFXTVI +SB/ADsKgH4uSWDxA1CeYnjVJHtKmNPoHwc3V1kctT6TTudRf8htCaRgIEejAz3TR4tHRIo2x 9scawbNtZ/uimzO5ox47mz0++hSacq/XkYj6vFx44/iT7rts9aOlR7UpO714yzZfvLntYp33m 8EVVPnyDukWLhv3TeHf4NL3v789Lu9IMfwfKRvkuXCHQFj5j0+AU7XcQdTMy3aP2xud7aCblg Lto95oI0fgs1BOkibhzXmPlI7XArese487L3GsgWq71BPnLYi69Ua3WqHmflbBcEWUeaZXAWY TfTttmiW1+0Y2sfhZKcw98+1+js2mZsHGg/IzcHarcdfg0eHZzFb42dbLnuPHsP8HXxxFLtGE Ror4Fok7dyJOxSgVZfI1jMr5hjvJDvXXbjlEOx3mqyG1WGyOjDE3G22iLeaaN3YGyT74Uh3LO /zjjAkp Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > rc = mdc_queue_wait(req); > goto out; > out: > ptlrpc_req_finished(req); > return rc; > } > --------------------- > > I think if the last goto out; is to be removed, > then it should be replaced by a blank line. > > It separates the last operation block from the return. Would you like to point a very specific coding style issue out? How often should jump labels preceded with blank lines? Regards, Markus