From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933927AbbLPCDA (ORCPT ); Tue, 15 Dec 2015 21:03:00 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:25105 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932602AbbLPCC7 (ORCPT ); Tue, 15 Dec 2015 21:02:59 -0500 Message-ID: <5670C634.9090403@huawei.com> Date: Wed, 16 Dec 2015 10:02:28 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Jiri Olsa CC: , , , , , , Alexei Starovoitov , Arnaldo Carvalho de Melo , Namhyung Kim Subject: Re: [PATCH v5 10/14] perf tools: Enable indices setting syntax for BPF maps References: <1450089563-122430-1-git-send-email-wangnan0@huawei.com> <1450089563-122430-11-git-send-email-wangnan0@huawei.com> <20151215134219.GC31734@krava.brq.redhat.com> In-Reply-To: <20151215134219.GC31734@krava.brq.redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.5670C644.00CA,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 873b73b7910d7a6e7b0842e3554f9a45 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/12/15 21:42, Jiri Olsa wrote: > On Mon, Dec 14, 2015 at 10:39:19AM +0000, Wang Nan wrote: >> This patch introduce a new syntax to perf event parser: >> >> # perf record -e './test_bpf_map_3.c/maps:channel.value[0,1,2,3...5]=101/' usleep 2 > why 3 dots? I'd think the standard is 2 ? The standard (actually it is a gcc extension, not C standard) is 3 dots. Please have a look at [1] and [2]. Although I also think '..' is better. So after you seeing this, do you still think we should follow our intuition instead of following GCC? If you still prefer '..' I'll change it. Thank you. [1] https://lkml.org/lkml/2015/11/23/4 [2] https://gcc.gnu.org/onlinedocs/gcc/Case-Ranges.html Thank you. > just curious > [0,1,2,3..5] > 3 made me think there's something speecial about it ;-) > > > jirka