From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934337AbbLPRGw (ORCPT <rfc822;w@1wt.eu>);
	Wed, 16 Dec 2015 12:06:52 -0500
Received: from mail-pa0-f46.google.com ([209.85.220.46]:33110 "EHLO
	mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S934157AbbLPRGu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 16 Dec 2015 12:06:50 -0500
Subject: Re: [PATCH 06/11] tty: serial: 8250: Move EXPORT_SYMBOL to function
To: Anton Wuerfel <anton.wuerfel@fau.de>, linux-serial@vger.kernel.org
References: <1450280177-4460-1-git-send-email-anton.wuerfel@fau.de>
 <1450280177-4460-7-git-send-email-anton.wuerfel@fau.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>,
        "James E.J. Bottomley" <jejb@parisc-linux.org>,
        Helge Deller <deller@gmx.de>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Qipeng Zha <qipeng.zha@intel.com>, Desmond Liu <desmondl@broadcom.com>,
        Wang Long <long.wanglong@huawei.com>,
        Matt Redfearn <matt.redfearn@imgtec.com>,
        Paul Burton <paul.burton@imgtec.com>,
        Ralf Baechle <ralf@linux-mips.org>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Peter Hung <hpeter@gmail.com>,
        Soeren Grunewald <soeren.grunewald@desy.de>,
        Adam Lee <adam.lee@canonical.com>,
        "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
        Mans Rullgard <mans@mansr.com>, linux-kernel@vger.kernel.org,
        linux-parisc@vger.kernel.org, linux-kernel@i4.cs.fau.de,
        Phillip Raffeck <phillip.raffeck@fau.de>
From: Peter Hurley <peter@hurleysoftware.com>
Message-ID: <56719A27.4060102@hurleysoftware.com>
Date: Wed, 16 Dec 2015 09:06:47 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <1450280177-4460-7-git-send-email-anton.wuerfel@fau.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/16/2015 07:36 AM, Anton Wuerfel wrote:
> This patch moves EXPORT_SYMBOL macros directly after the definition of
> the corresponding symbol to remove checkpatch warnings.

Ok.


> Signed-off-by: Anton Würfel <anton.wuerfel@fau.de>
> Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>
> CC: linux-kernel@i4.cs.fau.de
> ---
>  drivers/tty/serial/8250/8250_core.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index 89a20c9..67147b2 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -764,6 +764,7 @@ void serial8250_suspend_port(int line)
>  
>  	uart_suspend_port(&serial8250_reg, port);
>  }
> +EXPORT_SYMBOL(serial8250_suspend_port);
>  
>  /**
>   *	serial8250_resume_port - resume one serial port
> @@ -789,6 +790,7 @@ void serial8250_resume_port(int line)
>  	}
>  	uart_resume_port(&serial8250_reg, port);
>  }
> +EXPORT_SYMBOL(serial8250_resume_port);
>  
>  /*
>   * Register a set of serial devices attached to a platform device.  The
> @@ -1168,9 +1170,6 @@ static void __exit serial8250_exit(void)
>  module_init(serial8250_init);
>  module_exit(serial8250_exit);
>  
> -EXPORT_SYMBOL(serial8250_suspend_port);
> -EXPORT_SYMBOL(serial8250_resume_port);
> -
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("Generic 8250/16x50 serial driver");
>  
>