From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934315AbbLPXti (ORCPT ); Wed, 16 Dec 2015 18:49:38 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:33152 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932125AbbLPXtg (ORCPT ); Wed, 16 Dec 2015 18:49:36 -0500 X-AuditID: cbfec7f5-f79b16d000005389-ea-5671f88df52a Subject: Re: [PATCH 12/19] ARM: dts: exynos: replace legacy *,wakeup property with wakeup-source To: Sudeep Holla , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org References: <1445422216-29375-1-git-send-email-sudeep.holla@arm.com> <1445422216-29375-13-git-send-email-sudeep.holla@arm.com> Cc: Kukjin Kim , linux-samsung-soc@vger.kernel.org From: Krzysztof Kozlowski Message-id: <5671F88F.7050802@samsung.com> Date: Thu, 17 Dec 2015 08:49:35 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-version: 1.0 In-reply-to: <1445422216-29375-13-git-send-email-sudeep.holla@arm.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOLMWRmVeSWpSXmKPExsVy+t/xq7q9PwrDDCZvk7OYf+Qcq8XrF4YW /Y9fM1tsenyN1eLyrjlsFjPO72OyWH5qB4sDu8eaeWsYPTat6mTz2Lyk3qNvyypGj8+b5AJY o7hsUlJzMstSi/TtErgyfq0/yFzQI1sxd9NElgbGK2JdjJwcEgImEldnXmSCsMUkLtxbz9bF yMUhJLCUUeLywV5mCOcpo8SSk1OAHA4OYYEkiakn7UDiIgKdjBLnGu6wQxQ1MEosPvCMDaSI WcBF4tGjVJCpbALGEpuXL2EDsXkFtCSO7l3JAmKzCKhKrDv8nhWkXFQgQmLRjkyIEkGJH5Pv gZVwCrhJ/Pj1lwliop7E/YtaIGFmAXmJzWveMk9gFJiFpGMWQtUsJFULGJlXMYqmliYXFCel 5xrpFSfmFpfmpesl5+duYoQE99cdjEuPWR1iFOBgVOLh3bG7MEyINbGsuDL3EKMEB7OSCO/3 PUAh3pTEyqrUovz4otKc1OJDjNIcLErivDN3vQ8REkhPLEnNTk0tSC2CyTJxcEo1MN7iPFG+ rby+ZnWg72PTMN1VKWLPZ18/+YPTOJ3Fs2ebmuUvRef0N7Vlxi5CXOER4iLOviIcvhLK9bMb eA8pqRfO2qjaWHgnOrYifUdpk+9jzvOXC3uthdhsYjTzD5azsT10EVN9ZPZw94Ni/wiLtWUX A03W7L308MFUwUCpW315vHPuGMYrsRRnJBpqMRcVJwIAT2H2NmoCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.10.2015 19:10, Sudeep Holla wrote: > Though the keyboard and other driver will continue to support the legacy > "gpio-key,wakeup", "linux-keypad,wakeup" boolean property to enable the > wakeup source, "wakeup-source" is the new standard binding. > > This patch replaces all the legacy wakeup properties with the unified > "wakeup-source" property in order to avoid any futher copy-paste > duplication. > > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Sudeep Holla > --- > arch/arm/boot/dts/exynos3250-monk.dts | 6 +++--- > arch/arm/boot/dts/exynos3250-rinato.dts | 6 +++--- > arch/arm/boot/dts/exynos4210-origen.dts | 10 +++++----- > arch/arm/boot/dts/exynos4210-smdkv310.dts | 2 +- > arch/arm/boot/dts/exynos4210-trats.dts | 2 +- > arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 ++-- > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 +- > arch/arm/boot/dts/exynos4412-odroidx.dts | 2 +- > arch/arm/boot/dts/exynos4412-origen.dts | 2 +- > arch/arm/boot/dts/exynos4412-smdk4412.dts | 2 +- > arch/arm/boot/dts/exynos4412-trats2.dts | 4 ++-- > arch/arm/boot/dts/exynos5250-arndale.dts | 12 ++++++------ > arch/arm/boot/dts/exynos5250-snow.dts | 4 ++-- > arch/arm/boot/dts/exynos5250-spring.dts | 4 ++-- > arch/arm/boot/dts/exynos5420-arndale-octa.dts | 2 +- > arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 ++-- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 4 ++-- > 17 files changed, 36 insertions(+), 36 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts > index 540a0adf2be6..b77ea2163a0a 100644 > --- a/arch/arm/boot/dts/exynos3250-monk.dts > +++ b/arch/arm/boot/dts/exynos3250-monk.dts > @@ -43,7 +43,7 @@ > linux,code = ; > label = "power key"; > debounce-interval = <10>; > - gpio-key,wakeup; > + wakeup-source; > }; > }; > > @@ -67,7 +67,7 @@ > interrupt-parent = <&gpx1>; > interrupts = <5 0>; > reg = <0x25>; > - wakeup; > + wakeup-source; > > muic: max77836-muic { > compatible = "maxim,max77836-muic"; > @@ -184,7 +184,7 @@ > interrupt-parent = <&gpx0>; > interrupts = <7 0>; > reg = <0x66>; > - wakeup; > + wakeup-source; > > s2mps14_osc: clocks { > compatible = "samsung,s2mps14-clk"; > diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts > index 41a5fafb9aa9..7acd11d2d957 100644 > --- a/arch/arm/boot/dts/exynos3250-rinato.dts > +++ b/arch/arm/boot/dts/exynos3250-rinato.dts > @@ -43,7 +43,7 @@ > linux,code = ; > label = "power key"; > debounce-interval = <10>; > - gpio-key,wakeup; > + wakeup-source; > }; > }; > > @@ -58,7 +58,7 @@ > interrupt-parent = <&gpx1>; > interrupts = <5 0>; > reg = <0x25>; > - wakeup; > + wakeup-source; > > muic: max77836-muic { > compatible = "maxim,max77836-muic"; > @@ -245,7 +245,7 @@ > interrupt-parent = <&gpx0>; > interrupts = <7 0>; > reg = <0x66>; > - wakeup; > + wakeup-source; I think here and in Monk board these four "wakeup" properties are bogus, not parsed by driver. Instead wakeup is always initialized to true. Anyway fixing this is not part of this patch but instead this should be fixed in separate commit. Here everything looks good: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof