From: shuah <shuah@kernel.org>
To: Alan Maguire <alan.maguire@oracle.com>,
kbuild test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, brendanhiggins@google.com,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
kunit-dev@googlegroups.com, keescook@chromium.org,
yzaikin@google.com, akpm@linux-foundation.org,
yamada.masahiro@socionext.com, catalin.marinas@arm.com,
joe.lawrence@redhat.com, penguin-kernel@i-love.sakura.ne.jp,
urezki@gmail.com, andriy.shevchenko@linux.intel.com,
corbet@lwn.net, davidgow@google.com, adilger.kernel@dilger.ca,
tytso@mit.edu, mcgrof@kernel.org, linux-doc@vger.kernel.org,
Knut Omang <knut.omang@oracle.com>, shuah <shuah@kernel.org>
Subject: Re: [PATCH v6 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module
Date: Mon, 6 Jan 2020 11:56:37 -0700 [thread overview]
Message-ID: <5671f077-d2ed-2e26-7588-29d1e4b8123e@kernel.org> (raw)
In-Reply-To: <alpine.LRH.2.20.1912191424440.27984@dhcp-10-175-218-218.vpn.oracle.com>
On 12/19/19 7:28 AM, Alan Maguire wrote:
> On Thu, 19 Dec 2019, kbuild test robot wrote:
>
>> Hi Alan,
>>
>> Thank you for the patch! Yet something to improve:
>>
>> [auto build test ERROR on linus/master]
>> [also build test ERROR on linux/master v5.5-rc2 next-20191218]
>> [cannot apply to ext4/dev]
>> [if your patch is applied to the wrong git tree, please drop us a note to help
>> improve the system. BTW, we also suggest to use '--base' option to specify the
>> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
>>
>> url: https://github.com/0day-ci/linux/commits/Alan-Maguire/kunit-support-building-core-tests-as-modules/20191207-021244
>> base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b0d4beaa5a4b7d31070c41c2e50740304a3f1138
>> config: x86_64-randconfig-e002-20191218 (attached as .config)
>> compiler: gcc-7 (Debian 7.5.0-1) 7.5.0
>> reproduce:
>> # save the attached .config to linux build tree
>> make ARCH=x86_64
>>
>> If you fix the issue, kindly add following tag
>> Reported-by: kbuild test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>> drivers/base/power/qos-test.c:117:1: warning: data definition has no type or storage class
>> kunit_test_suite(pm_qos_test_module);
>> ^~~~~~~~~~~~~~~~
>
> I hadn't thought about the possibility that other trees
> would have added kunit tests in the interim; it probably
> makes most sense to not retire the kunit_test_suite()
> definition (it can be trivially defined via kunit_test_suites().
> Converting the test suite isn't an option as it's not in
> the kselftest-test tree.
>
> I'll spin up a v7 patchset with that 1-line change to patch 3
> as I don't _think_ these changes have been pulled in yet.
>
Alan,
Please do send v7. I will pull it for 5.6.
thanks,
-- Shuah
next prev parent reply other threads:[~2020-01-06 18:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 15:27 [PATCH v6 linux-kselftest-test 0/6] kunit: support building core/tests as modules Alan Maguire
2019-12-04 15:27 ` [PATCH v6 linux-kselftest-test 1/6] kunit: move string-stream.h to lib/kunit Alan Maguire
2019-12-04 15:27 ` [PATCH v6 linux-kselftest-test 2/6] kunit: hide unexported try-catch interface in try-catch-impl.h Alan Maguire
2019-12-04 15:27 ` [PATCH v6 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module Alan Maguire
2019-12-04 21:47 ` Iurii Zaikin
2019-12-18 22:52 ` kbuild test robot
2019-12-19 14:28 ` Alan Maguire
2020-01-06 18:56 ` shuah [this message]
2019-12-04 15:27 ` [PATCH v6 linux-kselftest-test 4/6] kunit: remove timeout dependence on sysctl_hung_task_timeout_seconds Alan Maguire
2019-12-04 15:27 ` [PATCH v6 linux-kselftest-test 5/6] kunit: allow kunit to be loaded as a module Alan Maguire
2019-12-04 15:27 ` [PATCH v6 linux-kselftest-test 6/6] kunit: update documentation to describe module-based build Alan Maguire
2019-12-13 1:11 ` [PATCH v6 linux-kselftest-test 0/6] kunit: support building core/tests as modules Brendan Higgins
2020-01-06 18:54 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5671f077-d2ed-2e26-7588-29d1e4b8123e@kernel.org \
--to=shuah@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=alan.maguire@oracle.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brendanhiggins@google.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=davidgow@google.com \
--cc=joe.lawrence@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=keescook@chromium.org \
--cc=knut.omang@oracle.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mcgrof@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=tytso@mit.edu \
--cc=urezki@gmail.com \
--cc=yamada.masahiro@socionext.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).