From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933470AbbLRAe3 (ORCPT ); Thu, 17 Dec 2015 19:34:29 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:60036 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932384AbbLRAe1 (ORCPT ); Thu, 17 Dec 2015 19:34:27 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee690-f79646d000001316-5a-56735490023a Content-transfer-encoding: 8BIT Message-id: <56735486.8020609@samsung.com> Date: Fri, 18 Dec 2015 09:34:14 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , myungjoo.ham@samsung.com, kgene@kernel.org Cc: kyungmin.park@samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, tjakobi@math.uni-bielefeld.de, linux.amoon@gmail.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver References: <1450075104-13705-1-git-send-email-cw00.choi@samsung.com> <1450075104-13705-2-git-send-email-cw00.choi@samsung.com> <566F8BF2.20606@samsung.com> In-reply-to: <566F8BF2.20606@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsWyRsSkQHdCSHGYwb5JRhbzj5xjteh/s5DV 4tyrlYwWr18YWvQ/fs1scbbpDbvF5V1z2Cw+9x5htJhxfh+TxbqNt9gtbl/mtVh6/SKTxe3G FWwWE6avZbFo3XuE3aJt9QdWBwGPNfPWMHq0NPeweVzu62Xy2DnrLrvHyuVf2Dw2repk8/h3 jN2jb8sqRo/Pm+QCOKO4bFJSczLLUov07RK4MlqOdTAWbBSv2NO8k72BsUu4i5GTQ0LARKL9 0C1GCFtM4sK99WxdjFwcQgIrGCXuHu5kgSl69nwJK0RiKaPExfvzmEESvAKCEj8m3wMq4uBg FpCXOHIpGyTMLKAuMWneImaI+geMEmsetDFC1GtJPDu9mA3EZhFQlfi35h7YHDag+P4XN9hA 5ogKREh0n6gECYsIxEtsenEV7CBmgbtMEhffPwGrERaIlZi+OARi/gJGiQeTVoEdyimgKXHp WTvYYgmBLRwSi949ZIVYJiDxbfIhsEMlBGQlNh1ghnhMUuLgihssExjFZiF5ZxbCO7OQvLOA kXkVo2hqQXJBcVJ6kYlecWJucWleul5yfu4mRmDEn/73bMIOxnsHrA8xCnAwKvHwGrAVhwmx JpYVV+YeYjQFOmIis5Rocj4wreSVxBsamxlZmJqYGhuZW5opifO+lvoZLCSQnliSmp2aWpBa FF9UmpNafIiRiYNTqoEx6pHXhi2d7cc+S7pqapqnP9i85nwS22W+ZHPm/hvqXdfbEk9Z+W07 Mk1to3uQvo2maoLm50vrFiiEn5z2S2iH+DmbSX6sNfdSw4VWnE9csDX/9BGfrVp1IXwV/mmJ +UcKN4TPTTJfXyu7SfI9S8bPoxfVnl0vVhWet2KBY+2tf9t/xtVPNkxUYinOSDTUYi4qTgQA 31jTkPMCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLKsWRmVeSWpSXmKPExsVy+t9jAd0JIcVhBpc3a1vMP3KO1aL/zUJW i3OvVjJavH5haNH/+DWzxdmmN+wWl3fNYbP43HuE0WLG+X1MFus23mK3uH2Z12Lp9YtMFrcb V7BZTJi+lsWide8Rdou21R9YHQQ81sxbw+jR0tzD5nG5r5fJY+esu+weK5d/YfPYtKqTzePf MXaPvi2rGD0+b5IL4IxqYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xN tVVy8QnQdcvMAfpCSaEsMacUKBSQWFyspG+HaUJoiJuuBUxjhK5vSBBcj5EBGkhYw5jRcqyD sWCjeMWe5p3sDYxdwl2MnBwSAiYSz54vYYWwxSQu3FvP1sXIxSEksJRR4uL9ecwgCV4BQYkf k++xdDFycDALyEscuZQNEmYWUJeYNG8RM0T9A0aJNQ/aGCHqtSSenV7MBmKzCKhK/FtzD2wO G1B8/4sbbCBzRAUiJLpPVIKERQTiJTa9uAq2l1ngLpPExfdPwGqEBWIlpi8OgZi/gFHiwaRV LCANnAKaEpeetTNPYBSYheS8WQjnzUJy3gJG5lWMEqkFyQXFSem5hnmp5XrFibnFpXnpesn5 uZsYwUnlmdQOxoO73A8xCnAwKvHw3mAuDhNiTSwrrsw9xCjBwawkwmv/uihMiDclsbIqtSg/ vqg0J7X4EKMp0H8TmaVEk/OBCS+vJN7Q2MTMyNLI3NDCyNhcSZy39lJkmJBAemJJanZqakFq EUwfEwenVAPjxj92+xXWsdyaZFzIVRAU+SBV0+DvDfmsVWola5tn7JRvYmk6KTB7nu/NeDW7 yg0nbzNU+qaFHVbIeCTzK1bw+BLBwKhNM97c1p+l8Lbs+aSLAopuNjY6z7029PFmhm54+cnK WW/meS3lDAsjmVmuhesT3kctU7o1p3LBhPy3RpFvdhzMWJmixFKckWioxVxUnAgACP8Em0AD AAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2015년 12월 15일 12:41, Krzysztof Kozlowski wrote: > On 14.12.2015 15:38, Chanwoo Choi wrote: >> This patch adds the generic exynos bus frequency driver for AMBA AXI bus >> of sub-blocks in exynos SoC with DEVFREQ framework. The Samsung Exynos SoC >> have the common architecture for bus between DRAM and sub-blocks in SoC. >> This driver can support the generic bus frequency driver for Exynos SoCs. >> >> In devicetree, Each bus block has a bus clock, regulator, operation-point >> and devfreq-event devices which measure the utilization of each bus block. >> >> Signed-off-by: Chanwoo Choi >> [linux.amoon: Tested on Odroid U3] >> Tested-by: Anand Moon >> --- >> drivers/devfreq/Kconfig | 15 ++ >> drivers/devfreq/Makefile | 1 + >> drivers/devfreq/exynos/Makefile | 1 + >> drivers/devfreq/exynos/exynos-bus.c | 449 ++++++++++++++++++++++++++++++++++++ >> 4 files changed, 466 insertions(+) >> create mode 100644 drivers/devfreq/exynos/exynos-bus.c >> >> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig >> index 64281bb2f650..55ec774f794c 100644 >> --- a/drivers/devfreq/Kconfig >> +++ b/drivers/devfreq/Kconfig >> @@ -66,6 +66,21 @@ config DEVFREQ_GOV_USERSPACE >> >> comment "DEVFREQ Drivers" >> >> +config ARM_EXYNOS_BUS_DEVFREQ >> + bool "ARM EXYNOS Generic Memory Bus DEVFREQ Driver" >> + depends on ARCH_EXYNOS >> + select DEVFREQ_GOV_SIMPLE_ONDEMAND >> + select DEVFREQ_EVENT_EXYNOS_PPMU >> + select PM_DEVFREQ_EVENT >> + select PM_OPP >> + help >> + This adds the common DEVFREQ driver for Exynos Memory bus. Exynos >> + Memory bus has one more group of memory bus (e.g, MIF and INT block). >> + Each memory bus group could contain many memoby bus block. It reads >> + PPMU counters of memory controllers by using DEVFREQ-event device >> + and adjusts the operating frequencies and voltages with OPP support. >> + This does not yet operate with optimal voltages. >> + >> config ARM_EXYNOS4_BUS_DEVFREQ >> bool "ARM Exynos4210/4212/4412 Memory Bus DEVFREQ Driver" >> depends on (CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412) && !ARCH_MULTIPLATFORM >> diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile >> index 5134f9ee983d..375ebbb4fcfb 100644 >> --- a/drivers/devfreq/Makefile >> +++ b/drivers/devfreq/Makefile >> @@ -6,6 +6,7 @@ obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE) += governor_powersave.o >> obj-$(CONFIG_DEVFREQ_GOV_USERSPACE) += governor_userspace.o >> >> # DEVFREQ Drivers >> +obj-$(CONFIG_ARCH_EXYNOS) += exynos/ > > Why limiting it to ARCH_EXYNOS? Are there real dependencies on exynos > mach code? Or on ARM code? There is no dependency. > > If not, then this probably should be obj-y to allow compile testing. > Particular objects would be selected by ARM_EXYNOS_BUS_DEVFREQ. OK. I'll alter it as obj-y. Best Regards, Chanwoo Choi