From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934260AbbLRAnr (ORCPT ); Thu, 17 Dec 2015 19:43:47 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:60086 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753512AbbLRAno (ORCPT ); Thu, 17 Dec 2015 19:43:44 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68f-f793a6d000001364-ad-567356be1ff8 Content-transfer-encoding: 8BIT Message-id: <567356B6.5030403@samsung.com> Date: Fri, 18 Dec 2015 09:43:34 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , myungjoo.ham@samsung.com, kgene@kernel.org Cc: kyungmin.park@samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, tjakobi@math.uni-bielefeld.de, linux.amoon@gmail.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver References: <1450075104-13705-1-git-send-email-cw00.choi@samsung.com> <1450075104-13705-2-git-send-email-cw00.choi@samsung.com> <566F8BF2.20606@samsung.com> <56735486.8020609@samsung.com> In-reply-to: <56735486.8020609@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHIsWRmVeSWpSXmKPExsWyRsSkSHd/WHGYwbupzBbzj5xjteh/s5DV 4tyrlYwWr18YWvQ/fs1scbbpDbvF5V1z2Cw+9x5htJhxfh+TxbqNt9gtbl/mtVh6/SKTxe3G FWwWE6avZbFo3XuE3aJt9QdWBwGPNfPWMHq0NPeweVzu62Xy2DnrLrvHyuVf2Dw2repk8/h3 jN2jb8sqRo/Pm+QCOKO4bFJSczLLUov07RK4MuasncRecEWyomv5ApYGxh7RLkZODgkBE4lZ 936zQdhiEhfurQeyuTiEBFYwSrx52M8MU3SraQFUYhajxL/VR8E6eAUEJX5MvsfSxcjBwSwg L3HkUjaEqS4xZUouRPkDRomJbx4zQ5RrSSycf5oFxGYRUJV4+2oXE4jNBhTf/+IGG0ivqECE RPeJSpCwiEC8xKYXV8HWMgvcZZK4+P4JWI2wQKzE9MUhEPP3M0r8mPIWbA6ngLZE77z5zCAJ CYGVHBKH39xmh1gmIPFt8iGwOyUEZCU2HYD6S1Li4IobLBMYxWYh+WYWwjezEL5ZwMi8ilE0 tSC5oDgpvchYrzgxt7g0L10vOT93EyMw2k//e9a/g/HuAetDjAIcjEo8vIZsxWFCrIllxZW5 hxhNgW6YyCwlmpwPTCl5JfGGxmZGFqYmpsZG5pZmSuK8C6V+BgsJpCeWpGanphakFsUXleak Fh9iZOLglGpgrFd+2vZllVyZ+2KThmo1tpNrLiUxzJvjFhnMqBm9ST8u4WL00z12W0/MnhP2 Vyg+YZPLarcPHc+4b/W8qdBpYfhztn7Vyua6NJszc7KUJGwX8vbP0vAX4TmoftI6h/eCZtOO ulL1y0tuCNhVrq+13VmbupUnV/7W68PvVEuePSlmi9j4bPVdJZbijERDLeai4kQAUNayqvEC AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNKsWRmVeSWpSXmKPExsVy+t9jQd19YcVhBj/3WFrMP3KO1aL/zUJW i3OvVjJavH5haNH/+DWzxdmmN+wWl3fNYbP43HuE0WLG+X1MFus23mK3uH2Z12Lp9YtMFrcb V7BZTJi+lsWide8Rdou21R9YHQQ81sxbw+jR0tzD5nG5r5fJY+esu+weK5d/YfPYtKqTzePf MXaPvi2rGD0+b5IL4IxqYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xN tVVy8QnQdcvMAfpCSaEsMacUKBSQWFyspG+HaUJoiJuuBUxjhK5vSBBcj5EBGkhYw5gxZ+0k 9oIrkhVdyxewNDD2iHYxcnJICJhI3GpawAZhi0lcuLceyObiEBKYxSjxb/VRsASvgKDEj8n3 WLoYOTiYBeQljlzKhjDVJaZMyYUof8AoMfHNY2aIci2JhfNPs4DYLAKqEm9f7WICsdmA4vtf 3GAD6RUViJDoPlEJEhYRiJfY9OIq2FpmgbtMEhffPwGrERaIlZi+OARi/n5GiR9T3oLN4RTQ luidN595AiPQkQjXzUK4bhbCdQsYmVcxSqQWJBcUJ6XnGuallusVJ+YWl+al6yXn525iBCeU Z1I7GA/ucj/EKMDBqMTDe4O5OEyINbGsuDL3EKMEB7OSCK/966IwId6UxMqq1KL8+KLSnNTi Q4ymQO9NZJYSTc4HJru8knhDYxMzI0sjc0MLI2NzJXHe2kuRYUIC6YklqdmpqQWpRTB9TByc Ug2Mx728cpi3zjmdyNR/d56T98zzxQvuPBfZka7WWbq8UXORgQnL67gr+e6if249aNmaP1E7 XKk5/nzOXKH+9QYs198flGyQYD79RuuX6v43ldrPNcPvCScF7ZVe0co/2S2w+pblalH/ubr/ uObUNa9n3vYq4F5AbfON9ZwpCopfnu8I/n9yXZavEktxRqKhFnNRcSIA3RcLEz4DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 12월 18일 09:34, Chanwoo Choi wrote: > Hi, > > On 2015년 12월 15일 12:41, Krzysztof Kozlowski wrote: >> On 14.12.2015 15:38, Chanwoo Choi wrote: >>> This patch adds the generic exynos bus frequency driver for AMBA AXI bus >>> of sub-blocks in exynos SoC with DEVFREQ framework. The Samsung Exynos SoC >>> have the common architecture for bus between DRAM and sub-blocks in SoC. >>> This driver can support the generic bus frequency driver for Exynos SoCs. >>> >>> In devicetree, Each bus block has a bus clock, regulator, operation-point >>> and devfreq-event devices which measure the utilization of each bus block. >>> >>> Signed-off-by: Chanwoo Choi >>> [linux.amoon: Tested on Odroid U3] >>> Tested-by: Anand Moon >>> --- >>> drivers/devfreq/Kconfig | 15 ++ >>> drivers/devfreq/Makefile | 1 + >>> drivers/devfreq/exynos/Makefile | 1 + >>> drivers/devfreq/exynos/exynos-bus.c | 449 ++++++++++++++++++++++++++++++++++++ >>> 4 files changed, 466 insertions(+) >>> create mode 100644 drivers/devfreq/exynos/exynos-bus.c >>> >>> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig >>> index 64281bb2f650..55ec774f794c 100644 >>> --- a/drivers/devfreq/Kconfig >>> +++ b/drivers/devfreq/Kconfig >>> @@ -66,6 +66,21 @@ config DEVFREQ_GOV_USERSPACE >>> >>> comment "DEVFREQ Drivers" >>> >>> +config ARM_EXYNOS_BUS_DEVFREQ >>> + bool "ARM EXYNOS Generic Memory Bus DEVFREQ Driver" >>> + depends on ARCH_EXYNOS >>> + select DEVFREQ_GOV_SIMPLE_ONDEMAND >>> + select DEVFREQ_EVENT_EXYNOS_PPMU >>> + select PM_DEVFREQ_EVENT >>> + select PM_OPP >>> + help >>> + This adds the common DEVFREQ driver for Exynos Memory bus. Exynos >>> + Memory bus has one more group of memory bus (e.g, MIF and INT block). >>> + Each memory bus group could contain many memoby bus block. It reads >>> + PPMU counters of memory controllers by using DEVFREQ-event device >>> + and adjusts the operating frequencies and voltages with OPP support. >>> + This does not yet operate with optimal voltages. >>> + >>> config ARM_EXYNOS4_BUS_DEVFREQ >>> bool "ARM Exynos4210/4212/4412 Memory Bus DEVFREQ Driver" >>> depends on (CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412) && !ARCH_MULTIPLATFORM >>> diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile >>> index 5134f9ee983d..375ebbb4fcfb 100644 >>> --- a/drivers/devfreq/Makefile >>> +++ b/drivers/devfreq/Makefile >>> @@ -6,6 +6,7 @@ obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE) += governor_powersave.o >>> obj-$(CONFIG_DEVFREQ_GOV_USERSPACE) += governor_userspace.o >>> >>> # DEVFREQ Drivers >>> +obj-$(CONFIG_ARCH_EXYNOS) += exynos/ >> >> Why limiting it to ARCH_EXYNOS? Are there real dependencies on exynos >> mach code? Or on ARM code? > > There is no dependency. > >> >> If not, then this probably should be obj-y to allow compile testing. >> Particular objects would be selected by ARM_EXYNOS_BUS_DEVFREQ. > > OK. I'll alter it as obj-y. As you commented, CONFIG_ARM_EXYNOS_BUS_DEVFREQ is more appropriate without exynos/ directory as following: +obj-$(CONFIG_ARM_EXYNOS_BUS_DEVFREQ) += exynos-bus.o Best Regards, Chanwoo Choi