From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754077AbbLRDn5 (ORCPT ); Thu, 17 Dec 2015 22:43:57 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:51919 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752496AbbLRDny (ORCPT ); Thu, 17 Dec 2015 22:43:54 -0500 X-AuditID: cbfee68f-f793a6d000001364-2c-567380f8d9ff Subject: Re: [PATCH v6 0/9] samsung: pmu: split up SoC specific PMU data To: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org References: <1447740351-14246-1-git-send-email-pankaj.dubey@samsung.com> <56724896.1080009@samsung.com> Cc: kgene.kim@samsung.com, thomas.ab@samsung.com, amitdanielk@gmail.com, olof@lixom.net, khilman@linaro.org, arnd@arndb.de From: "pankaj.dubey" Message-id: <5673811D.7040808@samsung.com> Date: Fri, 18 Dec 2015 09:14:29 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-version: 1.0 In-reply-to: <56724896.1080009@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJIsWRmVeSWpSXmKPExsWyRsSkSvdHQ3GYwYI3UhYfV79ks/g76Ri7 xesXhha9C66yWXw9vILRYtPja6wWl3fNYbP43HuE0WLG+X1MFqeuf2az6FjG6MDt8fvXJEaP nbPusnvcubaHzWPzknqPKyeaWD36tqxi9Pi8SS6APYrLJiU1J7MstUjfLoEr49nnhcwFi5Uq tnZdYmxgvCjdxcjJISFgIvHhy18mCFtM4sK99WxdjFwcQgIrGCWO/f/CDlM0o+UBE0RiFqPE h90/WEESQgLfGSXu3M4BsYUFPCSe/JzEDFIkIrCNUeJz61bGLkYOoKJMiQlH3UFqmAVqJE5/ usIIYrMJ6EtMf7yNDcTmFdCSWPJ4OVicRUBVYt7z2SwgraICERKLdmRClAhK/Jh8DyzMKaAt 0XKUH8RkFtCTuH9RC2K4vMTmNW+ZIS7+yy4x+78kxEABiW+TD4F1SgjISmw6AFUiKXFwxQ2W CYxis5DMn4UwdBaSoQsYmVcxiqYWJBcUJ6UXGesVJ+YWl+al6yXn525iBMbo6X/P+ncw3j1g fYhRgINRiYfXkK04TIg1say4MvcQoynQEROZpUST84GJIK8k3tDYzMjC1MTU2Mjc0kxJnHeh 1M9gIYH0xJLU7NTUgtSi+KLSnNTiQ4xMHJxSDYzefxZ9twtOfcSRO3kbd7/qH7sye4GKcwuM GLsmBjTsagtc0swaZKQ8002kjfP1xs9W6/52BUXYLcsTenTscGLMNZfZLmsaK2NMYnT4T616 3XQ55eX89+bVa4KTS0zeuEnbOy5Ji1fonNH7lunlOrn6A5Z1D7UleDvLmtmadvMyXDzBzJj2 WomlOCPRUIu5qDgRAP7Nj5/MAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnleLIzCtJLcpLzFFi42I5/e+xoO6PhuIwgzff+C0+rn7JZvF30jF2 i9cvDC16F1xls/h6eAWjxabH11gtLu+aw2bxufcIo8WM8/uYLE5d/8xm0bGM0YHb4/evSYwe O2fdZfe4c20Pm8fmJfUeV040sXr0bVnF6PF5k1wAe1QDo01GamJKapFCal5yfkpmXrqtkndw vHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0IlKCmWJOaVAoYDE4mIlfTtME0JD3HQtYBoj dH1DguB6jAzQQMIaxoxnnxcyFyxWqtjadYmxgfGidBcjJ4eEgInEjJYHTBC2mMSFe+vZuhi5 OIQEZjFKfNj9gxUkISTwnVHizu0cEFtYwEPiyc9JzCBFIgLbGCU+t25l7GLkACrKlJhw1B2k hlmgRuL0pyuMIDabgL7E9Mfb2EBsXgEtiSWPl4PFWQRUJeY9n80C0ioqECGxaEcmRImgxI/J 98DCnALaEi1H+UFMZgE9ifsXtSCGy0tsXvOWeQIj0IkIDbMQqmYhqVrAyLyKUSK1ILmgOCk9 1ygvtVyvODG3uDQvXS85P3cTIzgRPJPewXh4l/shRgEORiUe3hvMxWFCrIllxZW5hxglOJiV RHgDwoFCvCmJlVWpRfnxRaU5qcWHGE2BnpjILCWanA9MUnkl8YbGJuamxqaWJhYmZpZK4rz7 LkWGCQmkJ5akZqemFqQWwfQxcXBKNTBm5/az/Iv53mD6bKmTyJtqrfTiaTtj2iwuXHnomSqk 53PM3rtefspEy1PbfjbsXHJOxSrZ7feThuDFjzdd+G1QadLZu/jlizvMXu8Y3hU6/eYyVPIt SZny2HThPbHL4uaMahPYDwTUHr7cELZAe8veFXcvrwvy23dgJZvfOYUm0Vd3j0lXHeRQYinO SDTUYi4qTgQAi6db6hoDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Thursday 17 December 2015 11:01 AM, Krzysztof Kozlowski wrote: > On 17.11.2015 15:05, Pankaj Dubey wrote: >> In this series I am splitting up SoC specific PMU configuration data into >> mach-exynos folder itself, before moving all of them under >> drivers/soc/samsung/. Also instead of making all changes in single patch it >> has been broken into SoC specific patches to avoid large size of patch. >> With this approach there will not be unwanted big churns just after >> adding exynos-pmu under drivers/soc/samsung. >> >> All these patches are just refactoring to keep minimal changes while moving >> exynos-pmu driver under drivers/soc/samsung/. Support for exynos7 PMU can >> be added on top of it, in such a manner that for ARM64 build, ARM related >> SoC's PMU will not get compiled and thus unnecessary increasing kernel image size. >> >> These patches have been prepared on top of Kukjin Kim's for-next merged with >> driver-samsung and on top of >> cherry-picked change from [1]. >> >> 1: ARM: EXYNOS: Constify local exynos_pmu_data structure >> https://lkml.org/lkml/2015/10/28/917 >> >> For testing entire patchset on Peach-Pi (Exynos5880) based chromebook for boot >> and S2R functionality. >> >> Tested-by: Pankaj Dubey >> >> For testing entire patchset on on Trats2 (Exynos4412, S2R, reboot, poweroff) >> and Odroid XU3 (Exynos5422, reboot, poweroff). >> >> Tested-by: Krzysztof Kozlowski >> >> Changes since v5: >> - Removed extra blank line from patch 5/9 and 6/9. >> - Modified soc/samsung/Kconfig for config EXNOS_PMU. Added depends on ARM. >> >> Changes since v4: >> - In v3 I missed to give -M flag to detect rename, which made patches hard >> to review, so resubmitting patches with rename detector flag. >> - Addressed review comments from Krzysztof. >> >> Changes since v3: >> - Keeping intact copyright dates in existing header files. >> - Addressed review comments from Krzysztof for v3. >> - Removing static inline function from exynos-pmu.h and >> keeping them in PMU driver. >> - Added new patch (2/9) for fixing potential null pointer reference in >> exynos_sys_powerdown_conf. >> - Added new patch (8/9) for rearranging static and non-static function for >> better readability. >> >> Changes since v2: >> - Removed Amit's Samsung id as it's no more valid. >> - Rebased on latest kgene tree. >> - Removed redundant code from regs-pmu.h >> >> Pankaj Dubey (9): >> ARM: EXYNOS: removing redundant code from regs-pmu.h >> ARM: EXYNOS: Fix potential NULL pointer access in >> exynos_sys_powerdown_conf >> ARM: EXYNOS: Move pmu specific headers under "linux/soc/samsung" >> ARM: EXYNOS: split up exynos3250 SoC specific PMU data >> ARM: EXYNOS: split up exynos4 SoC specific PMU data >> ARM: EXYNOS: split up exynos5250 SoC specific PMU data >> ARM: EXYNOS: split up exynos5420 SoC specific PMU data >> ARM: EXYNOS: rearrange static and non-static functions of PMU driver >> drivers: soc: Add support for Exynos PMU driver >> > > I tried to apply this to my branch: > next/stuff-late-not-split-per-branch > https://git.kernel.org/cgit/linux/kernel/git/krzk/linux.git/log/?h=next/stuff-late-not-split-per-branch > > Unfortunately it fails on: > error: patch failed: arch/arm/mach-exynos/pmu.c:17 > error: arch/arm/mach-exynos/pmu.c: patch does not apply > Patch failed at 0001 ARM: EXYNOS: Move pmu specific headers under > "linux/soc/samsung" > > because of syscon-reboot handlers (Alim's work). > > I think I have all the dependencies already in my > "next/stuff-late-not-split-per-branch". > If you want to proceed now, can you rebase on top of it? Otherwise we > could wait and rebase later (after v4.5-rc1). > > Thanks for looking into this. I have just posted v7 of this series after rebasing on "next/stuff-late-not-split-per-branch". Please have a look and if all OK, include v7 in your branch, and lets try to get this in for v4.5. For some reason if does not go, I am OK to wait for next cycle. Thanks, Pankaj Dubey > P.S. Please note that "next/stuff-late-not-split-per-branch" is not > included in linux-next because I am not sure if I will be able to push > it out soon. > > > Best regards, > Krzysztof > >