From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [RFC PATCH 0/3] VFIO: capability chains
Date: Fri, 18 Dec 2015 15:34:30 +1100 [thread overview]
Message-ID: <56738CD6.7000105@ozlabs.ru> (raw)
In-Reply-To: <1450406317.2674.160.camel@redhat.com>
On 12/18/2015 01:38 PM, Alex Williamson wrote:
> On Fri, 2015-12-18 at 13:05 +1100, Alexey Kardashevskiy wrote:
>> On 11/24/2015 07:43 AM, Alex Williamson wrote:
>>> Please see the commit log and comments in patch 1 for a general
>>> explanation of the problems that this series tries to address. The
>>> general problem is that we have several cases where we want to
>>> expose
>>> variable sized information to the user, whether it's sparse mmaps
>>> for
>>> a region, as implemented here, or DMA mapping ranges of an IOMMU,
>>> or
>>> reserved MSI mapping ranges, etc. Extending data structures is
>>> hard;
>>> extending them to report variable sized data is really hard. After
>>> considering several options, I think the best approach is to copy
>>> how
>>> PCI does capabilities. This allows the ioctl to only expose the
>>> capabilities that are relevant for them, avoids data structures
>>> that
>>> are too complicated to parse, and avoids creating a new ioctl each
>>> time we think of something else that we'd like to report. This
>>> method
>>> also doesn't preclude extensions to the fixed structure since the
>>> offset of these capabilities is entirely dynamic.
>>>
>>> Comments welcome, I'll also follow-up to the QEMU and KVM lists
>>> with
>>> an RFC making use of this for mmaps skipping over the MSI-X table.
>>> Thanks,
>>
>> Out of curiosity - could this information be exposed to the userspace
>> via
>> /sys/bus/pci/devices/xxxx:xx:xx:x/vfio_xxxx? It seems not to change
>> after
>> vfio_pci driver is bound to a device.
>
> For what purpose? vfio doesn't have a sysfs interface, why start one?
> Thanks,
well, it could simplify debugging a bit if this information was available
from the userspace without programming a test tool doing some ioctl()'s.
Not a big deal though...
--
Alexey
prev parent reply other threads:[~2015-12-18 4:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 20:43 [RFC PATCH 0/3] VFIO: capability chains Alex Williamson
2015-11-23 20:43 ` [RFC PATCH 1/3] vfio: Define " Alex Williamson
2015-11-23 20:43 ` [RFC PATCH 2/3] vfio: Define sparse mmap capability for regions Alex Williamson
2015-11-23 20:43 ` [RFC PATCH 3/3] vfio/pci: Include sparse mmap capability for MSI-X table regions Alex Williamson
2015-12-18 2:05 ` [RFC PATCH 0/3] VFIO: capability chains Alexey Kardashevskiy
2015-12-18 2:38 ` Alex Williamson
2015-12-18 4:34 ` Alexey Kardashevskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56738CD6.7000105@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).